| Message ID | 20221116151833.1679379-2-maxime@cerno.tech (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] drm/tests: client: Remove extra blank lines | expand |
Hi Maxime, On 11/16/22 12:18, Maxime Ripard wrote: > The SPDX header is missing, let's add it and fix the corresponding > checkpatch warning. > > Suggested-by: Maíra Canal <mairacanal@riseup.net> > Fixes: 44a3928324e9 ("drm/tests: Add Kunit Helpers") > Signed-off-by: Maxime Ripard <maxime@cerno.tech> Could you add the SPDX-License-Identifier tag on the header file as well? With the SPDX header on both files, this is: Reviewed-by: Maíra Canal <mairacanal@riseup.net> Best Regards, - Maíra Canal > --- > drivers/gpu/drm/tests/drm_kunit_helpers.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/tests/drm_kunit_helpers.c b/drivers/gpu/drm/tests/drm_kunit_helpers.c > index eea450de7de8..f1662091f250 100644 > --- a/drivers/gpu/drm/tests/drm_kunit_helpers.c > +++ b/drivers/gpu/drm/tests/drm_kunit_helpers.c > @@ -1,3 +1,5 @@ > +// SPDX-License-Identifier: GPL-2.0 > + > #include <drm/drm_drv.h> > #include <drm/drm_managed.h> >
Hi Maira, On Wed, Nov 16, 2022 at 01:48:13PM -0300, Maíra Canal wrote: > Hi Maxime, > > On 11/16/22 12:18, Maxime Ripard wrote: > > The SPDX header is missing, let's add it and fix the corresponding > > checkpatch warning. > > > > Suggested-by: Maíra Canal <mairacanal@riseup.net> > > Fixes: 44a3928324e9 ("drm/tests: Add Kunit Helpers") > > Signed-off-by: Maxime Ripard <maxime@cerno.tech> > > Could you add the SPDX-License-Identifier tag on the header file as > well? With the SPDX header on both files, this is: > > Reviewed-by: Maíra Canal <mairacanal@riseup.net> I applied those patches yesterday, with the fix you suggested Thanks! Maxime
diff --git a/drivers/gpu/drm/tests/drm_kunit_helpers.c b/drivers/gpu/drm/tests/drm_kunit_helpers.c index eea450de7de8..f1662091f250 100644 --- a/drivers/gpu/drm/tests/drm_kunit_helpers.c +++ b/drivers/gpu/drm/tests/drm_kunit_helpers.c @@ -1,3 +1,5 @@ +// SPDX-License-Identifier: GPL-2.0 + #include <drm/drm_drv.h> #include <drm/drm_managed.h>
The SPDX header is missing, let's add it and fix the corresponding checkpatch warning. Suggested-by: Maíra Canal <mairacanal@riseup.net> Fixes: 44a3928324e9 ("drm/tests: Add Kunit Helpers") Signed-off-by: Maxime Ripard <maxime@cerno.tech> --- drivers/gpu/drm/tests/drm_kunit_helpers.c | 2 ++ 1 file changed, 2 insertions(+)