| Message ID | 20221121121725.1910795-3-john.g.garry@oracle.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | scsi: Some minor scan improvements | expand |
On 11/21/22 21:17, John Garry wrote: > Instead of using hardcoded '0' as the do_scsi_scan_host() -> > scsi_scan_host_selected() rescan arg, use proper macro SCSI_SCAN_INITIAL. > > Signed-off-by: John Garry <john.g.garry@oracle.com> Looks good. Reviewed-by: Damien Le Moal <damien.lemoal@opensource.wdc.com> > --- > drivers/scsi/scsi_scan.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c > index 6cc974b382c1..920b145f80b7 100644 > --- a/drivers/scsi/scsi_scan.c > +++ b/drivers/scsi/scsi_scan.c > @@ -1920,7 +1920,7 @@ static void do_scsi_scan_host(struct Scsi_Host *shost) > msleep(10); > } else { > scsi_scan_host_selected(shost, SCAN_WILD_CARD, SCAN_WILD_CARD, > - SCAN_WILD_CARD, 0); > + SCAN_WILD_CARD, SCSI_SCAN_INITIAL); > } > } >
On 21/11/2022 12:33, Damien Le Moal wrote: > On 11/21/22 21:17, John Garry wrote: >> Instead of using hardcoded '0' as the do_scsi_scan_host() -> >> scsi_scan_host_selected() rescan arg, use proper macro SCSI_SCAN_INITIAL. >> >> Signed-off-by: John Garry<john.g.garry@oracle.com> > Looks good. > > Reviewed-by: Damien Le Moal<damien.lemoal@opensource.wdc.com> > cheers. As mentioned, I can combine these patches if people prefer. John
On 2022/11/21 20:17, John Garry wrote: > Instead of using hardcoded '0' as the do_scsi_scan_host() -> > scsi_scan_host_selected() rescan arg, use proper macro SCSI_SCAN_INITIAL. > > Signed-off-by: John Garry<john.g.garry@oracle.com> > --- > drivers/scsi/scsi_scan.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Looks good, Reviewed-by: Jason Yan <yanaijie@huawei.com>
On 11/21/22 05:48, John Garry wrote: > cheers. As mentioned, I can combine these patches if people prefer. I'm in favor of combining both patches. Whether or not these patches get combined, feel free to add: Reviewed-by: Bart Van Assche <bvanassche@acm.org>
diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c index 6cc974b382c1..920b145f80b7 100644 --- a/drivers/scsi/scsi_scan.c +++ b/drivers/scsi/scsi_scan.c @@ -1920,7 +1920,7 @@ static void do_scsi_scan_host(struct Scsi_Host *shost) msleep(10); } else { scsi_scan_host_selected(shost, SCAN_WILD_CARD, SCAN_WILD_CARD, - SCAN_WILD_CARD, 0); + SCAN_WILD_CARD, SCSI_SCAN_INITIAL); } }
Instead of using hardcoded '0' as the do_scsi_scan_host() -> scsi_scan_host_selected() rescan arg, use proper macro SCSI_SCAN_INITIAL. Signed-off-by: John Garry <john.g.garry@oracle.com> --- drivers/scsi/scsi_scan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)