| Message ID | 20221116194550.705566-1-jiaozhou@google.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | kernel: Add HP Device 0x8711 to force connect list | expand |
On Wed, 16 Nov 2022 20:45:50 +0100, Jiao Zhou wrote: > > Signed-off-by: Jiao Zhou <jiaozhou@google.com> > --- > HDMI audio is not working on the HP EliteDesk 800 G6 because the pin is > unconnected. This issue can be resolved by using the 'hdajackretask' > tool to override the unconnected pin to force it to connect. > > Change-Id: If7ffc0691466078e59240f9eab89de562b3f119d Please reformat your patch and resubmit. As of this submission, the comment about "HDMI audio is not working..." won't be taken as the patch description since you've put after the line "---". The comment there will be discarded. Also please drop the useless Change-Id tag. And, align the patch subject line with others. In this case, use "ALSA:" prefix, at best, "ALSA: hda/hdmi:" instead of "kernel:". Last but not least, put the subsystem maintainers (me in this case) to Cc at submission. thanks, Takashi > --- > sound/pci/hda/patch_hdmi.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c > index 21edf7a619f0..7a40ddfd695a 100644 > --- a/sound/pci/hda/patch_hdmi.c > +++ b/sound/pci/hda/patch_hdmi.c > @@ -1975,6 +1975,7 @@ static int hdmi_add_cvt(struct hda_codec *codec, hda_nid_t cvt_nid) > static const struct snd_pci_quirk force_connect_list[] = { > SND_PCI_QUIRK(0x103c, 0x870f, "HP", 1), > SND_PCI_QUIRK(0x103c, 0x871a, "HP", 1), > + SND_PCI_QUIRK(0x103c, 0x8711, "HP", 1), > SND_PCI_QUIRK(0x1462, 0xec94, "MS-7C94", 1), > SND_PCI_QUIRK(0x8086, 0x2081, "Intel NUC 10", 1), > {} > -- > 2.38.1.431.g37b22c650d-goog >
diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c index 21edf7a619f0..7a40ddfd695a 100644 --- a/sound/pci/hda/patch_hdmi.c +++ b/sound/pci/hda/patch_hdmi.c @@ -1975,6 +1975,7 @@ static int hdmi_add_cvt(struct hda_codec *codec, hda_nid_t cvt_nid) static const struct snd_pci_quirk force_connect_list[] = { SND_PCI_QUIRK(0x103c, 0x870f, "HP", 1), SND_PCI_QUIRK(0x103c, 0x871a, "HP", 1), + SND_PCI_QUIRK(0x103c, 0x8711, "HP", 1), SND_PCI_QUIRK(0x1462, 0xec94, "MS-7C94", 1), SND_PCI_QUIRK(0x8086, 0x2081, "Intel NUC 10", 1), {}
Signed-off-by: Jiao Zhou <jiaozhou@google.com> --- HDMI audio is not working on the HP EliteDesk 800 G6 because the pin is unconnected. This issue can be resolved by using the 'hdajackretask' tool to override the unconnected pin to force it to connect. Change-Id: If7ffc0691466078e59240f9eab89de562b3f119d --- sound/pci/hda/patch_hdmi.c | 1 + 1 file changed, 1 insertion(+)