| Message ID | 20221118133216.17037-2-walker.chen@starfivetech.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Conor Dooley |
| Headers | show |
| Series | JH7110 Power Domain Support | expand |
| Context | Check | Description |
|---|---|---|
| conchuod/tree_selection | fail | Guessing tree name failed |
On 18/11/2022 14:32, Walker Chen wrote: > Add power domain definitions for the StarFive JH7110 SoC. > > Signed-off-by: Walker Chen <walker.chen@starfivetech.com> > --- > include/dt-bindings/power/jh7110-power.h | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > create mode 100644 include/dt-bindings/power/jh7110-power.h > > diff --git a/include/dt-bindings/power/jh7110-power.h b/include/dt-bindings/power/jh7110-power.h > new file mode 100644 > index 000000000000..24160c46fbaf > --- /dev/null > +++ b/include/dt-bindings/power/jh7110-power.h Filename matching compatible or bindings file. > @@ -0,0 +1,18 @@ > +/* SPDX-License-Identifier: (GPL-2.0) */ Dual license for bindings. > +/* > + * Copyright (C) 2022 StarFive Technology Co., Ltd. > + * Author: Walker Chen <walker.chen@starfivetech.com> > + */ > +#ifndef __DT_BINDINGS_POWER_JH7110_POWER_H__ > +#define __DT_BINDINGS_POWER_JH7110_POWER_H__ Best regards, Krzysztof
On 2022/11/21 18:12, Krzysztof Kozlowski wrote: > On 18/11/2022 14:32, Walker Chen wrote: >> Add power domain definitions for the StarFive JH7110 SoC. >> >> Signed-off-by: Walker Chen <walker.chen@starfivetech.com> >> --- >> include/dt-bindings/power/jh7110-power.h | 18 ++++++++++++++++++ >> 1 file changed, 18 insertions(+) >> create mode 100644 include/dt-bindings/power/jh7110-power.h >> >> diff --git a/include/dt-bindings/power/jh7110-power.h b/include/dt-bindings/power/jh7110-power.h >> new file mode 100644 >> index 000000000000..24160c46fbaf >> --- /dev/null >> +++ b/include/dt-bindings/power/jh7110-power.h > > Filename matching compatible or bindings file. So the file name should be changed to "starfive,jh7110-power.h" and the compatible in the driver should also be changed to "starfive,jh7110-power". Is it right ? > >> @@ -0,0 +1,18 @@ >> +/* SPDX-License-Identifier: (GPL-2.0) */ > > Dual license for bindings. Ok, the license will be changed to GPL-2.0 or MIT in the patch v2. > >> +/* >> + * Copyright (C) 2022 StarFive Technology Co., Ltd. >> + * Author: Walker Chen <walker.chen@starfivetech.com> >> + */ >> +#ifndef __DT_BINDINGS_POWER_JH7110_POWER_H__ >> +#define __DT_BINDINGS_POWER_JH7110_POWER_H__ > > Best regards, > Krzysztof >
On 22/11/2022 08:46, Walker Chen wrote: > On 2022/11/21 18:12, Krzysztof Kozlowski wrote: >> On 18/11/2022 14:32, Walker Chen wrote: >>> Add power domain definitions for the StarFive JH7110 SoC. >>> >>> Signed-off-by: Walker Chen <walker.chen@starfivetech.com> >>> --- >>> include/dt-bindings/power/jh7110-power.h | 18 ++++++++++++++++++ >>> 1 file changed, 18 insertions(+) >>> create mode 100644 include/dt-bindings/power/jh7110-power.h >>> >>> diff --git a/include/dt-bindings/power/jh7110-power.h b/include/dt-bindings/power/jh7110-power.h >>> new file mode 100644 >>> index 000000000000..24160c46fbaf >>> --- /dev/null >>> +++ b/include/dt-bindings/power/jh7110-power.h >> >> Filename matching compatible or bindings file. > > So the file name should be changed to "starfive,jh7110-power.h" and the compatible in the driver > should also be changed to "starfive,jh7110-power". Is it right ? I said filename should be changed. I don't remember what was your compatible, but if I did not comment there, in means it looked fine. > >> >>> @@ -0,0 +1,18 @@ >>> +/* SPDX-License-Identifier: (GPL-2.0) */ >> >> Dual license for bindings. > > Ok, the license will be changed to GPL-2.0 or MIT in the patch v2. Any reasons why not using the licenses recommended by checkpatch? Best regards, Krzysztof
On 2022/11/22 16:03, Krzysztof Kozlowski wrote: > On 22/11/2022 08:46, Walker Chen wrote: >> On 2022/11/21 18:12, Krzysztof Kozlowski wrote: >>> On 18/11/2022 14:32, Walker Chen wrote: >>>> Add power domain definitions for the StarFive JH7110 SoC. >>>> >>>> Signed-off-by: Walker Chen <walker.chen@starfivetech.com> >>>> --- >>>> include/dt-bindings/power/jh7110-power.h | 18 ++++++++++++++++++ >>>> 1 file changed, 18 insertions(+) >>>> create mode 100644 include/dt-bindings/power/jh7110-power.h >>>> >>>> diff --git a/include/dt-bindings/power/jh7110-power.h b/include/dt-bindings/power/jh7110-power.h >>>> new file mode 100644 >>>> index 000000000000..24160c46fbaf >>>> --- /dev/null >>>> +++ b/include/dt-bindings/power/jh7110-power.h >>> >>> Filename matching compatible or bindings file. >> >> So the file name should be changed to "starfive,jh7110-power.h" and the compatible in the driver >> should also be changed to "starfive,jh7110-power". Is it right ? > > I said filename should be changed. I don't remember what was your > compatible, but if I did not comment there, in means it looked fine. > >> >>> >>>> @@ -0,0 +1,18 @@ >>>> +/* SPDX-License-Identifier: (GPL-2.0) */ >>> >>> Dual license for bindings. >> >> Ok, the license will be changed to GPL-2.0 or MIT in the patch v2. > > Any reasons why not using the licenses recommended by checkpatch? > Well, it sounds like a better way to decide which license to use by checkpatch. Thanks for your tip. Best Regards, Walker Chen
diff --git a/include/dt-bindings/power/jh7110-power.h b/include/dt-bindings/power/jh7110-power.h new file mode 100644 index 000000000000..24160c46fbaf --- /dev/null +++ b/include/dt-bindings/power/jh7110-power.h @@ -0,0 +1,18 @@ +/* SPDX-License-Identifier: (GPL-2.0) */ +/* + * Copyright (C) 2022 StarFive Technology Co., Ltd. + * Author: Walker Chen <walker.chen@starfivetech.com> + */ +#ifndef __DT_BINDINGS_POWER_JH7110_POWER_H__ +#define __DT_BINDINGS_POWER_JH7110_POWER_H__ + +#define JH7110_PD_SYSTOP 0 +#define JH7110_PD_CPU 1 +#define JH7110_PD_GPUA 2 +#define JH7110_PD_VDEC 3 +#define JH7110_PD_VOUT 4 +#define JH7110_PD_ISP 5 +#define JH7110_PD_VENC 6 +#define JH7110_PD_GPUB 7 + +#endif
Add power domain definitions for the StarFive JH7110 SoC. Signed-off-by: Walker Chen <walker.chen@starfivetech.com> --- include/dt-bindings/power/jh7110-power.h | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) create mode 100644 include/dt-bindings/power/jh7110-power.h