| Message ID | 20221121221414.109965-6-conor@kernel.org (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | RISC-V: kconfig.socs cleanup, part 1 | expand |
| Context | Check | Description |
|---|---|---|
| conchuod/tree_selection | fail | Guessing tree name failed |
Hi Conor, Thanks for your patch! On Mon, Nov 21, 2022 at 11:18 PM Conor Dooley <conor@kernel.org> wrote: > From: Conor Dooley <conor.dooley@microchip.com> > > The driver is now enabled by default if SOC_MICROCHIP_POLARFIRE so > there is no longer a need to select it in Kconfig.socs Where is it enabled by default? I cannot seem to find that location... > > Signed-off-by: Conor Dooley <conor.dooley@microchip.com> > --- a/arch/riscv/Kconfig.socs > +++ b/arch/riscv/Kconfig.socs > @@ -5,7 +5,6 @@ config ARCH_MICROCHIP_POLARFIRE > > config SOC_MICROCHIP_POLARFIRE > bool "Microchip PolarFire SoCs" > - select MCHP_CLK_MPFS > help > This enables support for Microchip PolarFire SoC platforms. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On 22/11/2022 08:35, Geert Uytterhoeven wrote: > On Mon, Nov 21, 2022 at 11:18 PM Conor Dooley <conor@kernel.org> wrote: >> From: Conor Dooley <conor.dooley@microchip.com> >> >> The driver is now enabled by default if SOC_MICROCHIP_POLARFIRE so >> there is no longer a need to select it in Kconfig.socs > > Where is it enabled by default? > I cannot seem to find that location... Huh, you're right.. I could have sworn I had submitted a patch for that but it turns out I only submitted a patch to make the SiFive clk stuff default on. I suppose my defconfig has an explicit set in it and I never noticed. Thanks Geert!
diff --git a/arch/riscv/Kconfig.socs b/arch/riscv/Kconfig.socs index ce920f627f6d..aca5e750772c 100644 --- a/arch/riscv/Kconfig.socs +++ b/arch/riscv/Kconfig.socs @@ -5,7 +5,6 @@ config ARCH_MICROCHIP_POLARFIRE config SOC_MICROCHIP_POLARFIRE bool "Microchip PolarFire SoCs" - select MCHP_CLK_MPFS help This enables support for Microchip PolarFire SoC platforms.