| Message ID | 20221122123523.3068034-1-john@metanate.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | usb: gadget: f_hid: fix f_hidg lifetime vs cdev | expand |
On Tue, 22 Nov 2022, John Keeping wrote: > This series arises from the recent thread [1] on lifetime issues. > > The main point is the first patch, with the second being an unrelated > fix for an issue spotted while working on this. Both of these have > Fixes: tags for backporting to stable. > > The final patch tidies up some error handling to hopefully avoid patch 2 > issues in the future. > > [1] https://lore.kernel.org/r/20221117120813.1257583-1-lee@kernel.org > > John Keeping (3): > usb: gadget: f_hid: fix f_hidg lifetime vs cdev > usb: gadget: f_hid: fix refcount leak on error path > usb: gadget: f_hid: tidy error handling in hidg_alloc > > drivers/usb/gadget/function/f_hid.c | 60 ++++++++++++++++------------- > 1 file changed, 33 insertions(+), 27 deletions(-) For the set: Reviewed-by: Lee Jones <lee@kernel.org> Tested-by: Lee Jones <lee@kernel.org>
On Tue, 22 Nov 2022, Lee Jones wrote: > On Tue, 22 Nov 2022, John Keeping wrote: > > > This series arises from the recent thread [1] on lifetime issues. > > > > The main point is the first patch, with the second being an unrelated > > fix for an issue spotted while working on this. Both of these have > > Fixes: tags for backporting to stable. > > > > The final patch tidies up some error handling to hopefully avoid patch 2 > > issues in the future. > > > > [1] https://lore.kernel.org/r/20221117120813.1257583-1-lee@kernel.org > > > > John Keeping (3): > > usb: gadget: f_hid: fix f_hidg lifetime vs cdev > > usb: gadget: f_hid: fix refcount leak on error path > > usb: gadget: f_hid: tidy error handling in hidg_alloc > > > > drivers/usb/gadget/function/f_hid.c | 60 ++++++++++++++++------------- > > 1 file changed, 33 insertions(+), 27 deletions(-) > > For the set: > > Reviewed-by: Lee Jones <lee@kernel.org> > Tested-by: Lee Jones <lee@kernel.org> Greg, is this still on your radar?
On Mon, Nov 28, 2022 at 02:04:13PM +0000, Lee Jones wrote: > On Tue, 22 Nov 2022, Lee Jones wrote: > > > On Tue, 22 Nov 2022, John Keeping wrote: > > > > > This series arises from the recent thread [1] on lifetime issues. > > > > > > The main point is the first patch, with the second being an unrelated > > > fix for an issue spotted while working on this. Both of these have > > > Fixes: tags for backporting to stable. > > > > > > The final patch tidies up some error handling to hopefully avoid patch 2 > > > issues in the future. > > > > > > [1] https://lore.kernel.org/r/20221117120813.1257583-1-lee@kernel.org > > > > > > John Keeping (3): > > > usb: gadget: f_hid: fix f_hidg lifetime vs cdev > > > usb: gadget: f_hid: fix refcount leak on error path > > > usb: gadget: f_hid: tidy error handling in hidg_alloc > > > > > > drivers/usb/gadget/function/f_hid.c | 60 ++++++++++++++++------------- > > > 1 file changed, 33 insertions(+), 27 deletions(-) > > > > For the set: > > > > Reviewed-by: Lee Jones <lee@kernel.org> > > Tested-by: Lee Jones <lee@kernel.org> > > Greg, is this still on your radar? Yes, let me catch up on pending patches...
On Mon, 28 Nov 2022, Greg Kroah-Hartman wrote: > On Mon, Nov 28, 2022 at 02:04:13PM +0000, Lee Jones wrote: > > On Tue, 22 Nov 2022, Lee Jones wrote: > > > > > On Tue, 22 Nov 2022, John Keeping wrote: > > > > > > > This series arises from the recent thread [1] on lifetime issues. > > > > > > > > The main point is the first patch, with the second being an unrelated > > > > fix for an issue spotted while working on this. Both of these have > > > > Fixes: tags for backporting to stable. > > > > > > > > The final patch tidies up some error handling to hopefully avoid patch 2 > > > > issues in the future. > > > > > > > > [1] https://lore.kernel.org/r/20221117120813.1257583-1-lee@kernel.org > > > > > > > > John Keeping (3): > > > > usb: gadget: f_hid: fix f_hidg lifetime vs cdev > > > > usb: gadget: f_hid: fix refcount leak on error path > > > > usb: gadget: f_hid: tidy error handling in hidg_alloc > > > > > > > > drivers/usb/gadget/function/f_hid.c | 60 ++++++++++++++++------------- > > > > 1 file changed, 33 insertions(+), 27 deletions(-) > > > > > > For the set: > > > > > > Reviewed-by: Lee Jones <lee@kernel.org> > > > Tested-by: Lee Jones <lee@kernel.org> > > > > Greg, is this still on your radar? > > Yes, let me catch up on pending patches... Perfect, thank you.