diff mbox series

[2/4] dt-bindings: soc: samsung: exynos-sysreg: split from syscon

Message ID 20221125112201.240178-2-krzysztof.kozlowski@linaro.org (mailing list archive)
State Accepted
Commit c2e322ae9f06be31ab5db1f29630f81469a37d75
Headers show
Series [1/4] arm64: dts: exynos: add dedicated SYSREG compatibles to Exynos5433 | expand

Commit Message

Krzysztof Kozlowski Nov. 25, 2022, 11:21 a.m. UTC 
Split Samsung Exynos SoC SYSREG bindings to own file to narrow the
bindings and do not allow other parts of syscon.yaml.  This allows
further customization of Samsung SoC bindings.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

---

Cc: Sriranjani P <sriranjani.p@samsung.com>
Cc: Chanho Park <chanho61.park@samsung.com>
Cc: Sam Protsenko <semen.protsenko@linaro.org>
---
 .../devicetree/bindings/mfd/syscon.yaml       |  6 ---
 .../soc/samsung/samsung,exynos-sysreg.yaml    | 39 +++++++++++++++++++
 2 files changed, 39 insertions(+), 6 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml

Comments

Lee Jones Nov. 25, 2022, 2:05 p.m. UTC | #1 
On Fri, 25 Nov 2022, Krzysztof Kozlowski wrote:

> Split Samsung Exynos SoC SYSREG bindings to own file to narrow the
> bindings and do not allow other parts of syscon.yaml.  This allows
> further customization of Samsung SoC bindings.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> ---
> 
> Cc: Sriranjani P <sriranjani.p@samsung.com>
> Cc: Chanho Park <chanho61.park@samsung.com>
> Cc: Sam Protsenko <semen.protsenko@linaro.org>
> ---
>  .../devicetree/bindings/mfd/syscon.yaml       |  6 ---

Acked-by: Lee Jones <lee@kernel.org>

>  .../soc/samsung/samsung,exynos-sysreg.yaml    | 39 +++++++++++++++++++
>  2 files changed, 39 insertions(+), 6 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
Sam Protsenko Nov. 25, 2022, 2:15 p.m. UTC | #2 
On Fri, 25 Nov 2022 at 05:22, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> Split Samsung Exynos SoC SYSREG bindings to own file to narrow the
> bindings and do not allow other parts of syscon.yaml.  This allows
> further customization of Samsung SoC bindings.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> Cc: Sriranjani P <sriranjani.p@samsung.com>
> Cc: Chanho Park <chanho61.park@samsung.com>
> Cc: Sam Protsenko <semen.protsenko@linaro.org>
> ---

Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org>

>  .../devicetree/bindings/mfd/syscon.yaml       |  6 ---
>  .../soc/samsung/samsung,exynos-sysreg.yaml    | 39 +++++++++++++++++++
>  2 files changed, 39 insertions(+), 6 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
>
> diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml
> index 1b01bd010431..b73ba1ea08f7 100644
> --- a/Documentation/devicetree/bindings/mfd/syscon.yaml
> +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
> @@ -64,12 +64,6 @@ properties:
>                - rockchip,rk3568-qos
>                - rockchip,rk3588-qos
>                - rockchip,rv1126-qos
> -              - samsung,exynos3-sysreg
> -              - samsung,exynos4-sysreg
> -              - samsung,exynos5-sysreg
> -              - samsung,exynos5433-sysreg
> -              - samsung,exynos850-sysreg
> -              - samsung,exynosautov9-sysreg
>
>            - const: syscon
>
> diff --git a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
> new file mode 100644
> index 000000000000..68064a5e339c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
> @@ -0,0 +1,39 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/soc/samsung/samsung,exynos-sysreg.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Samsung Exynos SoC series System Registers (SYSREG)
> +
> +maintainers:
> +  - Krzysztof Kozlowski <krzk@kernel.org>
> +
> +properties:
> +  compatible:
> +    oneOf:
> +      - items:
> +          - enum:
> +              - samsung,exynos3-sysreg
> +              - samsung,exynos4-sysreg
> +              - samsung,exynos5-sysreg
> +              - samsung,exynos5433-sysreg
> +              - samsung,exynos850-sysreg
> +              - samsung,exynosautov9-sysreg
> +          - const: syscon
> +
> +  reg:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    system-controller@10010000 {
> +        compatible = "samsung,exynos4-sysreg", "syscon";
> +        reg = <0x10010000 0x400>;
> +    };
> --
> 2.34.1
>
Sriranjani P Nov. 25, 2022, 2:32 p.m. UTC | #3 
> -----Original Message-----
> From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@linaro.org]
> Sent: 25 November 2022 16:52
> To: Lee Jones <lee@kernel.org>; Rob Herring <robh+dt@kernel.org>;
Krzysztof
> Kozlowski <krzysztof.kozlowski+dt@linaro.org>; Alim Akhtar
> <alim.akhtar@samsung.com>; devicetree@vger.kernel.org; linux-
> kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
linux-samsung-
> soc@vger.kernel.org
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>; Sriranjani P
> <sriranjani.p@samsung.com>; Chanho Park <chanho61.park@samsung.com>;
> Sam Protsenko <semen.protsenko@linaro.org>
> Subject: [PATCH 2/4] dt-bindings: soc: samsung: exynos-sysreg: split from
> syscon
> 
> Split Samsung Exynos SoC SYSREG bindings to own file to narrow the
bindings
> and do not allow other parts of syscon.yaml.  This allows further
customization
> of Samsung SoC bindings.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> ---
> 
> Cc: Sriranjani P <sriranjani.p@samsung.com>
> Cc: Chanho Park <chanho61.park@samsung.com>
> Cc: Sam Protsenko <semen.protsenko@linaro.org>
> ---

We agree for add separate YAML for  Samsung Exynos and hence I think we can 
go ahead and add  separate yaml for Tesla FSD.
Reviewed-by: Sriranjani P <sriranjani.p@samsung.com>

>  .../devicetree/bindings/mfd/syscon.yaml       |  6 ---
>  .../soc/samsung/samsung,exynos-sysreg.yaml    | 39 +++++++++++++++++++
>  2 files changed, 39 insertions(+), 6 deletions(-)  create mode 100644
> Documentation/devicetree/bindings/soc/samsung/samsung,exynos-
> sysreg.yaml
> 
> diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml
> b/Documentation/devicetree/bindings/mfd/syscon.yaml
> index 1b01bd010431..b73ba1ea08f7 100644
> --- a/Documentation/devicetree/bindings/mfd/syscon.yaml
> +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
> @@ -64,12 +64,6 @@ properties:
>                - rockchip,rk3568-qos
>                - rockchip,rk3588-qos
>                - rockchip,rv1126-qos
> -              - samsung,exynos3-sysreg
> -              - samsung,exynos4-sysreg
> -              - samsung,exynos5-sysreg
> -              - samsung,exynos5433-sysreg
> -              - samsung,exynos850-sysreg
> -              - samsung,exynosautov9-sysreg
> 
>            - const: syscon
> 
> diff --git
> a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-
> sysreg.yaml
> b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-
> sysreg.yaml
> new file mode 100644
> index 000000000000..68064a5e339c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-
> sysre
> +++ g.yaml
> @@ -0,0 +1,39 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause %YAML 1.2
> +---
> +$id:
> +https://protect2.fireeye.com/v1/url?k=83e9bb90-e2921107-83e830df-
> 74fe48
> +60001d-5ef78ea8b86e70d7&q=1&e=8db037ae-b28c-44df-a71b-
> 6e7c367bb9d6&u=ht
> +tp%3A%2F%2Fdevicetree.org%2Fschemas%2Fsoc%2Fsamsung%2Fsamsung%
> 2Cexynos-
> +sysreg.yaml%23
> +$schema:
> +https://protect2.fireeye.com/v1/url?k=84a37bbf-e5d8d128-84a2f0f0-74fe48
> +60001d-bf5bdaa08b35d382&q=1&e=8db037ae-b28c-44df-a71b-
> 6e7c367bb9d6&u=ht
> +tp%3A%2F%2Fdevicetree.org%2Fmeta-schemas%2Fcore.yaml%23
> +
> +title: Samsung Exynos SoC series System Registers (SYSREG)
> +
> +maintainers:
> +  - Krzysztof Kozlowski <krzk@kernel.org>
> +
> +properties:
> +  compatible:
> +    oneOf:
> +      - items:
> +          - enum:
> +              - samsung,exynos3-sysreg
> +              - samsung,exynos4-sysreg
> +              - samsung,exynos5-sysreg
> +              - samsung,exynos5433-sysreg
> +              - samsung,exynos850-sysreg
> +              - samsung,exynosautov9-sysreg
> +          - const: syscon
> +
> +  reg:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    system-controller@10010000 {
> +        compatible = "samsung,exynos4-sysreg", "syscon";
> +        reg = <0x10010000 0x400>;
> +    };
> --
> 2.34.1
Alim Akhtar Nov. 25, 2022, 4:56 p.m. UTC | #4 
>-----Original Message-----
>From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@linaro.org]
>Sent: Friday, November 25, 2022 4:52 PM
>To: Lee Jones <lee@kernel.org>; Rob Herring <robh+dt@kernel.org>;
>Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>; Alim Akhtar
><alim.akhtar@samsung.com>; devicetree@vger.kernel.org; linux-
>kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
>samsung-soc@vger.kernel.org
>Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>; Sriranjani P
><sriranjani.p@samsung.com>; Chanho Park <chanho61.park@samsung.com>;
>Sam Protsenko <semen.protsenko@linaro.org>
>Subject: [PATCH 2/4] dt-bindings: soc: samsung: exynos-sysreg: split from
>syscon
>
>Split Samsung Exynos SoC SYSREG bindings to own file to narrow the bindings
>and do not allow other parts of syscon.yaml.  This allows further
customization
>of Samsung SoC bindings.
>
>Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>

Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
>---
>
>Cc: Sriranjani P <sriranjani.p@samsung.com>
>Cc: Chanho Park <chanho61.park@samsung.com>
>Cc: Sam Protsenko <semen.protsenko@linaro.org>
>---
> .../devicetree/bindings/mfd/syscon.yaml       |  6 ---
> .../soc/samsung/samsung,exynos-sysreg.yaml    | 39
>+++++++++++++++++++
> 2 files changed, 39 insertions(+), 6 deletions(-)  create mode 100644
>Documentation/devicetree/bindings/soc/samsung/samsung,exynos-
>sysreg.yaml
>
>diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml
>b/Documentation/devicetree/bindings/mfd/syscon.yaml
>index 1b01bd010431..b73ba1ea08f7 100644
>--- a/Documentation/devicetree/bindings/mfd/syscon.yaml
>+++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
>@@ -64,12 +64,6 @@ properties:
>               - rockchip,rk3568-qos
>               - rockchip,rk3588-qos
>               - rockchip,rv1126-qos
>-              - samsung,exynos3-sysreg
>-              - samsung,exynos4-sysreg
>-              - samsung,exynos5-sysreg
>-              - samsung,exynos5433-sysreg
>-              - samsung,exynos850-sysreg
>-              - samsung,exynosautov9-sysreg
>
>           - const: syscon
>
>diff --git
>a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-
>sysreg.yaml
>b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-
>sysreg.yaml
>new file mode 100644
>index 000000000000..68064a5e339c
>--- /dev/null
>+++ b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-
>sysre
>+++ g.yaml
>@@ -0,0 +1,39 @@
>+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause %YAML 1.2
>+---
>+$id:
>+https://protect2.fireeye.com/v1/url?k=66a4ea1d-393fd378-66a56152-
>000bab
>+ff32e3-46dd8d7834263379&q=1&e=0e7cbbb5-e02f-4452-b6ad-
>5f17f37da091&u=ht
>+tp%3A%2F%2Fdevicetree.org%2Fschemas%2Fsoc%2Fsamsung%2Fsamsung
>%2Cexynos-
>+sysreg.yaml%23
>+$schema:
>+https://protect2.fireeye.com/v1/url?k=0bf71500-546c2c65-0bf69e4f-000bab
>+ff32e3-2ad7163b19d3c132&q=1&e=0e7cbbb5-e02f-4452-b6ad-
>5f17f37da091&u=ht
>+tp%3A%2F%2Fdevicetree.org%2Fmeta-schemas%2Fcore.yaml%23
>+
>+title: Samsung Exynos SoC series System Registers (SYSREG)
>+
>+maintainers:
>+  - Krzysztof Kozlowski <krzk@kernel.org>
>+
>+properties:
>+  compatible:
>+    oneOf:
>+      - items:
>+          - enum:
>+              - samsung,exynos3-sysreg
>+              - samsung,exynos4-sysreg
>+              - samsung,exynos5-sysreg
>+              - samsung,exynos5433-sysreg
>+              - samsung,exynos850-sysreg
>+              - samsung,exynosautov9-sysreg
>+          - const: syscon
>+
>+  reg:
>+    maxItems: 1
>+
>+required:
>+  - compatible
>+  - reg
>+
>+additionalProperties: false
>+
>+examples:
>+  - |
>+    system-controller@10010000 {
>+        compatible = "samsung,exynos4-sysreg", "syscon";
>+        reg = <0x10010000 0x400>;
>+    };
>--
>2.34.1
Krzysztof Kozlowski Nov. 26, 2022, 1:07 p.m. UTC | #5 
On 25/11/2022 15:32, Sriranjani P wrote:
> 
> 
>> -----Original Message-----
>> From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@linaro.org]
>> Sent: 25 November 2022 16:52
>> To: Lee Jones <lee@kernel.org>; Rob Herring <robh+dt@kernel.org>;
> Krzysztof
>> Kozlowski <krzysztof.kozlowski+dt@linaro.org>; Alim Akhtar
>> <alim.akhtar@samsung.com>; devicetree@vger.kernel.org; linux-
>> kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> linux-samsung-
>> soc@vger.kernel.org
>> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>; Sriranjani P
>> <sriranjani.p@samsung.com>; Chanho Park <chanho61.park@samsung.com>;
>> Sam Protsenko <semen.protsenko@linaro.org>
>> Subject: [PATCH 2/4] dt-bindings: soc: samsung: exynos-sysreg: split from
>> syscon
>>
>> Split Samsung Exynos SoC SYSREG bindings to own file to narrow the
> bindings
>> and do not allow other parts of syscon.yaml.  This allows further
> customization
>> of Samsung SoC bindings.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>
>> ---
>>
>> Cc: Sriranjani P <sriranjani.p@samsung.com>
>> Cc: Chanho Park <chanho61.park@samsung.com>
>> Cc: Sam Protsenko <semen.protsenko@linaro.org>
>> ---
> 
> We agree for add separate YAML for  Samsung Exynos and hence I think we can 
> go ahead and add  separate yaml for Tesla FSD.
> Reviewed-by: Sriranjani P <sriranjani.p@samsung.com>

Tesla FSD should go to the same file. No need for another binding for
same design...

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml
index 1b01bd010431..b73ba1ea08f7 100644
--- a/Documentation/devicetree/bindings/mfd/syscon.yaml
+++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
@@ -64,12 +64,6 @@  properties:
               - rockchip,rk3568-qos
               - rockchip,rk3588-qos
               - rockchip,rv1126-qos
-              - samsung,exynos3-sysreg
-              - samsung,exynos4-sysreg
-              - samsung,exynos5-sysreg
-              - samsung,exynos5433-sysreg
-              - samsung,exynos850-sysreg
-              - samsung,exynosautov9-sysreg
 
           - const: syscon
 
diff --git a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
new file mode 100644
index 000000000000..68064a5e339c
--- /dev/null
+++ b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
@@ -0,0 +1,39 @@ 
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/soc/samsung/samsung,exynos-sysreg.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Samsung Exynos SoC series System Registers (SYSREG)
+
+maintainers:
+  - Krzysztof Kozlowski <krzk@kernel.org>
+
+properties:
+  compatible:
+    oneOf:
+      - items:
+          - enum:
+              - samsung,exynos3-sysreg
+              - samsung,exynos4-sysreg
+              - samsung,exynos5-sysreg
+              - samsung,exynos5433-sysreg
+              - samsung,exynos850-sysreg
+              - samsung,exynosautov9-sysreg
+          - const: syscon
+
+  reg:
+    maxItems: 1
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+    system-controller@10010000 {
+        compatible = "samsung,exynos4-sysreg", "syscon";
+        reg = <0x10010000 0x400>;
+    };