| Message ID | 20221125050807.1857479-2-shravan.chippa@microchip.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | media: i2c: imx334: support lower bandwidth mode | expand |
Hi Shravan, On Fri, Nov 25, 2022 at 10:38:02AM +0530, shravan kumar wrote: > From: Shravan Chippa <shravan.chippa@microchip.com> > > -imx334 sensor is configured to 1782Mbps/lane for 3840x2160@60. > -But in device tree bindings exapmple we are passing 891Mbps/lane > so modified to 1782Mbps > > Signed-off-by: Shravan Chippa <shravan.chippa@microchip.com> > --- > Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml > index f5055b9db693..ea3c93f97d65 100644 > --- a/Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml > +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml > @@ -82,7 +82,7 @@ examples: > imx334: endpoint { > remote-endpoint = <&cam>; > data-lanes = <1 2 3 4>; > - link-frequencies = /bits/ 64 <891000000>; > + link-frequencies = /bits/ 64 <1782000000>; My understanding is that the original frequency is correct --- 594 MHz pixel clock, 12 bpp, four lanes (and DDR). > }; > }; > };
On Fri, Nov 25, 2022 at 9:27 PM Sakari Ailus <sakari.ailus@iki.fi> wrote: > > Hi Shravan, > > On Fri, Nov 25, 2022 at 10:38:02AM +0530, shravan kumar wrote: > > From: Shravan Chippa <shravan.chippa@microchip.com> > > > > -imx334 sensor is configured to 1782Mbps/lane for 3840x2160@60. > > -But in device tree bindings exapmple we are passing 891Mbps/lane > > so modified to 1782Mbps > > > > Signed-off-by: Shravan Chippa <shravan.chippa@microchip.com> > > --- > > Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml > > index f5055b9db693..ea3c93f97d65 100644 > > --- a/Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml > > +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml > > @@ -82,7 +82,7 @@ examples: > > imx334: endpoint { > > remote-endpoint = <&cam>; > > data-lanes = <1 2 3 4>; > > - link-frequencies = /bits/ 64 <891000000>; > > + link-frequencies = /bits/ 64 <1782000000>; > > My understanding is that the original frequency is correct --- 594 MHz > pixel clock, 12 bpp, four lanes (and DDR). As per my understanding, other than these three parameters there is one more link frequency (communication frequency from imx334 sensor to MIPI CSI2 controller). thanks, Thanks, Shravan. > > > }; > > }; > > }; > > -- > Kind regards, > > Sakari Ailus
On Sat, Nov 26, 2022 at 04:21:57PM +0530, shravan kumar wrote: > On Fri, Nov 25, 2022 at 9:27 PM Sakari Ailus <sakari.ailus@iki.fi> wrote: > > > > Hi Shravan, > > > > On Fri, Nov 25, 2022 at 10:38:02AM +0530, shravan kumar wrote: > > > From: Shravan Chippa <shravan.chippa@microchip.com> > > > > > > -imx334 sensor is configured to 1782Mbps/lane for 3840x2160@60. > > > -But in device tree bindings exapmple we are passing 891Mbps/lane > > > so modified to 1782Mbps > > > > > > Signed-off-by: Shravan Chippa <shravan.chippa@microchip.com> > > > --- > > > Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml > > > index f5055b9db693..ea3c93f97d65 100644 > > > --- a/Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml > > > +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml > > > @@ -82,7 +82,7 @@ examples: > > > imx334: endpoint { > > > remote-endpoint = <&cam>; > > > data-lanes = <1 2 3 4>; > > > - link-frequencies = /bits/ 64 <891000000>; > > > + link-frequencies = /bits/ 64 <1782000000>; > > > > My understanding is that the original frequency is correct --- 594 MHz > > pixel clock, 12 bpp, four lanes (and DDR). > > As per my understanding, other than these three parameters there is > one more link frequency (communication frequency from imx334 sensor to > MIPI CSI2 controller). > thanks, Feel free to add additional frequencies later on. But this patch appears to be just wrong.
diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml index f5055b9db693..ea3c93f97d65 100644 --- a/Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml @@ -82,7 +82,7 @@ examples: imx334: endpoint { remote-endpoint = <&cam>; data-lanes = <1 2 3 4>; - link-frequencies = /bits/ 64 <891000000>; + link-frequencies = /bits/ 64 <1782000000>; }; }; };