| Message ID | 20221128024407.224393-9-doug@schmorgal.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | mmc: sdhci-pxav2: Add support for PXA168 | expand |
On 28/11/2022 03:44, Doug Brown wrote: > Add a compatible for the pxav1 controller in the PXA168, along with > optional pinctrl properties to use for an errata workaround. > > Signed-off-by: Doug Brown <doug@schmorgal.com> > --- > .../devicetree/bindings/mmc/sdhci-pxa.yaml | 22 ++++++++++++++++++- > 1 file changed, 21 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/mmc/sdhci-pxa.yaml b/Documentation/devicetree/bindings/mmc/sdhci-pxa.yaml > index 1c87f4218e18..e3fb34853921 100644 > --- a/Documentation/devicetree/bindings/mmc/sdhci-pxa.yaml > +++ b/Documentation/devicetree/bindings/mmc/sdhci-pxa.yaml > @@ -4,7 +4,7 @@ > $id: http://devicetree.org/schemas/mmc/sdhci-pxa.yaml# > $schema: http://devicetree.org/meta-schemas/core.yaml# > > -title: Marvell PXA SDHCI v2/v3 bindings > +title: Marvell PXA SDHCI v1/v2/v3 bindings > > maintainers: > - Ulf Hansson <ulf.hansson@linaro.org> > @@ -34,6 +34,7 @@ allOf: > properties: > compatible: > enum: > + - mrvl,pxav1-mmc > - mrvl,pxav2-mmc > - mrvl,pxav3-mmc > - marvell,armada-380-sdhci > @@ -61,6 +62,25 @@ properties: > - const: io > - const: core > > + pinctrl-names: > + description: > + Optional for supporting PXA168 SDIO IRQ errata to switch CMD pin between SDIO CMD and > + GPIO mode. > + minItems: 2 No need for minItems. > + items: > + - const: default > + - const: state_cmd_gpio > + > + pinctrl-0: > + description: > + should contain default pinctrl. Start with capital letter if this is a sentence with full stop. It's anyway looking different then the rest of the file, right? > + maxItems: 1 Why maxItems: 1? What if one wants to add here more entries? Drop maxItems. > + > + pinctrl-1: > + description: > + should switch CMD pin to GPIO mode as a high output. > + maxItems: 1 Ditto > + > mrvl,clk-delay-cycles: > description: Specify a number of cycles to delay for tuning. > $ref: /schemas/types.yaml#/definitions/uint32 Best regards, Krzysztof
On Sun, 27 Nov 2022 18:44:07 -0800, Doug Brown wrote: > Add a compatible for the pxav1 controller in the PXA168, along with > optional pinctrl properties to use for an errata workaround. > > Signed-off-by: Doug Brown <doug@schmorgal.com> > --- > .../devicetree/bindings/mmc/sdhci-pxa.yaml | 22 ++++++++++++++++++- > 1 file changed, 21 insertions(+), 1 deletion(-) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mmc/sdhci-pxa.yaml: properties:pinctrl-names: 'oneOf' conditional failed, one must be fixed: [{'const': 'default'}, {'const': 'state_cmd_gpio'}] is too long [{'const': 'default'}, {'const': 'state_cmd_gpio'}] is too short False schema does not allow 2 1 was expected hint: "minItems" is only needed if less than the "items" list length from schema $id: http://devicetree.org/meta-schemas/items.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20221128024407.224393-9-doug@schmorgal.com This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command.
Hi Krzysztof and Rob, On 11/28/2022 12:58 AM, Krzysztof Kozlowski wrote: > No need for minItems. > > Start with capital letter if this is a sentence with full stop. It's > anyway looking different then the rest of the file, right? > > Why maxItems: 1? What if one wants to add here more entries? Drop maxItems. > > Ditto Thanks for the fast review. Will fix this all in V2 after I receive feedback on the other patches. I was trying to follow the pattern from another similar schema and didn't fully understand. On 11/28/2022 4:20 AM, Rob Herring wrote: > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13) Well this is embarrassing! I forgot to run dt_binding_check. Sorry about that. Doug
diff --git a/Documentation/devicetree/bindings/mmc/sdhci-pxa.yaml b/Documentation/devicetree/bindings/mmc/sdhci-pxa.yaml index 1c87f4218e18..e3fb34853921 100644 --- a/Documentation/devicetree/bindings/mmc/sdhci-pxa.yaml +++ b/Documentation/devicetree/bindings/mmc/sdhci-pxa.yaml @@ -4,7 +4,7 @@ $id: http://devicetree.org/schemas/mmc/sdhci-pxa.yaml# $schema: http://devicetree.org/meta-schemas/core.yaml# -title: Marvell PXA SDHCI v2/v3 bindings +title: Marvell PXA SDHCI v1/v2/v3 bindings maintainers: - Ulf Hansson <ulf.hansson@linaro.org> @@ -34,6 +34,7 @@ allOf: properties: compatible: enum: + - mrvl,pxav1-mmc - mrvl,pxav2-mmc - mrvl,pxav3-mmc - marvell,armada-380-sdhci @@ -61,6 +62,25 @@ properties: - const: io - const: core + pinctrl-names: + description: + Optional for supporting PXA168 SDIO IRQ errata to switch CMD pin between SDIO CMD and + GPIO mode. + minItems: 2 + items: + - const: default + - const: state_cmd_gpio + + pinctrl-0: + description: + should contain default pinctrl. + maxItems: 1 + + pinctrl-1: + description: + should switch CMD pin to GPIO mode as a high output. + maxItems: 1 + mrvl,clk-delay-cycles: description: Specify a number of cycles to delay for tuning. $ref: /schemas/types.yaml#/definitions/uint32
Add a compatible for the pxav1 controller in the PXA168, along with optional pinctrl properties to use for an errata workaround. Signed-off-by: Doug Brown <doug@schmorgal.com> --- .../devicetree/bindings/mmc/sdhci-pxa.yaml | 22 ++++++++++++++++++- 1 file changed, 21 insertions(+), 1 deletion(-)