mbox series

[bpf,v2,0/4] bpf, sockmap: Fix some issues with using apply_bytes

Message ID 1669634685-1717-1-git-send-email-yangpc@wangsu.com (mailing list archive)
Headers show
Series bpf, sockmap: Fix some issues with using apply_bytes | expand

Message

Pengcheng Yang Nov. 28, 2022, 11:24 a.m. UTC
Patch 1~3 fixes three issues with using apply_bytes when redirecting.
Patch 4 adds ingress tests for txmsg with apply_bytes in selftests.

---
Changes in v2:
*Patch 2: Clear psock->flags explicitly before releasing the sock lock

Pengcheng Yang (4):
  bpf, sockmap: Fix repeated calls to sock_put() when msg has more_data
  bpf, sockmap: Fix missing BPF_F_INGRESS flag when using apply_bytes
  bpf, sockmap: Fix data loss caused by using apply_bytes on ingress
    redirect
  selftests/bpf: Add ingress tests for txmsg with apply_bytes

 include/linux/skmsg.h                      |  1 +
 net/core/skmsg.c                           |  1 +
 net/ipv4/tcp_bpf.c                         | 10 ++++++++--
 net/tls/tls_sw.c                           |  1 +
 tools/testing/selftests/bpf/test_sockmap.c | 18 ++++++++++++++++++
 5 files changed, 29 insertions(+), 2 deletions(-)

Comments

John Fastabend Nov. 28, 2022, 6:14 p.m. UTC | #1
Pengcheng Yang wrote:
> Patch 1~3 fixes three issues with using apply_bytes when redirecting.
> Patch 4 adds ingress tests for txmsg with apply_bytes in selftests.
> 
> ---
> Changes in v2:
> *Patch 2: Clear psock->flags explicitly before releasing the sock lock

Yeah I think its slightly nicer Thanks for fixing this.

For the series.

Acked-by: John Fastabend <john.fastabend@gmail.com>