diff mbox series

mips: ralink: mt7621: fix phy-mode of external phy on GB-PC2

Message ID 20221128213238.3959-1-arinc.unal@arinc9.com (mailing list archive)
State Accepted
Commit 82e918f967ae580e6af79085f906794ca156a08b
Headers show
Series mips: ralink: mt7621: fix phy-mode of external phy on GB-PC2 | expand

Commit Message

Arınç ÜNAL Nov. 28, 2022, 9:32 p.m. UTC 
The phy-mode property must be defined on the MAC instead of the PHY. Define
phy-mode under gmac1 which the external phy is connected to.

Tested-by: Petr Louda <petr.louda@outlook.cz>
Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>
---
 arch/mips/boot/dts/ralink/mt7621-gnubee-gb-pc2.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Sergio Paracuellos Nov. 29, 2022, 4:34 a.m. UTC | #1 
On Mon, Nov 28, 2022 at 10:33 PM Arınç ÜNAL <arinc.unal@arinc9.com> wrote:
>
> The phy-mode property must be defined on the MAC instead of the PHY. Define
> phy-mode under gmac1 which the external phy is connected to.
>
> Tested-by: Petr Louda <petr.louda@outlook.cz>
> Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>
> ---
>  arch/mips/boot/dts/ralink/mt7621-gnubee-gb-pc2.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Acked-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>

Thanks,
    Sergio Paracuellos
Thomas Bogendoerfer Dec. 1, 2022, 10:50 a.m. UTC | #2 
On Tue, Nov 29, 2022 at 12:32:38AM +0300, Arınç ÜNAL wrote:
> The phy-mode property must be defined on the MAC instead of the PHY. Define
> phy-mode under gmac1 which the external phy is connected to.
> 
> Tested-by: Petr Louda <petr.louda@outlook.cz>
> Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>
> ---
>  arch/mips/boot/dts/ralink/mt7621-gnubee-gb-pc2.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

applied to mips-next.

Thomas.
Arınç ÜNAL Jan. 15, 2023, 8:22 a.m. UTC | #3 
On 1.12.2022 13:50, Thomas Bogendoerfer wrote:
> On Tue, Nov 29, 2022 at 12:32:38AM +0300, Arınç ÜNAL wrote:
>> The phy-mode property must be defined on the MAC instead of the PHY. Define
>> phy-mode under gmac1 which the external phy is connected to.
>>
>> Tested-by: Petr Louda <petr.louda@outlook.cz>
>> Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>
>> ---
>>   arch/mips/boot/dts/ralink/mt7621-gnubee-gb-pc2.dts | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> applied to mips-next.

I just realised I forgot to add "dts:" to the patch subject. Would that 
be a problem?

Arınç
diff mbox series

Patch

diff --git a/arch/mips/boot/dts/ralink/mt7621-gnubee-gb-pc2.dts b/arch/mips/boot/dts/ralink/mt7621-gnubee-gb-pc2.dts
index 7515555388ae..e31417569e09 100644
--- a/arch/mips/boot/dts/ralink/mt7621-gnubee-gb-pc2.dts
+++ b/arch/mips/boot/dts/ralink/mt7621-gnubee-gb-pc2.dts
@@ -113,13 +113,13 @@  &pcie {
 
 &gmac1 {
 	status = "okay";
+	phy-mode = "rgmii-rxid";
 	phy-handle = <&ethphy5>;
 };
 
 &mdio {
 	ethphy5: ethernet-phy@5 {
 		reg = <5>;
-		phy-mode = "rgmii-rxid";
 	};
 };