| Message ID | 20221127132448.4034-2-jszhang@kernel.org (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | riscv: add Bouffalolab bl808 support | expand |
| Context | Check | Description |
|---|---|---|
| conchuod/tree_selection | fail | Guessing tree name failed |
On 11/27/22 07:24, Jisheng Zhang wrote: > Add bindings doc for Bouffalolab UART Driver > > Signed-off-by: Jisheng Zhang <jszhang@kernel.org> > --- > .../bindings/serial/bouffalolab,uart.yaml | 47 +++++++++++++++++++ > 1 file changed, 47 insertions(+) > create mode 100644 Documentation/devicetree/bindings/serial/bouffalolab,uart.yaml > > diff --git a/Documentation/devicetree/bindings/serial/bouffalolab,uart.yaml b/Documentation/devicetree/bindings/serial/bouffalolab,uart.yaml > new file mode 100644 > index 000000000000..a8293444ca31 > --- /dev/null > +++ b/Documentation/devicetree/bindings/serial/bouffalolab,uart.yaml > @@ -0,0 +1,47 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +# Copyright (C) 2022 Jisheng Zhang <jszhang@kernel.org> > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/serial/bouffalolab,uart.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Bouffalolab UART Controller > + > +maintainers: > + - Jisheng Zhang <jszhang@kernel.org> > + > +allOf: > + - $ref: serial.yaml# > + > +properties: > + compatible: > + const: bouffalolab,bl808-uart > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + maxItems: 1 There is also a reset control for this peripheral (in the GLB registers at GLB_SWRST_S1A0). And since you set additionalProperties, I believe you need to add the DMA channel properties here as well. Regards, Samuel > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/interrupt-controller/irq.h> > + > + uart0: serial@30002000 { > + compatible = "bouffalolab,bl808-uart"; > + reg = <0x30002000 0x1000>; > + interrupts = <53 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&xtal>; > + }; > +...
On 27/11/2022 14:24, Jisheng Zhang wrote: > Add bindings doc for Bouffalolab UART Driver > > Signed-off-by: Jisheng Zhang <jszhang@kernel.org> > --- > .../bindings/serial/bouffalolab,uart.yaml | 47 +++++++++++++++++++ > 1 file changed, 47 insertions(+) > create mode 100644 Documentation/devicetree/bindings/serial/bouffalolab,uart.yaml > > diff --git a/Documentation/devicetree/bindings/serial/bouffalolab,uart.yaml b/Documentation/devicetree/bindings/serial/bouffalolab,uart.yaml > new file mode 100644 > index 000000000000..a8293444ca31 > --- /dev/null > +++ b/Documentation/devicetree/bindings/serial/bouffalolab,uart.yaml Name the file matching compatible, so bouffalolab,bl808-uart.yaml > @@ -0,0 +1,47 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +# Copyright (C) 2022 Jisheng Zhang <jszhang@kernel.org> > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/serial/bouffalolab,uart.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Bouffalolab UART Controller > + > +maintainers: > + - Jisheng Zhang <jszhang@kernel.org> > + > +allOf: > + - $ref: serial.yaml# > + > +properties: > + compatible: > + const: bouffalolab,bl808-uart Rob's comments from v1 are applicable. Either fix or respond to them. > + > + reg: > + maxItems: 1 > + Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/serial/bouffalolab,uart.yaml b/Documentation/devicetree/bindings/serial/bouffalolab,uart.yaml new file mode 100644 index 000000000000..a8293444ca31 --- /dev/null +++ b/Documentation/devicetree/bindings/serial/bouffalolab,uart.yaml @@ -0,0 +1,47 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +# Copyright (C) 2022 Jisheng Zhang <jszhang@kernel.org> +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/serial/bouffalolab,uart.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Bouffalolab UART Controller + +maintainers: + - Jisheng Zhang <jszhang@kernel.org> + +allOf: + - $ref: serial.yaml# + +properties: + compatible: + const: bouffalolab,bl808-uart + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + clocks: + maxItems: 1 + +required: + - compatible + - reg + - interrupts + - clocks + +additionalProperties: false + +examples: + - | + #include <dt-bindings/interrupt-controller/irq.h> + + uart0: serial@30002000 { + compatible = "bouffalolab,bl808-uart"; + reg = <0x30002000 0x1000>; + interrupts = <53 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&xtal>; + }; +...
Add bindings doc for Bouffalolab UART Driver Signed-off-by: Jisheng Zhang <jszhang@kernel.org> --- .../bindings/serial/bouffalolab,uart.yaml | 47 +++++++++++++++++++ 1 file changed, 47 insertions(+) create mode 100644 Documentation/devicetree/bindings/serial/bouffalolab,uart.yaml