| Message ID | 20221128173744.833018-2-luca@z3ntu.xyz (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 29dcf3c1a8159acdf56905c377a214381eda5a24 |
| Headers | show |
| Series | [RESEND,1/2] dt-bindings: nfc: nxp,nci: Document NQ310 compatible | expand |
On 28.11.2022 18:37, Luca Weiss wrote: > Configure the node for the NQ310 chip found on this device, which is > compatible with generic nxp-nci-i2c driver. > > Signed-off-by: Luca Weiss <luca@z3ntu.xyz> > --- > RESEND to fix Cc > > arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts b/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts > index 2920504461d3..fde93cbcd180 100644 > --- a/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts > +++ b/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts > @@ -63,6 +63,21 @@ touchscreen@48 { > }; > }; > > +&i2c_5 { > + status = "okay"; > + > + nfc@28 { > + compatible = "nxp,nq310", "nxp,nxp-nci-i2c"; Unless there was some binding change (that was not emailed to me with this email, I only got 2/2), only "nxp,nxp-nci-i2c" and "nxp,pn547", "nxp,nxp-nci-i2c" are allowed. The node looks good though. Konrad > + reg = <0x28>; > + > + interrupt-parent = <&tlmm>; > + interrupts = <17 IRQ_TYPE_LEVEL_HIGH>; > + > + enable-gpios = <&tlmm 16 GPIO_ACTIVE_HIGH>; > + firmware-gpios = <&tlmm 62 GPIO_ACTIVE_HIGH>; > + }; > +}; > + > &pm8953_resin { > status = "okay"; > linux,code = <KEY_VOLUMEDOWN>;
On Dienstag, 29. November 2022 14:29:36 CET Konrad Dybcio wrote: > On 28.11.2022 18:37, Luca Weiss wrote: > > Configure the node for the NQ310 chip found on this device, which is > > compatible with generic nxp-nci-i2c driver. > > > > Signed-off-by: Luca Weiss <luca@z3ntu.xyz> > > --- > > RESEND to fix Cc > > > > arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts | 15 +++++++++++++++ > > 1 file changed, 15 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts > > b/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts index > > 2920504461d3..fde93cbcd180 100644 > > --- a/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts > > +++ b/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts > > @@ -63,6 +63,21 @@ touchscreen@48 { > > > > }; > > > > }; > > > > +&i2c_5 { > > + status = "okay"; > > + > > + nfc@28 { > > + compatible = "nxp,nq310", "nxp,nxp-nci-i2c"; > > Unless there was some binding change (that was not emailed to me with > this email, I only got 2/2), only "nxp,nxp-nci-i2c" and > "nxp,pn547", "nxp,nxp-nci-i2c" are allowed. Yes, I've added the double compatible to the yaml. https://lore.kernel.org/lkml/20221128173744.833018-1-luca@z3ntu.xyz/ I'll try to work on my Cc-script setup, currently it adds the output of get_maintainers.pl for each patch (and adds all for the cover letter), which is based on some script I found a while ago online. Is there like a recommended way to put all people in Cc for a series, I'm not aware of anything at least... Perhaps I'll look into b4 for sending patches, that seems to have some goodies there. Regards Luca > > The node looks good though. > > Konrad > > > + reg = <0x28>; > > + > > + interrupt-parent = <&tlmm>; > > + interrupts = <17 IRQ_TYPE_LEVEL_HIGH>; > > + > > + enable-gpios = <&tlmm 16 GPIO_ACTIVE_HIGH>; > > + firmware-gpios = <&tlmm 62 GPIO_ACTIVE_HIGH>; > > + }; > > +}; > > + > > > > &pm8953_resin { > > > > status = "okay"; > > linux,code = <KEY_VOLUMEDOWN>;
On 29.11.2022 19:31, Luca Weiss wrote: > On Dienstag, 29. November 2022 14:29:36 CET Konrad Dybcio wrote: >> On 28.11.2022 18:37, Luca Weiss wrote: >>> Configure the node for the NQ310 chip found on this device, which is >>> compatible with generic nxp-nci-i2c driver. >>> >>> Signed-off-by: Luca Weiss <luca@z3ntu.xyz> >>> --- >>> RESEND to fix Cc >>> >>> arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts | 15 +++++++++++++++ >>> 1 file changed, 15 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts >>> b/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts index >>> 2920504461d3..fde93cbcd180 100644 >>> --- a/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts >>> +++ b/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts >>> @@ -63,6 +63,21 @@ touchscreen@48 { >>> >>> }; >>> >>> }; >>> >>> +&i2c_5 { >>> + status = "okay"; >>> + >>> + nfc@28 { >>> + compatible = "nxp,nq310", "nxp,nxp-nci-i2c"; >> >> Unless there was some binding change (that was not emailed to me with >> this email, I only got 2/2), only "nxp,nxp-nci-i2c" and >> "nxp,pn547", "nxp,nxp-nci-i2c" are allowed. > > Yes, I've added the double compatible to the yaml. > https://lore.kernel.org/lkml/20221128173744.833018-1-luca@z3ntu.xyz/ Ok, this looks good then. Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> > > I'll try to work on my Cc-script setup, currently it adds the output of > get_maintainers.pl for each patch (and adds all for the cover letter), which > is based on some script I found a while ago online. > > Is there like a recommended way to put all people in Cc for a series, I'm not > aware of anything at least... > > Perhaps I'll look into b4 for sending patches, that seems to have some goodies > there. Check out this reply from Rob Herring here https://lore.kernel.org/lkml/CAL_JsqLubWBr2W3xZPsuPLOGav7CFgBdH=aCfT22F_m0_cx3cQ@mail.gmail.com/ Konrad > > Regards > Luca > >> >> The node looks good though. >> >> Konrad >> >>> + reg = <0x28>; >>> + >>> + interrupt-parent = <&tlmm>; >>> + interrupts = <17 IRQ_TYPE_LEVEL_HIGH>; >>> + >>> + enable-gpios = <&tlmm 16 GPIO_ACTIVE_HIGH>; >>> + firmware-gpios = <&tlmm 62 GPIO_ACTIVE_HIGH>; >>> + }; >>> +}; >>> + >>> >>> &pm8953_resin { >>> >>> status = "okay"; >>> linux,code = <KEY_VOLUMEDOWN>; > > > >
diff --git a/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts b/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts index 2920504461d3..fde93cbcd180 100644 --- a/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts +++ b/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts @@ -63,6 +63,21 @@ touchscreen@48 { }; }; +&i2c_5 { + status = "okay"; + + nfc@28 { + compatible = "nxp,nq310", "nxp,nxp-nci-i2c"; + reg = <0x28>; + + interrupt-parent = <&tlmm>; + interrupts = <17 IRQ_TYPE_LEVEL_HIGH>; + + enable-gpios = <&tlmm 16 GPIO_ACTIVE_HIGH>; + firmware-gpios = <&tlmm 62 GPIO_ACTIVE_HIGH>; + }; +}; + &pm8953_resin { status = "okay"; linux,code = <KEY_VOLUMEDOWN>;
Configure the node for the NQ310 chip found on this device, which is compatible with generic nxp-nci-i2c driver. Signed-off-by: Luca Weiss <luca@z3ntu.xyz> --- RESEND to fix Cc arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts | 15 +++++++++++++++ 1 file changed, 15 insertions(+)