diff mbox series

[net] selftests: rtnetlink: correct xfrm policy rule in kci_test_ipsec_offload

Message ID 20221201082246.14131-1-shaozhengchao@huawei.com (mailing list archive)
State Accepted
Commit 85a0506c073332a3057f5a9635fa0d4db5a8e03b
Delegated to: Netdev Maintainers
Headers show
Series [net] selftests: rtnetlink: correct xfrm policy rule in kci_test_ipsec_offload | expand

Checks

Context Check Description
netdev/tree_selection success Clearly marked for net
netdev/fixes_present success Fixes tag present in non-next series
netdev/subject_prefix success Link
netdev/cover_letter success Single patches do not need cover letters
netdev/patch_count success Link
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 0 this patch: 0
netdev/cc_maintainers success CCed 8 of 8 maintainers
netdev/build_clang success Errors and warnings before: 0 this patch: 0
netdev/module_param success Was 0 now: 0
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/check_selftest success net selftest script(s) already in Makefile
netdev/verify_fixes success Fixes tag looks correct
netdev/build_allmodconfig_warn success Errors and warnings before: 0 this patch: 0
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 8 lines checked
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0

Commit Message

shaozhengchao Dec. 1, 2022, 8:22 a.m. UTC
When testing in kci_test_ipsec_offload, srcip is configured as $dstip,
it should add xfrm policy rule in instead of out.
The test result of this patch is as follows:
PASS: ipsec_offload

Fixes: 2766a11161cc ("selftests: rtnetlink: add ipsec offload API test")
Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
---
 tools/testing/selftests/net/rtnetlink.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Hangbin Liu Dec. 2, 2022, 2:06 a.m. UTC | #1
On Thu, Dec 01, 2022 at 04:22:46PM +0800, Zhengchao Shao wrote:
> When testing in kci_test_ipsec_offload, srcip is configured as $dstip,
> it should add xfrm policy rule in instead of out.
> The test result of this patch is as follows:
> PASS: ipsec_offload
> 
> Fixes: 2766a11161cc ("selftests: rtnetlink: add ipsec offload API test")
> Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
> ---
>  tools/testing/selftests/net/rtnetlink.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/net/rtnetlink.sh b/tools/testing/selftests/net/rtnetlink.sh
> index 0900c5438fbb..275491be3da2 100755
> --- a/tools/testing/selftests/net/rtnetlink.sh
> +++ b/tools/testing/selftests/net/rtnetlink.sh
> @@ -782,7 +782,7 @@ kci_test_ipsec_offload()
>  	    tmpl proto esp src $srcip dst $dstip spi 9 \
>  	    mode transport reqid 42
>  	check_err $?
> -	ip x p add dir out src $dstip/24 dst $srcip/24 \
> +	ip x p add dir in src $dstip/24 dst $srcip/24 \
>  	    tmpl proto esp src $dstip dst $srcip spi 9 \
>  	    mode transport reqid 42
>  	check_err $?
> -- 
> 2.34.1
>

Acked-by: Hangbin Liu <liuhangbin@gmail.com>
patchwork-bot+netdevbpf@kernel.org Dec. 3, 2022, 5:30 a.m. UTC | #2
Hello:

This patch was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@kernel.org>:

On Thu, 1 Dec 2022 16:22:46 +0800 you wrote:
> When testing in kci_test_ipsec_offload, srcip is configured as $dstip,
> it should add xfrm policy rule in instead of out.
> The test result of this patch is as follows:
> PASS: ipsec_offload
> 
> Fixes: 2766a11161cc ("selftests: rtnetlink: add ipsec offload API test")
> Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
> 
> [...]

Here is the summary with links:
  - [net] selftests: rtnetlink: correct xfrm policy rule in kci_test_ipsec_offload
    https://git.kernel.org/netdev/net/c/85a0506c0733

You are awesome, thank you!
diff mbox series

Patch

diff --git a/tools/testing/selftests/net/rtnetlink.sh b/tools/testing/selftests/net/rtnetlink.sh
index 0900c5438fbb..275491be3da2 100755
--- a/tools/testing/selftests/net/rtnetlink.sh
+++ b/tools/testing/selftests/net/rtnetlink.sh
@@ -782,7 +782,7 @@  kci_test_ipsec_offload()
 	    tmpl proto esp src $srcip dst $dstip spi 9 \
 	    mode transport reqid 42
 	check_err $?
-	ip x p add dir out src $dstip/24 dst $srcip/24 \
+	ip x p add dir in src $dstip/24 dst $srcip/24 \
 	    tmpl proto esp src $dstip dst $srcip spi 9 \
 	    mode transport reqid 42
 	check_err $?