| Message ID | 20221202100841.4741-10-ilpo.jarvinen@linux.intel.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | intel-m10-bmc: Split BMC to core and SPI parts & add PMCI+N6000 support | expand |
On Fri, Dec 02, 2022 at 12:08:41PM +0200, Ilpo Järvinen wrote: > "GPL v2" should not be used as MODULE_LICENSE(). "GPL" is enough, see > commit bf7fbeeae6db ("module: Cure the MODULE_LICENSE "GPL" vs. "GPL > v2" bogosity") for more details. And that commit says that leaving "GPL v2" is just fine and dandy and should not be an issue at all. Please do not change the license for no good reason. That commit is NOT a good reason to change it at all. so NAK on this patch, sorry. greg k-h
On Sun, 4 Dec 2022, Greg KH wrote: > On Fri, Dec 02, 2022 at 12:08:41PM +0200, Ilpo Järvinen wrote: > > "GPL v2" should not be used as MODULE_LICENSE(). "GPL" is enough, see > > commit bf7fbeeae6db ("module: Cure the MODULE_LICENSE "GPL" vs. "GPL > > v2" bogosity") for more details. > > And that commit says that leaving "GPL v2" is just fine and dandy and > should not be an issue at all. From reading just it's changelog, it's hard to come into that conclusion (in fact, the opposite reading is very much crafted into many of the wordings in the changelog, e.g., stating that "GPL" is "completely sufficient" and that other ways assume wrongly distinction, etc.). Only after reading now the diff itself, I can see that being the case. > Please do not change the license for no good reason. That commit is NOT > a good reason to change it at all. > > so NAK on this patch, sorry. Okay, I'm certainly fine dropping it :-). The reason why I added this change was checkpatch giving this: WARNING: Prefer "GPL" over "GPL v2" - see commit bf7fbeeae6db ("module: Cure the MODULE_LICENSE "GPL" vs. "GPL v2" bogosity") ...And bf7fbeeae6db's changelog then further reinforced that "GPL" is sufficient. I guess checkpatch wanted to give the warning only for new stuff but since I was moving code around it misdetected the moved bits as new.
diff --git a/drivers/mfd/intel-m10-bmc-core.c b/drivers/mfd/intel-m10-bmc-core.c index 50a4ec758bdb..3b9e866b2bcf 100644 --- a/drivers/mfd/intel-m10-bmc-core.c +++ b/drivers/mfd/intel-m10-bmc-core.c @@ -130,4 +130,4 @@ EXPORT_SYMBOL_GPL(m10bmc_dev_init); MODULE_DESCRIPTION("Intel MAX 10 BMC core MFD driver"); MODULE_AUTHOR("Intel Corporation"); -MODULE_LICENSE("GPL v2"); +MODULE_LICENSE("GPL"); diff --git a/drivers/mfd/intel-m10-bmc-spi.c b/drivers/mfd/intel-m10-bmc-spi.c index e99fe7c43314..d480e09bda25 100644 --- a/drivers/mfd/intel-m10-bmc-spi.c +++ b/drivers/mfd/intel-m10-bmc-spi.c @@ -201,5 +201,5 @@ module_spi_driver(intel_m10bmc_spi_driver); MODULE_DESCRIPTION("Intel MAX 10 BMC SPI bus interface"); MODULE_AUTHOR("Intel Corporation"); -MODULE_LICENSE("GPL v2"); +MODULE_LICENSE("GPL"); MODULE_ALIAS("spi:intel-m10-bmc");
"GPL v2" should not be used as MODULE_LICENSE(). "GPL" is enough, see commit bf7fbeeae6db ("module: Cure the MODULE_LICENSE "GPL" vs. "GPL v2" bogosity") for more details. Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> --- drivers/mfd/intel-m10-bmc-core.c | 2 +- drivers/mfd/intel-m10-bmc-spi.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)