mbox series

[net-next,0/2] net: add and use netdev_sw_irq_coalesce_default_on()

Message ID e4d1cc88-2064-caa0-c786-41f8720869a4@gmail.com (mailing list archive)
Headers show
Series net: add and use netdev_sw_irq_coalesce_default_on() | expand

Message

Heiner Kallweit Nov. 30, 2022, 10:25 p.m. UTC 
There are reports about r8169 not reaching full line speed on certain
systems (e.g. SBC's) with a 2.5Gbps link.
There was a time when hardware interrupt coalescing was enabled per
default, but this was changed due to ASPM-related issues on few systems.

Meanwhile we have sysfs attributes for controlling kind of
"software interrupt coalescing" on the GRO level. However most distros
and users don't know about it. So lets set a conservative default for
both involved parameters. Users can still override the defaults via
sysfs. Don't enable these settings on the fast ethernet chip versions,
they are slow enough.

Even with these conservative setting interrupt load on my 1Gbps test
system reduced significantly.

Follow Jakub's suggestion and put this functionality into net core
so that other MAC drivers can reuse it.

Heiner Kallweit (2):
  net: add netdev_sw_irq_coalesce_default_on()
  r8169: enable GRO software interrupt coalescing per default

 drivers/net/ethernet/realtek/r8169_main.c |  2 ++
 include/linux/netdevice.h                 |  1 +
 net/core/dev.c                            | 16 ++++++++++++++++
 3 files changed, 19 insertions(+)

Comments

patchwork-bot+netdevbpf@kernel.org Dec. 5, 2022, 9:50 a.m. UTC | #1 
Hello:

This series was applied to netdev/net-next.git (master)
by David S. Miller <davem@davemloft.net>:

On Wed, 30 Nov 2022 23:25:23 +0100 you wrote:
> There are reports about r8169 not reaching full line speed on certain
> systems (e.g. SBC's) with a 2.5Gbps link.
> There was a time when hardware interrupt coalescing was enabled per
> default, but this was changed due to ASPM-related issues on few systems.
> 
> Meanwhile we have sysfs attributes for controlling kind of
> "software interrupt coalescing" on the GRO level. However most distros
> and users don't know about it. So lets set a conservative default for
> both involved parameters. Users can still override the defaults via
> sysfs. Don't enable these settings on the fast ethernet chip versions,
> they are slow enough.
> 
> [...]

Here is the summary with links:
  - [net-next,1/2] net: add netdev_sw_irq_coalesce_default_on()
    https://git.kernel.org/netdev/net-next/c/d93607082e98
  - [net-next,2/2] r8169: enable GRO software interrupt coalescing per default
    https://git.kernel.org/netdev/net-next/c/42f66a44d837

You are awesome, thank you!