| Message ID | xmqq1qpd9bys.fsf@gitster.g (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ci: use actions/{upload,download}-artifact@v3 | expand |
Hi Junio, On Tue, 6 Dec 2022, Junio C Hamano wrote: > GitHub CI jobs stopped complaining about use of deprecated actions > that requires deprecated Node.js 12 for some steps, thanks to a > recent work by Oscar Dominguez to upgrade actions/checkout from v2 > (which required Node.js 12) to v3 (which runs with recommended > Node.js 16). > > Upgrade actions/upload-artifact and actions/download-artifact from > v2 to v3, following suit. > > Signed-off-by: Junio C Hamano <gitster@pobox.com> > --- > * The CI run hasn't finished, but it seems to be doing well > https://github.com/git/git/actions/runs/3627513480 > > We are also getting complaint about our use of set-output command > that is deprecated, which will need to be addressed, too. See below. > .github/workflows/main.yml | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml > index 5262823eb1..7a24c6613e 100644 > --- a/.github/workflows/main.yml > +++ b/.github/workflows/main.yml > @@ -94,7 +94,7 @@ jobs: > - name: zip up tracked files > run: git archive -o artifacts/tracked.tar.gz HEAD > - name: upload tracked files and build artifacts > - uses: actions/upload-artifact@v2 > + uses: actions/upload-artifact@v3 > with: > name: windows-artifacts > path: artifacts > @@ -108,7 +108,7 @@ jobs: > nr: [0, 1, 2, 3, 4, 5, 6, 7, 8, 9] > steps: > - name: download tracked files and build artifacts > - uses: actions/download-artifact@v2 > + uses: actions/download-artifact@v3 > with: > name: windows-artifacts > path: ${{github.workspace}} > @@ -125,7 +125,7 @@ jobs: > run: ci/print-test-failures.sh > - name: Upload failed tests' directories > if: failure() && env.FAILED_TEST_ARTIFACTS != '' > - uses: actions/upload-artifact@v2 > + uses: actions/upload-artifact@v3 > with: > name: failed-tests-windows > path: ${{env.FAILED_TEST_ARTIFACTS}} > @@ -177,7 +177,7 @@ jobs: > - name: zip up tracked files > run: git archive -o artifacts/tracked.tar.gz HEAD > - name: upload tracked files and build artifacts > - uses: actions/upload-artifact@v2 > + uses: actions/upload-artifact@v3 > with: > name: vs-artifacts > path: artifacts > @@ -192,7 +192,7 @@ jobs: > steps: > - uses: git-for-windows/setup-git-for-windows-sdk@v1 > - name: download tracked files and build artifacts > - uses: actions/download-artifact@v2 > + uses: actions/download-artifact@v3 > with: > name: vs-artifacts > path: ${{github.workspace}} > @@ -210,7 +210,7 @@ jobs: > run: ci/print-test-failures.sh > - name: Upload failed tests' directories > if: failure() && env.FAILED_TEST_ARTIFACTS != '' > - uses: actions/upload-artifact@v2 > + uses: actions/upload-artifact@v3 This is probably incorrect, but you wouldn't know until something failed in the `linux32` job. I already have a correct fix in https://github.com/git-for-windows/git/pull/4112/commits/b59c1e33fa62029f8d5dca801a8afb480514140c and was only waiting for the patch at the root of this here mail thread to advance further so I could contribute that fix, along with other replacements for deprecated operations. Maybe we can move these changes forward in a more orderly manner, with Oscar's patch advancing to `next` once it is done, and the other patches following after that? Ciao, Johannes > with: > name: failed-tests-windows > path: ${{env.FAILED_TEST_ARTIFACTS}} > @@ -267,7 +267,7 @@ jobs: > run: ci/print-test-failures.sh > - name: Upload failed tests' directories > if: failure() && env.FAILED_TEST_ARTIFACTS != '' > - uses: actions/upload-artifact@v2 > + uses: actions/upload-artifact@v3 > with: > name: failed-tests-${{matrix.vector.jobname}} > path: ${{env.FAILED_TEST_ARTIFACTS}} > -- > 2.39.0-rc2 > > >
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes: >> @@ -210,7 +210,7 @@ jobs: >> run: ci/print-test-failures.sh >> - name: Upload failed tests' directories >> if: failure() && env.FAILED_TEST_ARTIFACTS != '' >> - uses: actions/upload-artifact@v2 >> + uses: actions/upload-artifact@v3 > > This is probably incorrect, but you wouldn't know until something failed > in the `linux32` job. Yeah, that was what I was afraid to see. > I already have a correct fix in > https://github.com/git-for-windows/git/pull/4112/commits/b59c1e33fa62029f8d5dca801a8afb480514140c > and was only waiting for the patch at the root of this here mail thread to > advance further so I could contribute that fix, along with other > replacements for deprecated operations. Wonderful. > Maybe we can move these changes forward in a more orderly manner, with > Oscar's patch advancing to `next` once it is done, and the other patches > following after that? That was what I was planning to do anyway. Thanks.
Junio C Hamano <gitster@pobox.com> writes: >> This is probably incorrect, but you wouldn't know until something failed >> in the `linux32` job. > > Yeah, that was what I was afraid to see. > >> I already have a correct fix in >> https://github.com/git-for-windows/git/pull/4112/commits/b59c1e33fa62029f8d5dca801a8afb480514140c >> and was only waiting for the patch at the root of this here mail thread to >> advance further so I could contribute that fix, along with other >> replacements for deprecated operations. > > Wonderful. > >> Maybe we can move these changes forward in a more orderly manner, with >> Oscar's patch advancing to `next` once it is done, and the other patches >> following after that? > > That was what I was planning to do anyway. Thanks. Eh, I should have made my intention clear. I'll drop this one (as I posted it primarily to fish out those who are interested in and more capable than I am at clearing the deprecation warnings from the CI), will mark Oscar's for 'next' (if I haven't done so already), wait for your updates and queue them on a topic forked from Oscar's (or on the same Oscar's topic), and cook them for the first or the second batch of the next cycle. Thanks.
Hi Junio, On Wed, 7 Dec 2022, Junio C Hamano wrote: > Junio C Hamano <gitster@pobox.com> writes: > > >> This is probably incorrect, but you wouldn't know until something failed > >> in the `linux32` job. > > > > Yeah, that was what I was afraid to see. > > > >> I already have a correct fix in > >> https://github.com/git-for-windows/git/pull/4112/commits/b59c1e33fa62029f8d5dca801a8afb480514140c > >> and was only waiting for the patch at the root of this here mail thread to > >> advance further so I could contribute that fix, along with other > >> replacements for deprecated operations. > > > > Wonderful. > > > >> Maybe we can move these changes forward in a more orderly manner, with > >> Oscar's patch advancing to `next` once it is done, and the other patches > >> following after that? > > > > That was what I was planning to do anyway. Thanks. > > Eh, I should have made my intention clear. I'll drop this one (as I > posted it primarily to fish out those who are interested in and more > capable than I am at clearing the deprecation warnings from the CI), > will mark Oscar's for 'next' (if I haven't done so already), wait for > your updates and queue them on a topic forked from Oscar's (or on > the same Oscar's topic), and cook them for the first or the second > batch of the next cycle. Thank you for clarifying your intention, much appreciated. Ciao, Johannes
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 5262823eb1..7a24c6613e 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -94,7 +94,7 @@ jobs: - name: zip up tracked files run: git archive -o artifacts/tracked.tar.gz HEAD - name: upload tracked files and build artifacts - uses: actions/upload-artifact@v2 + uses: actions/upload-artifact@v3 with: name: windows-artifacts path: artifacts @@ -108,7 +108,7 @@ jobs: nr: [0, 1, 2, 3, 4, 5, 6, 7, 8, 9] steps: - name: download tracked files and build artifacts - uses: actions/download-artifact@v2 + uses: actions/download-artifact@v3 with: name: windows-artifacts path: ${{github.workspace}} @@ -125,7 +125,7 @@ jobs: run: ci/print-test-failures.sh - name: Upload failed tests' directories if: failure() && env.FAILED_TEST_ARTIFACTS != '' - uses: actions/upload-artifact@v2 + uses: actions/upload-artifact@v3 with: name: failed-tests-windows path: ${{env.FAILED_TEST_ARTIFACTS}} @@ -177,7 +177,7 @@ jobs: - name: zip up tracked files run: git archive -o artifacts/tracked.tar.gz HEAD - name: upload tracked files and build artifacts - uses: actions/upload-artifact@v2 + uses: actions/upload-artifact@v3 with: name: vs-artifacts path: artifacts @@ -192,7 +192,7 @@ jobs: steps: - uses: git-for-windows/setup-git-for-windows-sdk@v1 - name: download tracked files and build artifacts - uses: actions/download-artifact@v2 + uses: actions/download-artifact@v3 with: name: vs-artifacts path: ${{github.workspace}} @@ -210,7 +210,7 @@ jobs: run: ci/print-test-failures.sh - name: Upload failed tests' directories if: failure() && env.FAILED_TEST_ARTIFACTS != '' - uses: actions/upload-artifact@v2 + uses: actions/upload-artifact@v3 with: name: failed-tests-windows path: ${{env.FAILED_TEST_ARTIFACTS}} @@ -267,7 +267,7 @@ jobs: run: ci/print-test-failures.sh - name: Upload failed tests' directories if: failure() && env.FAILED_TEST_ARTIFACTS != '' - uses: actions/upload-artifact@v2 + uses: actions/upload-artifact@v3 with: name: failed-tests-${{matrix.vector.jobname}} path: ${{env.FAILED_TEST_ARTIFACTS}}
GitHub CI jobs stopped complaining about use of deprecated actions that requires deprecated Node.js 12 for some steps, thanks to a recent work by Oscar Dominguez to upgrade actions/checkout from v2 (which required Node.js 12) to v3 (which runs with recommended Node.js 16). Upgrade actions/upload-artifact and actions/download-artifact from v2 to v3, following suit. Signed-off-by: Junio C Hamano <gitster@pobox.com> --- * The CI run hasn't finished, but it seems to be doing well https://github.com/git/git/actions/runs/3627513480 We are also getting complaint about our use of set-output command that is deprecated, which will need to be addressed, too. .github/workflows/main.yml | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)