[0/2] can: usb: remove pointers to struct usb_interface in device's priv structures

Message

Vincent Mailhol Dec. 8, 2022, 8:11 a.m. UTC

The gs_can and ucan drivers keep a pointer to struct usb_interface in
their private structure. This is not needed. For gs_can the only use
is to retrieve struct usb_device, which is already available in
gs_usb::udev. For ucan, the field is set but never used.

Remove the struct usb_interface fields and clean up.

Vincent Mailhol (2):
  can: ucan: remove unused ucan_priv::intf
  can: gs_usb: remove gs_can::iface

 drivers/net/can/usb/gs_usb.c | 29 +++++++++--------------------
 drivers/net/can/usb/ucan.c   |  2 --
 2 files changed, 9 insertions(+), 22 deletions(-)

Comments

Marc Kleine-Budde Dec. 8, 2022, 9:10 a.m. UTC | #1

On 08.12.2022 17:11:40, Vincent Mailhol wrote:
> The gs_can and ucan drivers keep a pointer to struct usb_interface in
> their private structure. This is not needed. For gs_can the only use
> is to retrieve struct usb_device, which is already available in
> gs_usb::udev. For ucan, the field is set but never used.
> 
> Remove the struct usb_interface fields and clean up.

Applied to linux-can-next.

Thanks,
Marc