diff mbox series

[v2,03/16] dt-bindings: pinctrl: Fix node descriptions in uniphier-pinctrl example

Message ID 20221207055405.30940-4-hayashi.kunihiko@socionext.com (mailing list archive)
State New, archived
Headers show
Series dt-bindings: soc: Introduce UniPhier miscellaneous register blocks and fix examples | expand

Commit Message

Kunihiko Hayashi Dec. 7, 2022, 5:53 a.m. UTC 
Rename the parent node to the generic node name "syscon".

Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
---
 .../devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Krzysztof Kozlowski Dec. 8, 2022, 8:07 a.m. UTC | #1 
On 07/12/2022 06:53, Kunihiko Hayashi wrote:
> Rename the parent node to the generic node name "syscon".
> 
> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
> ---
>  .../devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml
> index 14a8c0215cc6..186fc550af4c 100644
> --- a/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml
> @@ -69,7 +69,7 @@ examples:
>    - |
>      // The UniPhier pinctrl should be a subnode of a "syscon" compatible node.
>  
> -    soc-glue@5f800000 {
> +    syscon@5f800000 {
>          compatible = "socionext,uniphier-pro4-soc-glue", "simple-mfd", "syscon";
>          reg = <0x5f800000 0x2000>;
>  

Not visible in the diff but this is a poor example. It has only
compatible! Drop the parent node instead and extend the pinctrl node to
show complete picture of pinctrl.

Best regards,
Krzysztof
Kunihiko Hayashi Dec. 8, 2022, 3:09 p.m. UTC | #2 
On 2022/12/08 17:07, Krzysztof Kozlowski wrote:
> On 07/12/2022 06:53, Kunihiko Hayashi wrote:
>> Rename the parent node to the generic node name "syscon".
>>
>> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
>> ---
>>   .../devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git
>> a/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml
>> b/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml
>> index 14a8c0215cc6..186fc550af4c 100644
>> ---
>> a/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml
>> +++
>> b/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml
>> @@ -69,7 +69,7 @@ examples:
>>     - |
>>       // The UniPhier pinctrl should be a subnode of a "syscon" compatible
>> node.
>>
>> -    soc-glue@5f800000 {
>> +    syscon@5f800000 {
>>           compatible = "socionext,uniphier-pro4-soc-glue", "simple-mfd",
>> "syscon";
>>           reg = <0x5f800000 0x2000>;
>>
> 
> Not visible in the diff but this is a poor example. It has only
> compatible! Drop the parent node instead and extend the pinctrl node to
> show complete picture of pinctrl.

I should add some child nodes of groups and pin attributes as an example
from the devicetree.

Thank you,

---
Best Regards
Kunihiko Hayashi
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml
index 14a8c0215cc6..186fc550af4c 100644
--- a/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml
@@ -69,7 +69,7 @@  examples:
   - |
     // The UniPhier pinctrl should be a subnode of a "syscon" compatible node.
 
-    soc-glue@5f800000 {
+    syscon@5f800000 {
         compatible = "socionext,uniphier-pro4-soc-glue", "simple-mfd", "syscon";
         reg = <0x5f800000 0x2000>;