| Message ID | 20221208122313.55118-6-wangweidong.a@awinic.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | ASoC: codecs: Add Awinic AW883XX audio amplifier driver | expand |
On Thu, Dec 8, 2022 at 6:28 AM <wangweidong.a@awinic.com> wrote: > > From: Weidong Wang <wangweidong.a@awinic.com> > > Add a DT schema for describing Awinic AW883xx audio amplifiers. They are > controlled using I2C. blank line Pretty sure I said this before, but resend to the DT list if you want this reviewed. > Signed-off-by: Weidong Wang <wangweidong.a@awinic.com> > --- > .../bindings/sound/awinic,aw883xx.yaml | 49 +++++++++++++++++++ > 1 file changed, 49 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/awinic,aw883xx.yaml > > diff --git a/Documentation/devicetree/bindings/sound/awinic,aw883xx.yaml b/Documentation/devicetree/bindings/sound/awinic,aw883xx.yaml > new file mode 100644 > index 000000000000..b72c9177ebb7 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/awinic,aw883xx.yaml > @@ -0,0 +1,49 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/awinic,aw883xx.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Awinic AW883xx Smart Audio Amplifier > + > +maintainers: > + - Stephan Gerhold <stephan@gerhold.net> > + > +description: > + The Awinic AW883XX is an I2S/TDM input, high efficiency > + digital Smart K audio amplifier with an integrated 10.25V > + smart boost convert. > + > +allOf: > + - $ref: name-prefix.yaml# I think this file has now been renamed upstream.
On Thu, Dec 8, 2022 at 6:28 AM <wangweidong.a@awinic.com> wrote: > > From: Weidong Wang <wangweidong.a@awinic.com> > > Add a DT schema for describing Awinic AW883xx audio amplifiers. They are > controlled using I2C. > blank line > Pretty sure I said this before, but resend to the DT list if you want > this reviewed. Thank you for your advice, but could you please tell me how to resend it to the DT list > Signed-off-by: Weidong Wang <wangweidong.a@awinic.com> > --- > .../bindings/sound/awinic,aw883xx.yaml | 49 +++++++++++++++++++ > 1 file changed, 49 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/awinic,aw883xx.yaml > > diff --git a/Documentation/devicetree/bindings/sound/awinic,aw883xx.yaml b/Documentation/devicetree/bindings/sound/awinic,aw883xx.yaml > new file mode 100644 > index 000000000000..b72c9177ebb7 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/awinic,aw883xx.yaml > @@ -0,0 +1,49 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/awinic,aw883xx.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Awinic AW883xx Smart Audio Amplifier > + > +maintainers: > + - Stephan Gerhold <stephan@gerhold.net> > + > +description: > + The Awinic AW883XX is an I2S/TDM input, high efficiency > + digital Smart K audio amplifier with an integrated 10.25V > + smart boost convert. > + > +allOf: > + - $ref: name-prefix.yaml# > I think this file has now been renamed upstream. Thank you for your advice, but could you please describe why Thanks again for your advice best regards Weidong Wang
On 13/12/2022 08:26, wangweidong.a@awinic.com wrote: > On Thu, Dec 8, 2022 at 6:28 AM <wangweidong.a@awinic.com> wrote: >> >> From: Weidong Wang <wangweidong.a@awinic.com> >> >> Add a DT schema for describing Awinic AW883xx audio amplifiers. They are >> controlled using I2C. > >> blank line > >> Pretty sure I said this before, but resend to the DT list if you want >> this reviewed. > > Thank you for your advice, but could you please tell me how to resend it to the DT list Use scripts/get_maintainers.pl and send to all maintainers, reviewers and lists. Not to some subset, based on your preference. > >> Signed-off-by: Weidong Wang <wangweidong.a@awinic.com> >> --- >> .../bindings/sound/awinic,aw883xx.yaml | 49 +++++++++++++++++++ >> 1 file changed, 49 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/sound/awinic,aw883xx.yaml >> >> diff --git a/Documentation/devicetree/bindings/sound/awinic,aw883xx.yaml b/Documentation/devicetree/bindings/sound/awinic,aw883xx.yaml >> new file mode 100644 >> index 000000000000..b72c9177ebb7 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/sound/awinic,aw883xx.yaml >> @@ -0,0 +1,49 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/sound/awinic,aw883xx.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Awinic AW883xx Smart Audio Amplifier >> + >> +maintainers: >> + - Stephan Gerhold <stephan@gerhold.net> >> + >> +description: >> + The Awinic AW883XX is an I2S/TDM input, high efficiency >> + digital Smart K audio amplifier with an integrated 10.25V >> + smart boost convert. >> + >> +allOf: >> + - $ref: name-prefix.yaml# > >> I think this file has now been renamed upstream. > > Thank you for your advice, but could you please describe why Why? To better reflect the contents. Best regards, Krzysztof
On 13/12/2022 08:26, wangweidong.a@awinic.com wrote: > On Thu, Dec 8, 2022 at 6:28 AM <wangweidong.a@awinic.com> wrote: >> >> From: Weidong Wang <wangweidong.a@awinic.com> >> >> Add a DT schema for describing Awinic AW883xx audio amplifiers. They are >> controlled using I2C. > >> blank line > >> Pretty sure I said this before, but resend to the DT list if you want >> this reviewed. > > Thank you for your advice, but could you please tell me how to resend it to the DT list > Use scripts/get_maintainers.pl and send to all maintainers, reviewers > and lists. Not to some subset, based on your preference. Thank you very much, I will change it in patch v7 > >> Signed-off-by: Weidong Wang <wangweidong.a@awinic.com> >> --- >> .../bindings/sound/awinic,aw883xx.yaml | 49 +++++++++++++++++++ >> 1 file changed, 49 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/sound/awinic,aw883xx.yaml >> >> diff --git a/Documentation/devicetree/bindings/sound/awinic,aw883xx.yaml b/Documentation/devicetree/bindings/sound/awinic,aw883xx.yaml >> new file mode 100644 >> index 000000000000..b72c9177ebb7 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/sound/awinic,aw883xx.yaml >> @@ -0,0 +1,49 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/sound/awinic,aw883xx.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Awinic AW883xx Smart Audio Amplifier >> + >> +maintainers: >> + - Stephan Gerhold <stephan@gerhold.net> >> + >> +description: >> + The Awinic AW883XX is an I2S/TDM input, high efficiency >> + digital Smart K audio amplifier with an integrated 10.25V >> + smart boost convert. >> + >> +allOf: >> + - $ref: name-prefix.yaml# > >> I think this file has now been renamed upstream. > > Thank you for your advice, but could you please describe why > Why? To better reflect the contents. Thank you very much for your reply. But I don't understand why this file has now been renamed upstream. Best regards Weidong Wang
On 20/12/2022 12:25, wangweidong.a@awinic.com wrote: >>> +allOf: >>> + - $ref: name-prefix.yaml# >> >>> I think this file has now been renamed upstream. >> >> Thank you for your advice, but could you please describe why > >> Why? To better reflect the contents. > > Thank you very much for your reply. > But I don't understand why this file has now been renamed upstream. You asked the same question without helping to understand which part you did not understand... So you will get similar answer - because old name did not match the contents. Contents is now for something else, so old name is not correct anymore. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/sound/awinic,aw883xx.yaml b/Documentation/devicetree/bindings/sound/awinic,aw883xx.yaml new file mode 100644 index 000000000000..b72c9177ebb7 --- /dev/null +++ b/Documentation/devicetree/bindings/sound/awinic,aw883xx.yaml @@ -0,0 +1,49 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/sound/awinic,aw883xx.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Awinic AW883xx Smart Audio Amplifier + +maintainers: + - Stephan Gerhold <stephan@gerhold.net> + +description: + The Awinic AW883XX is an I2S/TDM input, high efficiency + digital Smart K audio amplifier with an integrated 10.25V + smart boost convert. + +allOf: + - $ref: name-prefix.yaml# + +properties: + compatible: + const: awinic,aw883xx_smartpa + + reg: + maxItems: 1 + + reset-gpios: + maxItems: 1 + + sound-name-prefix: true + +required: + - compatible + - reg + - reset-gpios + +additionalProperties: false + +examples: + - | + i2c { + #address-cells = <1>; + #size-cells = <0>; + audio-codec@34 { + compatible = "awinic,aw883xx_smartpa"; + reg = <0x34>; + reset-gpios = <&gpio 9 GPIO_ACTIVE_LOW>; + }; + };