[0/3] fix t1509-root-work-tree failure

Message

Philippe Blain via GitGitGadget Nov. 21, 2022, 3 a.m. UTC

The t1509-root-work-tree script started failing earlier this year but went
unnoticed because the script is rarely run since it requires setting up a
chroot environment or a sacrificial virtual machine. This patch series fixes
the failure and makes it a bit easier to run the script repeatedly without
it tripping over itself.

Eric Sunshine (3):
  t1509: fix failing "root work tree" test due to owner-check
  t1509: make "setup" test more robust
  t1509: facilitate repeated script invocations

 t/t1509-root-work-tree.sh | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)


base-commit: a0789512c5a4ae7da935cd2e419f253cb3cb4ce7
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1425%2Fsunshineco%2Ft1509fix-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1425/sunshineco/t1509fix-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/1425

Comments

Eric Sunshine Dec. 5, 2022, 6:21 p.m. UTC | #1

On Sun, Nov 20, 2022 at 10:00 PM Eric Sunshine via GitGitGadget
<[e-mail]> wrote:
> The t1509-root-work-tree script started failing earlier this year but went
> unnoticed because the script is rarely run since it requires setting up a
> chroot environment or a sacrificial virtual machine. This patch series fixes
> the failure and makes it a bit easier to run the script repeatedly without
> it tripping over itself.
>
> Eric Sunshine (3):
>   t1509: fix failing "root work tree" test due to owner-check
>   t1509: make "setup" test more robust
>   t1509: facilitate repeated script invocations

Ping?

Johannes Schindelin Dec. 8, 2022, 12:10 p.m. UTC | #2

Hi Eric,

On Mon, 5 Dec 2022, Eric Sunshine wrote:

> On Sun, Nov 20, 2022 at 10:00 PM Eric Sunshine via GitGitGadget
> <[e-mail]> wrote:
> > The t1509-root-work-tree script started failing earlier this year but went
> > unnoticed because the script is rarely run since it requires setting up a
> > chroot environment or a sacrificial virtual machine. This patch series fixes
> > the failure and makes it a bit easier to run the script repeatedly without
> > it tripping over itself.
> >
> > Eric Sunshine (3):
> >   t1509: fix failing "root work tree" test due to owner-check
> >   t1509: make "setup" test more robust
> >   t1509: facilitate repeated script invocations
>
> Ping?

Thank you for the ping. I did not have much time for the Git mailing list
as of late (too much Git for Windows stuff going on).

The patch series looks good to me, with or without the `test_atexit`
change I suggested.

Thank you,
Johannes

Eric Sunshine Dec. 9, 2022, 4:59 a.m. UTC | #3

On Thu, Dec 8, 2022 at 7:10 AM Johannes Schindelin
<[e-mail]> wrote:
> On Mon, 5 Dec 2022, Eric Sunshine wrote:
> > On Sun, Nov 20, 2022 at 10:00 PM Eric Sunshine via GitGitGadget
> > <[e-mail]> wrote:
> > > The t1509-root-work-tree script started failing earlier this year but went
> > > unnoticed because the script is rarely run since it requires setting up a
> > > chroot environment or a sacrificial virtual machine. This patch series fixes
> > > the failure and makes it a bit easier to run the script repeatedly without
> > > it tripping over itself.
> >
> > Ping?
>
> Thank you for the ping. I did not have much time for the Git mailing list
> as of late (too much Git for Windows stuff going on).
>
> The patch series looks good to me, with or without the `test_atexit`
> change I suggested.

Thanks for looking over the series. Taking downstream discussion[1][2]
into account regarding test_atexit(), I think I'll let the series
stand as-is.

In the long run, t1509 may need an overhaul, but the current series is
intended to be the minimal possible change (patch [1/3]) to get the
script working again, plus very minor "fixes" (patches [2/3] and
[3/3]) to make it a bit friendlier for the next person who has to
debug a failure in the script.

[1]: https://lore.kernel.org/git/[e-mail]/
[2]: https://lore.kernel.org/git/xmqq5yel18xf.fsf@gitster.g/