| Message ID | 20221209201326.2781950-1-aaronlewis@google.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | KVM: selftests: Fix a typo in the vcpu_msrs_set assert | expand |
On Fri, Dec 9, 2022 at 12:13 PM Aaron Lewis <aaronlewis@google.com> wrote: > > The assert incorrectly identifies the ioctl being called. Switch it > from KVM_GET_MSRS to KVM_SET_MSRS. > > Fixes: 6ebfef83f03f ("KVM: selftest: Add proper helpers for x86-specific save/restore ioctls") > Signed-off-by: Aaron Lewis <aaronlewis@google.com> Reviewed-by: Jim Mattson <jmattson@google.com>
On Fri, Dec 09, 2022, Aaron Lewis wrote: > The assert incorrectly identifies the ioctl being called. Switch it > from KVM_GET_MSRS to KVM_SET_MSRS. > > Fixes: 6ebfef83f03f ("KVM: selftest: Add proper helpers for x86-specific save/restore ioctls") > Signed-off-by: Aaron Lewis <aaronlewis@google.com> > --- Reviewed-by: Sean Christopherson <seanjc@google.com>
On Fri, 09 Dec 2022 20:13:27 +0000, Aaron Lewis wrote: > The assert incorrectly identifies the ioctl being called. Switch it > from KVM_GET_MSRS to KVM_SET_MSRS. > > Applied to kvm-x86 selftests, thanks! [1/1] KVM: selftests: Fix a typo in the vcpu_msrs_set assert https://github.com/kvm-x86/linux/commit/589713ee5f12 -- https://github.com/kvm-x86/linux/tree/next https://github.com/kvm-x86/linux/tree/fixes
diff --git a/tools/testing/selftests/kvm/include/x86_64/processor.h b/tools/testing/selftests/kvm/include/x86_64/processor.h index b1a31de7108a..92c5c9eba1bb 100644 --- a/tools/testing/selftests/kvm/include/x86_64/processor.h +++ b/tools/testing/selftests/kvm/include/x86_64/processor.h @@ -716,7 +716,7 @@ static inline void vcpu_msrs_set(struct kvm_vcpu *vcpu, struct kvm_msrs *msrs) int r = __vcpu_ioctl(vcpu, KVM_SET_MSRS, msrs); TEST_ASSERT(r == msrs->nmsrs, - "KVM_GET_MSRS failed, r: %i (failed on MSR %x)", + "KVM_SET_MSRS failed, r: %i (failed on MSR %x)", r, r < 0 || r >= msrs->nmsrs ? -1 : msrs->entries[r].index); } static inline void vcpu_debugregs_get(struct kvm_vcpu *vcpu,
The assert incorrectly identifies the ioctl being called. Switch it from KVM_GET_MSRS to KVM_SET_MSRS. Fixes: 6ebfef83f03f ("KVM: selftest: Add proper helpers for x86-specific save/restore ioctls") Signed-off-by: Aaron Lewis <aaronlewis@google.com> --- tools/testing/selftests/kvm/include/x86_64/processor.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)