| Message ID | 20221210135807.10688-1-konrad.dybcio@linaro.org (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [1/2] dt-bindings: remoteproc: qcom,adsp: Add SM6375 MPSS | expand |
On 10/12/2022 14:58, Konrad Dybcio wrote: > Add entries for SM6375 MPSS. Unlike most other modems, this one only > expects a single (cx) power domain. > > Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> > --- > Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml > index a9219c7c8349..434d34578fc5 100644 > --- a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml > +++ b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml > @@ -42,6 +42,7 @@ properties: > - qcom,sm6350-mpss-pas > - qcom,sm6375-adsp-pas > - qcom,sm6375-cdsp-pas There is no such entry... Do you base on some other patchset? > + - qcom,sm6375-mpss-pas I propose to rebase it on my series: https://lore.kernel.org/all/20221124184333.133911-1-krzysztof.kozlowski@linaro.org/ and then either add it as new file or maybe it will fit to one of the device schemas. Best regards, Krzysztof
On 11.12.2022 21:25, Krzysztof Kozlowski wrote: > On 10/12/2022 14:58, Konrad Dybcio wrote: >> Add entries for SM6375 MPSS. Unlike most other modems, this one only >> expects a single (cx) power domain. >> >> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> >> --- >> Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml >> index a9219c7c8349..434d34578fc5 100644 >> --- a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml >> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml >> @@ -42,6 +42,7 @@ properties: >> - qcom,sm6350-mpss-pas >> - qcom,sm6375-adsp-pas >> - qcom,sm6375-cdsp-pas > > There is no such entry... Do you base on some other patchset? Yep, this one [1].. I thought it was merged, as Bjorn pulled in the DT part (which stated dependency on [1]).. Konrad [1] https://lore.kernel.org/linux-arm-msm/20221109170822.58281-1-konrad.dybcio@linaro.org/ > >> + - qcom,sm6375-mpss-pas > > I propose to rebase it on my series: > https://lore.kernel.org/all/20221124184333.133911-1-krzysztof.kozlowski@linaro.org/ > > and then either add it as new file or maybe it will fit to one of the > device schemas. > > Best regards, > Krzysztof >
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml index a9219c7c8349..434d34578fc5 100644 --- a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml +++ b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml @@ -42,6 +42,7 @@ properties: - qcom,sm6350-mpss-pas - qcom,sm6375-adsp-pas - qcom,sm6375-cdsp-pas + - qcom,sm6375-mpss-pas - qcom,sm8150-adsp-pas - qcom,sm8150-cdsp-pas - qcom,sm8150-mpss-pas @@ -201,6 +202,7 @@ allOf: - qcom,sm6350-mpss-pas - qcom,sm6375-adsp-pas - qcom,sm6375-cdsp-pas + - qcom,sm6375-mpss-pas - qcom,sm8150-adsp-pas - qcom,sm8150-cdsp-pas - qcom,sm8150-mpss-pas @@ -350,6 +352,7 @@ allOf: - qcom,sc8180x-mpss-pas - qcom,sdx55-mpss-pas - qcom,sm6350-mpss-pas + - qcom,sm6375-mpss-pas - qcom,sm8150-mpss-pas - qcom,sm8350-mpss-pas - qcom,sm8450-mpss-pas @@ -379,6 +382,7 @@ allOf: - qcom,msm8996-adsp-pil - qcom,msm8998-adsp-pas - qcom,sm6375-cdsp-pas + - qcom,sm6375-mpss-pas - qcom,sm8150-adsp-pas - qcom,sm8150-cdsp-pas then:
Add entries for SM6375 MPSS. Unlike most other modems, this one only expects a single (cx) power domain. Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> --- Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml | 4 ++++ 1 file changed, 4 insertions(+)