[bpf-next,v2,1/9] selftests/bpf: Add missing section name tests for getpeername/getsockname

Commit Message

Daan De Meyer Dec. 10, 2022, 7:35 p.m. UTC

---
 .../selftests/bpf/prog_tests/section_names.c  | 20 +++++++++++++++++++
 1 file changed, 20 insertions(+)

Comments

Yonghong Song Dec. 13, 2022, 4:46 a.m. UTC | #1

On 12/10/22 11:35 AM, Daan De Meyer wrote:
> ---
>   .../selftests/bpf/prog_tests/section_names.c  | 20 +++++++++++++++++++
>   1 file changed, 20 insertions(+)

Please add some commit message, even if it is short and mimics
the subject line.

> 
> diff --git a/tools/testing/selftests/bpf/prog_tests/section_names.c b/tools/testing/selftests/bpf/prog_tests/section_names.c
> index 8b571890c57e..fc5248e94a01 100644
> --- a/tools/testing/selftests/bpf/prog_tests/section_names.c
> +++ b/tools/testing/selftests/bpf/prog_tests/section_names.c
> @@ -158,6 +158,26 @@ static struct sec_name_test tests[] = {
>   		{0, BPF_PROG_TYPE_CGROUP_SOCKOPT, BPF_CGROUP_SETSOCKOPT},
>   		{0, BPF_CGROUP_SETSOCKOPT},
>   	},
> +	{
> +		"cgroup/getpeername4",
> +		{0, BPF_PROG_TYPE_CGROUP_SOCK_ADDR, BPF_CGROUP_INET4_GETPEERNAME},
> +		{0, BPF_CGROUP_INET4_GETPEERNAME},
> +	},
> +	{
> +		"cgroup/getpeername6",
> +		{0, BPF_PROG_TYPE_CGROUP_SOCK_ADDR, BPF_CGROUP_INET6_GETPEERNAME},
> +		{0, BPF_CGROUP_INET6_GETPEERNAME},
> +	},
> +	{
> +		"cgroup/getsockname4",
> +		{0, BPF_PROG_TYPE_CGROUP_SOCK_ADDR, BPF_CGROUP_INET4_GETSOCKNAME},
> +		{0, BPF_CGROUP_INET4_GETSOCKNAME},
> +	},
> +	{
> +		"cgroup/getsockname6",
> +		{0, BPF_PROG_TYPE_CGROUP_SOCK_ADDR, BPF_CGROUP_INET6_GETSOCKNAME},
> +		{0, BPF_CGROUP_INET6_GETSOCKNAME},
> +	},
>   };
>   
>   static void test_prog_type_by_name(const struct sec_name_test *test)

Patch

diff --git a/tools/testing/selftests/bpf/prog_tests/section_names.c b/tools/testing/selftests/bpf/prog_tests/section_names.c
index 8b571890c57e..fc5248e94a01 100644
--- a/tools/testing/selftests/bpf/prog_tests/section_names.c
+++ b/tools/testing/selftests/bpf/prog_tests/section_names.c
@@ -158,6 +158,26 @@  static struct sec_name_test tests[] = {
 		{0, BPF_PROG_TYPE_CGROUP_SOCKOPT, BPF_CGROUP_SETSOCKOPT},
 		{0, BPF_CGROUP_SETSOCKOPT},
 	},
+	{
+		"cgroup/getpeername4",
+		{0, BPF_PROG_TYPE_CGROUP_SOCK_ADDR, BPF_CGROUP_INET4_GETPEERNAME},
+		{0, BPF_CGROUP_INET4_GETPEERNAME},
+	},
+	{
+		"cgroup/getpeername6",
+		{0, BPF_PROG_TYPE_CGROUP_SOCK_ADDR, BPF_CGROUP_INET6_GETPEERNAME},
+		{0, BPF_CGROUP_INET6_GETPEERNAME},
+	},
+	{
+		"cgroup/getsockname4",
+		{0, BPF_PROG_TYPE_CGROUP_SOCK_ADDR, BPF_CGROUP_INET4_GETSOCKNAME},
+		{0, BPF_CGROUP_INET4_GETSOCKNAME},
+	},
+	{
+		"cgroup/getsockname6",
+		{0, BPF_PROG_TYPE_CGROUP_SOCK_ADDR, BPF_CGROUP_INET6_GETSOCKNAME},
+		{0, BPF_CGROUP_INET6_GETSOCKNAME},
+	},
 };
 
 static void test_prog_type_by_name(const struct sec_name_test *test)