| Message ID | 20221209082936.892416-1-roberto.sassu@huaweicloud.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Paul Moore |
| Headers | show |
| Series | [1/2] lsm: Fix description of fs_context_parse_param | expand |
On Fri, Dec 9, 2022 at 3:30 AM Roberto Sassu <roberto.sassu@huaweicloud.com> wrote: > > From: Roberto Sassu <roberto.sassu@huawei.com> > > The fs_context_parse_param hook already has a description, which seems the > right one according to the code. > > Signed-off-by: Roberto Sassu <roberto.sassu@huawei.com> > --- > include/linux/lsm_hooks.h | 3 --- > 1 file changed, 3 deletions(-) I just merged this into lsm/next with a 'Fixes' tag pointing at the previous comment block commit, thanks Roberto.
On Fri, 2022-12-09 at 12:28 -0500, Paul Moore wrote: > On Fri, Dec 9, 2022 at 3:30 AM Roberto Sassu > <roberto.sassu@huaweicloud.com> wrote: > > From: Roberto Sassu <roberto.sassu@huawei.com> > > > > The fs_context_parse_param hook already has a description, which seems the > > right one according to the code. > > > > Signed-off-by: Roberto Sassu <roberto.sassu@huawei.com> > > --- > > include/linux/lsm_hooks.h | 3 --- > > 1 file changed, 3 deletions(-) > > I just merged this into lsm/next with a 'Fixes' tag pointing at the > previous comment block commit, thanks Roberto. Thanks Paul. Didn't include it, as I thought it is part of the stable kernel process. I guess it is always fine to include it, and to not CC the stable kernel mailing list, when the patch does not meet the criteria. Roberto
On Mon, Dec 12, 2022 at 3:34 AM Roberto Sassu <roberto.sassu@huaweicloud.com> wrote: > On Fri, 2022-12-09 at 12:28 -0500, Paul Moore wrote: > > On Fri, Dec 9, 2022 at 3:30 AM Roberto Sassu > > <roberto.sassu@huaweicloud.com> wrote: > > > From: Roberto Sassu <roberto.sassu@huawei.com> > > > > > > The fs_context_parse_param hook already has a description, which seems the > > > right one according to the code. > > > > > > Signed-off-by: Roberto Sassu <roberto.sassu@huawei.com> > > > --- > > > include/linux/lsm_hooks.h | 3 --- > > > 1 file changed, 3 deletions(-) > > > > I just merged this into lsm/next with a 'Fixes' tag pointing at the > > previous comment block commit, thanks Roberto. > > Thanks Paul. Didn't include it, as I thought it is part of the stable > kernel process. I guess it is always fine to include it, and to not CC > the stable kernel mailing list, when the patch does not meet the > criteria. To be clear, the 'Fixes' tag here was for the previous comment fix patch which only exists in the lsm/next branch and not any released kernel, adding a stable/CC to this patch wouldn't have done anything except throw up a number of automatically generated merge conflicts as the stable folks tried to merge just this patch. The 'Fixes' tag is simply a bit of administrative housekeeping to connect this patch back to the original, problematic patch; it will largely go unnoticed unless someone decides to cherry pick patches. When in doubt it's okay to add a Fixes tag, but leave off the stable/CC. In fact I prefer if people leave off the stable/CC as I've found it to often be misused IMO; I'd rather add it when merging the patch into one of the stable branches.
Hello: This series was applied to netdev/net.git (master) by Paul Moore <paul@paul-moore.com>: On Fri, 9 Dec 2022 09:29:35 +0100 you wrote: > From: Roberto Sassu <roberto.sassu@huawei.com> > > The fs_context_parse_param hook already has a description, which seems the > right one according to the code. > > Signed-off-by: Roberto Sassu <roberto.sassu@huawei.com> > > [...] Here is the summary with links: - [1/2] lsm: Fix description of fs_context_parse_param https://git.kernel.org/netdev/net/c/577cc1434e4c - [2/2] doc: Fix fs_context_parse_param description in mount_api.rst (no matching commit) You are awesome, thank you!
On Tue, Dec 13, 2022 at 8:08 PM <patchwork-bot+netdevbpf@kernel.org> wrote: > > Hello: > > This series was applied to netdev/net.git (master) > by Paul Moore <paul@paul-moore.com>: > > On Fri, 9 Dec 2022 09:29:35 +0100 you wrote: > > From: Roberto Sassu <roberto.sassu@huawei.com> > > > > The fs_context_parse_param hook already has a description, which seems the > > right one according to the code. > > > > Signed-off-by: Roberto Sassu <roberto.sassu@huawei.com> > > > > [...] > > Here is the summary with links: > - [1/2] lsm: Fix description of fs_context_parse_param > https://git.kernel.org/netdev/net/c/577cc1434e4c > - [2/2] doc: Fix fs_context_parse_param description in mount_api.rst > (no matching commit) > > You are awesome, thank you! > -- > Deet-doot-dot, I am a bot. > https://korg.docs.kernel.org/patchwork/pwbot.html It looks like the bot has a few screws loose as this went up to Linus via the LSM tree :)
diff --git a/include/linux/lsm_hooks.h b/include/linux/lsm_hooks.h index bad3b6baad86..20e70132584c 100644 --- a/include/linux/lsm_hooks.h +++ b/include/linux/lsm_hooks.h @@ -100,9 +100,6 @@ * the filesystem. * @fc indicates the filesystem context. * @param The parameter. - * Return 0 to indicate that the parameter should be passed on to the - * filesystem, 1 to indicate that the parameter should be discarded or an - * error to indicate that the parameter should be rejected. * * Security hooks for filesystem operations. *