mbox series

[v2,for-8.0,0/2] pci: drop redundant PCIDeviceClass::is_bridge field

Message ID 20221129101341.185621-1-imammedo@redhat.com (mailing list archive)
Headers show
Series pci: drop redundant PCIDeviceClass::is_bridge field | expand

Message

Igor Mammedov Nov. 29, 2022, 10:13 a.m. UTC
Changelog:
   - keep comment reminding that there was a bridge, so it would be easy to find
     removed code if someone wishes to bring it back
   - s/IS_PCI_BRIDGE/is_bridge/ in one instance where local is_bridge already exists

Igor Mammedov (2):
  remove DEC 21154 PCI bridge
  pci: drop redundant PCIDeviceClass::is_bridge field

 hw/pci-bridge/dec.h                |   9 --
 include/hw/pci/pci.h               |  11 +-
 include/hw/pci/pci_bridge.h        |   1 +
 include/hw/pci/pci_ids.h           |   1 -
 hw/acpi/pcihp.c                    |   3 +-
 hw/i386/acpi-build.c               |   5 +-
 hw/pci-bridge/cxl_downstream.c     |   1 -
 hw/pci-bridge/cxl_upstream.c       |   1 -
 hw/pci-bridge/dec.c                | 164 -----------------------------
 hw/pci-bridge/i82801b11.c          |   1 -
 hw/pci-bridge/meson.build          |   2 -
 hw/pci-bridge/pci_bridge_dev.c     |   1 -
 hw/pci-bridge/pcie_pci_bridge.c    |   1 -
 hw/pci-bridge/pcie_root_port.c     |   1 -
 hw/pci-bridge/simba.c              |   1 -
 hw/pci-bridge/xio3130_downstream.c |   1 -
 hw/pci-bridge/xio3130_upstream.c   |   1 -
 hw/pci-host/designware.c           |   1 -
 hw/pci-host/uninorth.c             |   9 +-
 hw/pci-host/xilinx-pcie.c          |   1 -
 hw/pci/pci.c                       |  20 ++--
 hw/ppc/spapr_pci.c                 |  15 +--
 22 files changed, 23 insertions(+), 228 deletions(-)
 delete mode 100644 hw/pci-bridge/dec.h
 delete mode 100644 hw/pci-bridge/dec.c

Comments

Igor Mammedov Dec. 14, 2022, 9:09 a.m. UTC | #1
On Tue, 29 Nov 2022 11:13:39 +0100
Igor Mammedov <imammedo@redhat.com> wrote:

> Changelog:
>    - keep comment reminding that there was a bridge, so it would be easy to find
>      removed code if someone wishes to bring it back
>    - s/IS_PCI_BRIDGE/is_bridge/ in one instance where local is_bridge already exists

Michael,

can you merge this via PCI tree?

> 
> Igor Mammedov (2):
>   remove DEC 21154 PCI bridge
>   pci: drop redundant PCIDeviceClass::is_bridge field
> 
>  hw/pci-bridge/dec.h                |   9 --
>  include/hw/pci/pci.h               |  11 +-
>  include/hw/pci/pci_bridge.h        |   1 +
>  include/hw/pci/pci_ids.h           |   1 -
>  hw/acpi/pcihp.c                    |   3 +-
>  hw/i386/acpi-build.c               |   5 +-
>  hw/pci-bridge/cxl_downstream.c     |   1 -
>  hw/pci-bridge/cxl_upstream.c       |   1 -
>  hw/pci-bridge/dec.c                | 164 -----------------------------
>  hw/pci-bridge/i82801b11.c          |   1 -
>  hw/pci-bridge/meson.build          |   2 -
>  hw/pci-bridge/pci_bridge_dev.c     |   1 -
>  hw/pci-bridge/pcie_pci_bridge.c    |   1 -
>  hw/pci-bridge/pcie_root_port.c     |   1 -
>  hw/pci-bridge/simba.c              |   1 -
>  hw/pci-bridge/xio3130_downstream.c |   1 -
>  hw/pci-bridge/xio3130_upstream.c   |   1 -
>  hw/pci-host/designware.c           |   1 -
>  hw/pci-host/uninorth.c             |   9 +-
>  hw/pci-host/xilinx-pcie.c          |   1 -
>  hw/pci/pci.c                       |  20 ++--
>  hw/ppc/spapr_pci.c                 |  15 +--
>  22 files changed, 23 insertions(+), 228 deletions(-)
>  delete mode 100644 hw/pci-bridge/dec.h
>  delete mode 100644 hw/pci-bridge/dec.c
>
Michael S. Tsirkin Dec. 14, 2022, 11:39 a.m. UTC | #2
On Wed, Dec 14, 2022 at 10:09:43AM +0100, Igor Mammedov wrote:
> On Tue, 29 Nov 2022 11:13:39 +0100
> Igor Mammedov <imammedo@redhat.com> wrote:
> 
> > Changelog:
> >    - keep comment reminding that there was a bridge, so it would be easy to find
> >      removed code if someone wishes to bring it back
> >    - s/IS_PCI_BRIDGE/is_bridge/ in one instance where local is_bridge already exists
> 
> Michael,
> 
> can you merge this via PCI tree?

Yes it's tagged. Busy with the linux pull req, qemu pull req next.
Thanks for the reminder!


> > 
> > Igor Mammedov (2):
> >   remove DEC 21154 PCI bridge
> >   pci: drop redundant PCIDeviceClass::is_bridge field
> > 
> >  hw/pci-bridge/dec.h                |   9 --
> >  include/hw/pci/pci.h               |  11 +-
> >  include/hw/pci/pci_bridge.h        |   1 +
> >  include/hw/pci/pci_ids.h           |   1 -
> >  hw/acpi/pcihp.c                    |   3 +-
> >  hw/i386/acpi-build.c               |   5 +-
> >  hw/pci-bridge/cxl_downstream.c     |   1 -
> >  hw/pci-bridge/cxl_upstream.c       |   1 -
> >  hw/pci-bridge/dec.c                | 164 -----------------------------
> >  hw/pci-bridge/i82801b11.c          |   1 -
> >  hw/pci-bridge/meson.build          |   2 -
> >  hw/pci-bridge/pci_bridge_dev.c     |   1 -
> >  hw/pci-bridge/pcie_pci_bridge.c    |   1 -
> >  hw/pci-bridge/pcie_root_port.c     |   1 -
> >  hw/pci-bridge/simba.c              |   1 -
> >  hw/pci-bridge/xio3130_downstream.c |   1 -
> >  hw/pci-bridge/xio3130_upstream.c   |   1 -
> >  hw/pci-host/designware.c           |   1 -
> >  hw/pci-host/uninorth.c             |   9 +-
> >  hw/pci-host/xilinx-pcie.c          |   1 -
> >  hw/pci/pci.c                       |  20 ++--
> >  hw/ppc/spapr_pci.c                 |  15 +--
> >  22 files changed, 23 insertions(+), 228 deletions(-)
> >  delete mode 100644 hw/pci-bridge/dec.h
> >  delete mode 100644 hw/pci-bridge/dec.c
> >