| Message ID | 20221213082449.2721-4-hayashi.kunihiko@socionext.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | dt-bindings: soc: Introduce UniPhier miscellaneous register blocks and fix examples | expand |
On 13/12/2022 09:24, Kunihiko Hayashi wrote: > Drop parent node of the pinctrl as it is not directly necessary, and > add more examples, that is "groups", "function", and a child node to set > pin attributes, to express this pinctrl node in detail. > > Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com> > --- > .../pinctrl/socionext,uniphier-pinctrl.yaml | 17 ++++++++++++----- > 1 file changed, 12 insertions(+), 5 deletions(-) > > diff --git a/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml > index 14a8c0215cc6..bc34e2c872bc 100644 > --- a/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml > @@ -1,4 +1,5 @@ > # SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > + Drop this part, no blank lines between SPDX and YAML. > %YAML 1.2 Best regards, Krzysztof
On 2022/12/13 23:52, Krzysztof Kozlowski wrote: > On 13/12/2022 09:24, Kunihiko Hayashi wrote: >> Drop parent node of the pinctrl as it is not directly necessary, and >> add more examples, that is "groups", "function", and a child node to set >> pin attributes, to express this pinctrl node in detail. >> >> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com> >> --- >> .../pinctrl/socionext,uniphier-pinctrl.yaml | 17 ++++++++++++----- >> 1 file changed, 12 insertions(+), 5 deletions(-) >> >> diff --git >> a/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml >> b/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml >> index 14a8c0215cc6..bc34e2c872bc 100644 >> --- >> a/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml >> +++ >> b/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml >> @@ -1,4 +1,5 @@ >> # SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause >> + > > Drop this part, no blank lines between SPDX and YAML. Thank you for checking. I carelessly added a blank line. I'll remove it. Thank you, --- Best Regards Kunihiko Hayashi
diff --git a/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml index 14a8c0215cc6..bc34e2c872bc 100644 --- a/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml @@ -1,4 +1,5 @@ # SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause + %YAML 1.2 --- $id: http://devicetree.org/schemas/pinctrl/socionext,uniphier-pinctrl.yaml# @@ -69,11 +70,17 @@ examples: - | // The UniPhier pinctrl should be a subnode of a "syscon" compatible node. - soc-glue@5f800000 { - compatible = "socionext,uniphier-pro4-soc-glue", "simple-mfd", "syscon"; - reg = <0x5f800000 0x2000>; + pinctrl { + compatible = "socionext,uniphier-ld20-pinctrl"; + + pinctrl_ether_rgmii: ether-rgmii { + groups = "ether_rgmii"; + function = "ether_rgmii"; - pinctrl: pinctrl { - compatible = "socionext,uniphier-pro4-pinctrl"; + tx { + pins = "RGMII_TXCLK", "RGMII_TXD0", "RGMII_TXD1", + "RGMII_TXD2", "RGMII_TXD3", "RGMII_TXCTL"; + drive-strength = <9>; + }; }; };
Drop parent node of the pinctrl as it is not directly necessary, and add more examples, that is "groups", "function", and a child node to set pin attributes, to express this pinctrl node in detail. Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com> --- .../pinctrl/socionext,uniphier-pinctrl.yaml | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-)