| Message ID | 20220527045353.2483042-1-hsinyi@chromium.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64: dts: mt8183: kukui: Split out keyboard node and describe detachables | expand |
On Fri, May 27, 2022 at 12:54 PM Hsin-Yi Wang <hsinyi@chromium.org> wrote: > > Kukui devices krane, kodana, and kakadu use detachable keyboards, which > only have switches to be registered. > > Change the keyboard node's compatible of those boards to the newly > introduced "google,cros-ec-keyb-switches", which won't include matrix > properties. > > Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org> > --- hi Matthias, Kindly ping on this patch. Thanks. > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi | 2 ++ > arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtsi | 6 ++++++ > arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama.dtsi | 6 ++++++ > arch/arm64/boot/dts/mediatek/mt8183-kukui-krane.dtsi | 6 ++++++ > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 1 - > 5 files changed, 20 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi > index 2d7a193272ae..981c889a22ea 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi > @@ -4,6 +4,8 @@ > */ > > #include "mt8183-kukui.dtsi" > +/* Must come after mt8183-kukui.dtsi to modify cros_ec */ > +#include <arm/cros-ec-keyboard.dtsi> > > / { > panel: panel { > diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtsi > index 28966a65391b..4b419623c8dc 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtsi > @@ -372,6 +372,12 @@ pen_eject { > }; > }; > > +&cros_ec { > + keyboard-controller { > + compatible = "google,cros-ec-keyb-switches"; > + }; > +}; > + > &qca_wifi { > qcom,ath10k-calibration-variant = "GO_KAKADU"; > }; > diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama.dtsi > index 06f8c80bf553..4864c39e53a4 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama.dtsi > @@ -339,6 +339,12 @@ touch_pin_reset: pin_reset { > }; > }; > > +&cros_ec { > + keyboard-controller { > + compatible = "google,cros-ec-keyb-switches"; > + }; > +}; > + > &qca_wifi { > qcom,ath10k-calibration-variant = "GO_KODAMA"; > }; > diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane.dtsi > index a7b0cb3ff7b0..d5f41c6c9881 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane.dtsi > @@ -343,6 +343,12 @@ rst_pin { > }; > }; > > +&cros_ec { > + keyboard-controller { > + compatible = "google,cros-ec-keyb-switches"; > + }; > +}; > + > &qca_wifi { > qcom,ath10k-calibration-variant = "LE_Krane"; > }; > diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi > index 8d5bf73a9099..db1388550f98 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi > @@ -986,5 +986,4 @@ hub@1 { > }; > }; > > -#include <arm/cros-ec-keyboard.dtsi> > #include <arm/cros-ec-sbs.dtsi> > -- > 2.36.1.124.g0e6072fb45-goog >
On 16/12/2022 11:54, Hsin-Yi Wang wrote: > On Fri, May 27, 2022 at 12:54 PM Hsin-Yi Wang <hsinyi@chromium.org> wrote: >> >> Kukui devices krane, kodana, and kakadu use detachable keyboards, which >> only have switches to be registered. >> >> Change the keyboard node's compatible of those boards to the newly >> introduced "google,cros-ec-keyb-switches", which won't include matrix >> properties. >> >> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org> >> --- > > hi Matthias, > > Kindly ping on this patch. Thanks. It's a merge window, so for what do you ping now? Best regards, Krzysztof
On Fri, Dec 16, 2022 at 6:58 PM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 16/12/2022 11:54, Hsin-Yi Wang wrote: > > On Fri, May 27, 2022 at 12:54 PM Hsin-Yi Wang <hsinyi@chromium.org> wrote: > >> > >> Kukui devices krane, kodana, and kakadu use detachable keyboards, which > >> only have switches to be registered. > >> > >> Change the keyboard node's compatible of those boards to the newly > >> introduced "google,cros-ec-keyb-switches", which won't include matrix > >> properties. > >> > >> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org> > >> --- > > > > hi Matthias, > > > > Kindly ping on this patch. Thanks. > > It's a merge window, so for what do you ping now? > Okay I should ping after the merge window. > Best regards, > Krzysztof >
On 27/05/2022 06:53, Hsin-Yi Wang wrote: > Kukui devices krane, kodana, and kakadu use detachable keyboards, which > only have switches to be registered. > > Change the keyboard node's compatible of those boards to the newly > introduced "google,cros-ec-keyb-switches", which won't include matrix > properties. > > Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org> Applied, thanks! > --- > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi | 2 ++ > arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtsi | 6 ++++++ > arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama.dtsi | 6 ++++++ > arch/arm64/boot/dts/mediatek/mt8183-kukui-krane.dtsi | 6 ++++++ > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 1 - > 5 files changed, 20 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi > index 2d7a193272ae..981c889a22ea 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi > @@ -4,6 +4,8 @@ > */ > > #include "mt8183-kukui.dtsi" > +/* Must come after mt8183-kukui.dtsi to modify cros_ec */ > +#include <arm/cros-ec-keyboard.dtsi> > > / { > panel: panel { > diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtsi > index 28966a65391b..4b419623c8dc 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtsi > @@ -372,6 +372,12 @@ pen_eject { > }; > }; > > +&cros_ec { > + keyboard-controller { > + compatible = "google,cros-ec-keyb-switches"; > + }; > +}; > + > &qca_wifi { > qcom,ath10k-calibration-variant = "GO_KAKADU"; > }; > diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama.dtsi > index 06f8c80bf553..4864c39e53a4 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama.dtsi > @@ -339,6 +339,12 @@ touch_pin_reset: pin_reset { > }; > }; > > +&cros_ec { > + keyboard-controller { > + compatible = "google,cros-ec-keyb-switches"; > + }; > +}; > + > &qca_wifi { > qcom,ath10k-calibration-variant = "GO_KODAMA"; > }; > diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane.dtsi > index a7b0cb3ff7b0..d5f41c6c9881 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane.dtsi > @@ -343,6 +343,12 @@ rst_pin { > }; > }; > > +&cros_ec { > + keyboard-controller { > + compatible = "google,cros-ec-keyb-switches"; > + }; > +}; > + > &qca_wifi { > qcom,ath10k-calibration-variant = "LE_Krane"; > }; > diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi > index 8d5bf73a9099..db1388550f98 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi > @@ -986,5 +986,4 @@ hub@1 { > }; > }; > > -#include <arm/cros-ec-keyboard.dtsi> > #include <arm/cros-ec-sbs.dtsi>
diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi index 2d7a193272ae..981c889a22ea 100644 --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi @@ -4,6 +4,8 @@ */ #include "mt8183-kukui.dtsi" +/* Must come after mt8183-kukui.dtsi to modify cros_ec */ +#include <arm/cros-ec-keyboard.dtsi> / { panel: panel { diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtsi index 28966a65391b..4b419623c8dc 100644 --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtsi @@ -372,6 +372,12 @@ pen_eject { }; }; +&cros_ec { + keyboard-controller { + compatible = "google,cros-ec-keyb-switches"; + }; +}; + &qca_wifi { qcom,ath10k-calibration-variant = "GO_KAKADU"; }; diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama.dtsi index 06f8c80bf553..4864c39e53a4 100644 --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama.dtsi @@ -339,6 +339,12 @@ touch_pin_reset: pin_reset { }; }; +&cros_ec { + keyboard-controller { + compatible = "google,cros-ec-keyb-switches"; + }; +}; + &qca_wifi { qcom,ath10k-calibration-variant = "GO_KODAMA"; }; diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane.dtsi index a7b0cb3ff7b0..d5f41c6c9881 100644 --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane.dtsi @@ -343,6 +343,12 @@ rst_pin { }; }; +&cros_ec { + keyboard-controller { + compatible = "google,cros-ec-keyb-switches"; + }; +}; + &qca_wifi { qcom,ath10k-calibration-variant = "LE_Krane"; }; diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi index 8d5bf73a9099..db1388550f98 100644 --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi @@ -986,5 +986,4 @@ hub@1 { }; }; -#include <arm/cros-ec-keyboard.dtsi> #include <arm/cros-ec-sbs.dtsi>
Kukui devices krane, kodana, and kakadu use detachable keyboards, which only have switches to be registered. Change the keyboard node's compatible of those boards to the newly introduced "google,cros-ec-keyb-switches", which won't include matrix properties. Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org> --- arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi | 2 ++ arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtsi | 6 ++++++ arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama.dtsi | 6 ++++++ arch/arm64/boot/dts/mediatek/mt8183-kukui-krane.dtsi | 6 ++++++ arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 1 - 5 files changed, 20 insertions(+), 1 deletion(-)