| Message ID | 20221218171539.11193-6-vr_qemu@t-online.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | audio: more improvements | expand |
On 18/12/22 18:15, Volker Rümelin wrote: > Replace audio_calloc() with the equivalent g_new0(). > > The value of the g_new0() argument count is >= 1, which means > g_new0() will never return NULL. Also remove the unnecessary > NULL check. Yes, since commit 7267c0947d (Sat Aug 20 22:09:37 2011)... Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org> > Signed-off-by: Volker Rümelin <vr_qemu@t-online.de> > --- > audio/alsaaudio.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-)
On 12/18/22 09:15, Volker Rümelin wrote: > Replace audio_calloc() with the equivalent g_new0(). > > The value of the g_new0() argument count is >= 1, which means > g_new0() will never return NULL. Also remove the unnecessary > NULL check. > > Signed-off-by: Volker Rümelin<vr_qemu@t-online.de> > --- > audio/alsaaudio.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
diff --git a/audio/alsaaudio.c b/audio/alsaaudio.c index 714bfb6453..5f50dfa0bf 100644 --- a/audio/alsaaudio.c +++ b/audio/alsaaudio.c @@ -222,11 +222,7 @@ static int alsa_poll_helper (snd_pcm_t *handle, struct pollhlp *hlp, int mask) return -1; } - pfds = audio_calloc ("alsa_poll_helper", count, sizeof (*pfds)); - if (!pfds) { - dolog ("Could not initialize poll mode\n"); - return -1; - } + pfds = g_new0(struct pollfd, count); err = snd_pcm_poll_descriptors (handle, pfds, count); if (err < 0) {
Replace audio_calloc() with the equivalent g_new0(). The value of the g_new0() argument count is >= 1, which means g_new0() will never return NULL. Also remove the unnecessary NULL check. Signed-off-by: Volker Rümelin <vr_qemu@t-online.de> --- audio/alsaaudio.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)