diff mbox series

drm/i915/mtl: Add support of Tile4 to MTL

Message ID 20221220162926.22805-1-stanislav.lisovskiy@intel.com (mailing list archive)
State New, archived
Headers show
Series drm/i915/mtl: Add support of Tile4 to MTL | expand

Commit Message

Stanislav Lisovskiy Dec. 20, 2022, 4:29 p.m. UTC
We have some Tile4 tests now skipping, which were
supposed to be working. So lets make them work, by
adding display_ver 14 as supported.

v2: - Remove "14" for Tile 4 CCS formats, as they
      seem to be not supported by DG2(Juha-Pekka Heikkila)
    - For generic Tile 4, the opposite - lets use -1
      in order to make sure all the next gens support it by
      default(Juha-Pekka Heikkila)

Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
---
 drivers/gpu/drm/i915/display/intel_fb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Juha-Pekka Heikkila Dec. 20, 2022, 9:23 p.m. UTC | #1
On 20.12.2022 18.29, Stanislav Lisovskiy wrote:
> We have some Tile4 tests now skipping, which were
> supposed to be working. So lets make them work, by
> adding display_ver 14 as supported.
> 
> v2: - Remove "14" for Tile 4 CCS formats, as they
>        seem to be not supported by DG2(Juha-Pekka Heikkila)

DG2 ccs modifiers not supported on MTL. DG2 ccs modifiers are of course 
supported on DG2.

>      - For generic Tile 4, the opposite - lets use -1
>        in order to make sure all the next gens support it by
>        default(Juha-Pekka Heikkila)
> 
> Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
> ---
>   drivers/gpu/drm/i915/display/intel_fb.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_fb.c b/drivers/gpu/drm/i915/display/intel_fb.c
> index 63137ae5ab217..93d0e46e54813 100644
> --- a/drivers/gpu/drm/i915/display/intel_fb.c
> +++ b/drivers/gpu/drm/i915/display/intel_fb.c
> @@ -174,7 +174,7 @@ static const struct intel_modifier_desc intel_modifiers[] = {
>   		.plane_caps = INTEL_PLANE_CAP_TILING_4 | INTEL_PLANE_CAP_CCS_RC,
>   	}, {
>   		.modifier = I915_FORMAT_MOD_4_TILED,
> -		.display_ver = { 13, 13 },
> +		.display_ver = { 13, -1 },
>   		.plane_caps = INTEL_PLANE_CAP_TILING_4,
>   	}, {
>   		.modifier = I915_FORMAT_MOD_Y_TILED_GEN12_MC_CCS,

Reviewed-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/display/intel_fb.c b/drivers/gpu/drm/i915/display/intel_fb.c
index 63137ae5ab217..93d0e46e54813 100644
--- a/drivers/gpu/drm/i915/display/intel_fb.c
+++ b/drivers/gpu/drm/i915/display/intel_fb.c
@@ -174,7 +174,7 @@  static const struct intel_modifier_desc intel_modifiers[] = {
 		.plane_caps = INTEL_PLANE_CAP_TILING_4 | INTEL_PLANE_CAP_CCS_RC,
 	}, {
 		.modifier = I915_FORMAT_MOD_4_TILED,
-		.display_ver = { 13, 13 },
+		.display_ver = { 13, -1 },
 		.plane_caps = INTEL_PLANE_CAP_TILING_4,
 	}, {
 		.modifier = I915_FORMAT_MOD_Y_TILED_GEN12_MC_CCS,