| Message ID | 20221221173055.11719-2-gatien.chevallier@foss.st.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Introduce STM32 system bus | expand |
Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel. On 21/12/2022 18:30, Gatien Chevallier wrote: > From: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com> You same From as SoB. > > Introducing of the common device controller bindings for the controller > provider and consumer devices. Those bindings are intended to allow > divided system on chip into muliple domains, that can be used to > configure hardware permissions. > > Signed-off-by: Oleksii Moisieiev <oleksii_moisieiev@epam.com> Missing SoB. Missing changelog. This is not v1 but v7 or something. > --- > .../feature-domain-controller.yaml | 84 +++++++++++++++++++ > 1 file changed, 84 insertions(+) > create mode 100644 Documentation/devicetree/bindings/feature-controllers/feature-domain-controller.yaml > > diff --git a/Documentation/devicetree/bindings/feature-controllers/feature-domain-controller.yaml b/Documentation/devicetree/bindings/feature-controllers/feature-domain-controller.yaml > new file mode 100644 > index 000000000000..90a7c38c833c > --- /dev/null > +++ b/Documentation/devicetree/bindings/feature-controllers/feature-domain-controller.yaml > @@ -0,0 +1,84 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/feature-controllers/feature-domain-controller.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Generic Domain Controller bindings Drop "bindings". Anyway you duplicate work here: https://lore.kernel.org/all/c869d2751125181a55bc8a88c96e3a892b42f37a.1668070216.git.oleksii_moisieiev@epam.com/ and maybe you duplicate comments. I don't think there is point to review things twice, so NAK. Best regards, Krzysztof
Hello Krzysztof, On 12/22/22 11:22, Krzysztof Kozlowski wrote: > Please use scripts/get_maintainers.pl to get a list of necessary people > and lists to CC. It might happen, that command when run on an older > kernel, gives you outdated entries. Therefore please be sure you base > your patches on recent Linux kernel. > > > On 21/12/2022 18:30, Gatien Chevallier wrote: >> From: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com> > > You same From as SoB. > >> >> Introducing of the common device controller bindings for the controller >> provider and consumer devices. Those bindings are intended to allow >> divided system on chip into muliple domains, that can be used to >> configure hardware permissions. >> >> Signed-off-by: Oleksii Moisieiev <oleksii_moisieiev@epam.com> > > Missing SoB. > > Missing changelog. This is not v1 but v7 or something > > > >> --- >> .../feature-domain-controller.yaml | 84 +++++++++++++++++++ >> 1 file changed, 84 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/feature-controllers/feature-domain-controller.yaml >> >> diff --git a/Documentation/devicetree/bindings/feature-controllers/feature-domain-controller.yaml b/Documentation/devicetree/bindings/feature-controllers/feature-domain-controller.yaml >> new file mode 100644 >> index 000000000000..90a7c38c833c >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/feature-controllers/feature-domain-controller.yaml >> @@ -0,0 +1,84 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/feature-controllers/feature-domain-controller.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Generic Domain Controller bindings > > Drop "bindings". > > Anyway you duplicate work here: > https://lore.kernel.org/all/c869d2751125181a55bc8a88c96e3a892b42f37a.1668070216.git.oleksii_moisieiev@epam.com/ > and maybe you duplicate comments. > > I don't think there is point to review things twice, so NAK. This is a result of me not knowing how to handle this particular case. It is a patch that I need to have in my patch set in order to pass Rob's bindings check. Otherwise, feature domains bindings defined here will not be known in the STM32 System Bus binding file, where they are used. I wanted to illustrate the use of Oleksii's binding with a practical use-case that we want to implement. What would be the correct way of managing this dependency? -Specify something like "On top of ...." in the cover letter/patch and reference the other thread? -Use a "Depends-On" tag on the YAML binding commit? -Something else? Best regards, Gatien > > > Best regards, > Krzysztof >
On 22/12/2022 14:01, Gatien CHEVALLIER wrote: > >> >> Anyway you duplicate work here: >> https://lore.kernel.org/all/c869d2751125181a55bc8a88c96e3a892b42f37a.1668070216.git.oleksii_moisieiev@epam.com/ >> and maybe you duplicate comments. >> >> I don't think there is point to review things twice, so NAK. > This is a result of me not knowing how to handle this particular case. > It is a patch that I need to have in my patch set in order to pass Rob's > bindings check. Otherwise, feature domains bindings defined here will > not be known in the STM32 System Bus binding file, where they are used. > > I wanted to illustrate the use of Oleksii's binding with a practical > use-case that we want to implement. Mention patch dependency in the path changelog (---) and that's it. No tests will be done. You are expected to run tests anyway on your side, before sending. > > What would be the correct way of managing this dependency? > -Specify something like "On top of ...." in the cover letter/patch and > reference the other thread? > -Use a "Depends-On" tag on the YAML binding commit? > -Something else? Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/feature-controllers/feature-domain-controller.yaml b/Documentation/devicetree/bindings/feature-controllers/feature-domain-controller.yaml new file mode 100644 index 000000000000..90a7c38c833c --- /dev/null +++ b/Documentation/devicetree/bindings/feature-controllers/feature-domain-controller.yaml @@ -0,0 +1,84 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/feature-controllers/feature-domain-controller.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Generic Domain Controller bindings + +maintainers: + - Oleksii Moisieiev <oleksii_moisieiev@epam.com> + +description: |+ + Common Feature Domains Controller bindings properties + + Domain controllers allow to divided system on chip into multiple feature + domains that can be used to select by who hardware blocks could be accessed. + A feature domain could be a cluster of CPUs (or coprocessors), a range of + addresses or a group of hardware blocks. + + This device tree bindings can be used to bind feature domain consumer devices + with their feature domains provided by feature-domains controllers. + Feature omain controller provider can be represened by any node in the + device tree and can provide one or more configuration parameters, needed to + control parameters of the consumer device. A consumer node can refer to the + provider by phandle and a set of phandle arguments, specified by + '#feature-domain-cells' property in the device controller provider node. + + Device controllers are typically used to set the permissions of the hardware + block. The contents of the feature-domains configuration properties are + defined by the binding for the individual feature-domains controller device. + + Each node can be a consumer for the several providers. The first + configuration of 'feature-domains' or the one named 'default' is applied + before probing the device itself. + +# always select the core schema +select: true + +properties: + '#feature-domain-cells': + $ref: /schemas/types.yaml#/definitions/uint32 + description: + Number of cells in a feature-domains controller specifier; + Can be any value as specified by device tree binding documentation + of a particular provider. + + feature-domain-controller: + description: + Indicates that the node is feature-domain-controller provider. + + feature-domain-names: + $ref: '/schemas/types.yaml#/definitions/string-array' + description: + A list of feature-domains names, sorted in the same order as + feature-domains entries. Consumer drivers will use feature-domain-names + to match with existing feature-domains entries. + + feature-domains: + $ref: "/schemas/types.yaml#/definitions/phandle-array" + description: + A list of feature-domains controller specifiers, as defined by the + bindings of the feature-domain-controller provider. + +additionalProperties: true + +examples: + - | + ctrl0: ctrl@100 { + feature-domain-controller; + reg = <0x100 0x10>; + #feature-domain-cells = <2>; + }; + + ctrl1: ctrl@110 { + feature-domain-controller; + reg = <0x110 0x10>; + #feature-domain-cells = <3>; + }; + + foo@0 { + reg = <0x0 0x1>; + feature-domains = <&ctrl0 1 2>, <&ctrl1 3 4 5>; + feature-domain-names = "default", "unbind"; + };