diff mbox series

pinctrl: nomadik: include linux/seq_file.h

Message ID 20221215170103.2349282-1-arnd@kernel.org (mailing list archive)
State New, archived
Headers show
Series pinctrl: nomadik: include linux/seq_file.h | expand

Commit Message

Arnd Bergmann Dec. 15, 2022, 5 p.m. UTC 
From: Arnd Bergmann <arnd@arndb.de>

In some randconfig builds, the missing #include causes a
build failure:

drivers/pinctrl/nomadik/pinctrl-nomadik.c: In function 'nmk_gpio_irq_print_chip':
drivers/pinctrl/nomadik/pinctrl-nomadik.c:1084:9: error: implicit declaration of function 'seq_printf'; did you mean 'bstr_printf'? [-Werror=implicit-function-declaration]
 1084 |         seq_printf(p, "nmk%u-%u-%u", nmk_chip->bank,
      |         ^~~~~~~~~~
      |         bstr_printf

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/pinctrl/nomadik/pinctrl-nomadik.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Andy Shevchenko Dec. 15, 2022, 5:16 p.m. UTC | #1 
On Thu, Dec 15, 2022 at 06:00:57PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> In some randconfig builds, the missing #include causes a
> build failure:
> 
> drivers/pinctrl/nomadik/pinctrl-nomadik.c: In function 'nmk_gpio_irq_print_chip':
> drivers/pinctrl/nomadik/pinctrl-nomadik.c:1084:9: error: implicit declaration of function 'seq_printf'; did you mean 'bstr_printf'? [-Werror=implicit-function-declaration]
>  1084 |         seq_printf(p, "nmk%u-%u-%u", nmk_chip->bank,
>       |         ^~~~~~~~~~
>       |         bstr_printf

Hmm... Strange that I have not noticed this from CIs.
Nevertheless, I have a patch that adds more missing
headers to this driver. I have planned to send it
after v6.2-rc1.

I'm fine if this goes first. Up to Linus.
Andy Shevchenko Dec. 28, 2022, 8:52 a.m. UTC | #2 
On Thu, Dec 15, 2022 at 07:16:54PM +0200, Andy Shevchenko wrote:
> On Thu, Dec 15, 2022 at 06:00:57PM +0100, Arnd Bergmann wrote:
> > From: Arnd Bergmann <arnd@arndb.de>
> > 
> > In some randconfig builds, the missing #include causes a
> > build failure:
> > 
> > drivers/pinctrl/nomadik/pinctrl-nomadik.c: In function 'nmk_gpio_irq_print_chip':
> > drivers/pinctrl/nomadik/pinctrl-nomadik.c:1084:9: error: implicit declaration of function 'seq_printf'; did you mean 'bstr_printf'? [-Werror=implicit-function-declaration]
> >  1084 |         seq_printf(p, "nmk%u-%u-%u", nmk_chip->bank,
> >       |         ^~~~~~~~~~
> >       |         bstr_printf
> 
> Hmm... Strange that I have not noticed this from CIs.
> Nevertheless, I have a patch that adds more missing
> headers to this driver. I have planned to send it
> after v6.2-rc1.
> 
> I'm fine if this goes first. Up to Linus.

FYI: I have just sent my version
https://lore.kernel.org/r/20221228084310.85210-1-andriy.shevchenko@linux.intel.com
diff mbox series

Patch

diff --git a/drivers/pinctrl/nomadik/pinctrl-nomadik.c b/drivers/pinctrl/nomadik/pinctrl-nomadik.c
index f7d02513d8cc..1d8e36c2785d 100644
--- a/drivers/pinctrl/nomadik/pinctrl-nomadik.c
+++ b/drivers/pinctrl/nomadik/pinctrl-nomadik.c
@@ -17,6 +17,7 @@ 
 #include <linux/gpio/driver.h>
 #include <linux/spinlock.h>
 #include <linux/interrupt.h>
+#include <linux/seq_file.h>
 #include <linux/slab.h>
 #include <linux/of_device.h>
 #include <linux/of_address.h>