| Message ID | 20221228123655.15384-2-hnagalla@ti.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add C7xv DSP for AM62A | expand |
On 28/12/2022 13:36, Hari Nagalla wrote: > The TI AM62A SoCs have a C7xv DSP and Analytics engine for deep > learning purposes. The DSP part is similar to the C71x DSP found on > K3 J7 SoCs, but additional hardware accelerators and IP are added to > the subsystem for deep learning. > > Compatible info is updated to match AM62A SoCs. > > Signed-off-by: Hari Nagalla <hnagalla@ti.com> > --- > .../devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml > index cedbc5efdc56..846c9c14169a 100644 > --- a/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml > +++ b/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml > @@ -34,10 +34,12 @@ properties: > - ti,j721e-c66-dsp > - ti,j721e-c71-dsp > - ti,j721s2-c71-dsp > + - ti,am62a-c7xv-dsp Add it in some order, e.g. alphabetical. > description: > Use "ti,j721e-c66-dsp" for C66x DSPs on K3 J721E SoCs > Use "ti,j721e-c71-dsp" for C71x DSPs on K3 J721E SoCs > Use "ti,j721s2-c71-dsp" for C71x DSPs on K3 J721S2 SoCs > + Use "ti,am62a-c7xv-dsp" for AM62A Deep learning DSPs on K3 AM62A SoCs > > resets: > description: | > @@ -111,6 +113,7 @@ else: > enum: > - ti,j721e-c71-dsp > - ti,j721s2-c71-dsp > + - ti,am62a-c7xv-dsp Does not look like you tested the bindings. Please run `make dt_binding_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions). Wrong indentation. Best regards, Krzysztof
On Wed, 28 Dec 2022 06:36:54 -0600, Hari Nagalla wrote: > The TI AM62A SoCs have a C7xv DSP and Analytics engine for deep > learning purposes. The DSP part is similar to the C71x DSP found on > K3 J7 SoCs, but additional hardware accelerators and IP are added to > the subsystem for deep learning. > > Compatible info is updated to match AM62A SoCs. > > Signed-off-by: Hari Nagalla <hnagalla@ti.com> > --- > .../devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml | 3 +++ > 1 file changed, 3 insertions(+) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: ./Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml:116:1: [error] syntax error: found character '\t' that cannot start any token (syntax) dtschema/dtc warnings/errors: make[1]: *** Deleting file 'Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.example.dts' Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml:116:1: found character '\t' that cannot start any token make[1]: *** [Documentation/devicetree/bindings/Makefile:26: Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.example.dts] Error 1 make[1]: *** Waiting for unfinished jobs.... ./Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml:116:1: found character '\t' that cannot start any token /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml: ignoring, error parsing file make: *** [Makefile:1508: dt_binding_check] Error 2 doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20221228123655.15384-2-hnagalla@ti.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On 12/28/22 06:38, Krzysztof Kozlowski wrote: >> >> resets: >> description: | >> @@ -111,6 +113,7 @@ else: >> enum: >> - ti,j721e-c71-dsp >> - ti,j721s2-c71-dsp >> + - ti,am62a-c7xv-dsp > Does not look like you tested the bindings. Please run `make > dt_binding_check` (see > Documentation/devicetree/bindings/writing-schema.rst for instructions). > > Wrong indentation. Seems, i used a wrong option in our patch verify script. Used the correct options and fixed it. sending v2 with review comment updates. Thanks
diff --git a/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml index cedbc5efdc56..846c9c14169a 100644 --- a/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml +++ b/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml @@ -34,10 +34,12 @@ properties: - ti,j721e-c66-dsp - ti,j721e-c71-dsp - ti,j721s2-c71-dsp + - ti,am62a-c7xv-dsp description: Use "ti,j721e-c66-dsp" for C66x DSPs on K3 J721E SoCs Use "ti,j721e-c71-dsp" for C71x DSPs on K3 J721E SoCs Use "ti,j721s2-c71-dsp" for C71x DSPs on K3 J721S2 SoCs + Use "ti,am62a-c7xv-dsp" for AM62A Deep learning DSPs on K3 AM62A SoCs resets: description: | @@ -111,6 +113,7 @@ else: enum: - ti,j721e-c71-dsp - ti,j721s2-c71-dsp + - ti,am62a-c7xv-dsp then: properties: reg:
The TI AM62A SoCs have a C7xv DSP and Analytics engine for deep learning purposes. The DSP part is similar to the C71x DSP found on K3 J7 SoCs, but additional hardware accelerators and IP are added to the subsystem for deep learning. Compatible info is updated to match AM62A SoCs. Signed-off-by: Hari Nagalla <hnagalla@ti.com> --- .../devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml | 3 +++ 1 file changed, 3 insertions(+)