| Message ID | 20230103145219.40226-1-andriy.shevchenko@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v1,1/1] media: i2c: st-vgxy61: Use asm intead of asm-generic | expand |
Hi Andy, Thank you for your patch. On 1/3/23 15:52, Andy Shevchenko wrote: > There is no point to specify asm-generic for the unaligned.h. > Drop the 'generic' suffix and move the inclusion to be after > the non-media linux/* ones. > > Cc: Sakari Ailus <sakari.ailus@linux.intel.com> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > drivers/media/i2c/st-vgxy61.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/i2c/st-vgxy61.c b/drivers/media/i2c/st-vgxy61.c > index 826baf4e064d..5dcabee6677d 100644 > --- a/drivers/media/i2c/st-vgxy61.c > +++ b/drivers/media/i2c/st-vgxy61.c > @@ -5,7 +5,6 @@ > * Copyright (C) 2022 STMicroelectronics SA > */ > > -#include <asm-generic/unaligned.h> > #include <linux/clk.h> > #include <linux/delay.h> > #include <linux/gpio/consumer.h> > @@ -15,6 +14,9 @@ > #include <linux/pm_runtime.h> > #include <linux/regulator/consumer.h> > #include <linux/units.h> > + > +#include <asm/unaligned.h> > + Any particular reason not to keep the alphabetical sort ? > #include <media/mipi-csi2.h> > #include <media/v4l2-async.h> > #include <media/v4l2-ctrls.h>
On Wed, Jan 04, 2023 at 10:27:14AM +0100, Benjamin Mugnier wrote: > On 1/3/23 15:52, Andy Shevchenko wrote: ... > > -#include <asm-generic/unaligned.h> > > #include <linux/clk.h> > > #include <linux/delay.h> > > #include <linux/gpio/consumer.h> > > @@ -15,6 +14,9 @@ > > #include <linux/pm_runtime.h> > > #include <linux/regulator/consumer.h> > > #include <linux/units.h> > > + > > +#include <asm/unaligned.h> > Any particular reason not to keep the alphabetical sort ? It's kept in an order in each of the groups of headers. The main rule here is to go from most generic headers to the particular ones. asm/* are definitely more particular than linux/* ones. > > #include <media/mipi-csi2.h> > > #include <media/v4l2-async.h> > > #include <media/v4l2-ctrls.h>
On 1/4/23 11:20, Andy Shevchenko wrote: > On Wed, Jan 04, 2023 at 10:27:14AM +0100, Benjamin Mugnier wrote: >> On 1/3/23 15:52, Andy Shevchenko wrote: > > ... > >>> -#include <asm-generic/unaligned.h> >>> #include <linux/clk.h> >>> #include <linux/delay.h> >>> #include <linux/gpio/consumer.h> >>> @@ -15,6 +14,9 @@ >>> #include <linux/pm_runtime.h> >>> #include <linux/regulator/consumer.h> >>> #include <linux/units.h> >>> + >>> +#include <asm/unaligned.h> > >> Any particular reason not to keep the alphabetical sort ? > > It's kept in an order in each of the groups of headers. > > The main rule here is to go from most generic headers to the particular ones. > asm/* are definitely more particular than linux/* ones. > Thank you for your explanation. Reviewed-by: Benjamin Mugnier <benjamin.mugnier@foss.st.com> >>> #include <media/mipi-csi2.h> >>> #include <media/v4l2-async.h> >>> #include <media/v4l2-ctrls.h> >
diff --git a/drivers/media/i2c/st-vgxy61.c b/drivers/media/i2c/st-vgxy61.c index 826baf4e064d..5dcabee6677d 100644 --- a/drivers/media/i2c/st-vgxy61.c +++ b/drivers/media/i2c/st-vgxy61.c @@ -5,7 +5,6 @@ * Copyright (C) 2022 STMicroelectronics SA */ -#include <asm-generic/unaligned.h> #include <linux/clk.h> #include <linux/delay.h> #include <linux/gpio/consumer.h> @@ -15,6 +14,9 @@ #include <linux/pm_runtime.h> #include <linux/regulator/consumer.h> #include <linux/units.h> + +#include <asm/unaligned.h> + #include <media/mipi-csi2.h> #include <media/v4l2-async.h> #include <media/v4l2-ctrls.h>
There is no point to specify asm-generic for the unaligned.h. Drop the 'generic' suffix and move the inclusion to be after the non-media linux/* ones. Cc: Sakari Ailus <sakari.ailus@linux.intel.com> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/media/i2c/st-vgxy61.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)