| Message ID | 20230105034249.10433-1-hui.wang@canonical.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | eea8ce81fbb544e3caad1a1c876ba1af467b3d3c |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: usb: cdc_ether: add support for Thales Cinterion PLS62-W modem | expand |
Thu, Jan 05, 2023 at 04:42:49AM CET, hui.wang@canonical.com wrote: >This modem has 7 interfaces, 5 of them are serial interfaces and are >driven by cdc_acm, while 2 of them are wwan interfaces and are driven >by cdc_ether: >If 0: Abstract (modem) >If 1: Abstract (modem) >If 2: Abstract (modem) >If 3: Abstract (modem) >If 4: Abstract (modem) >If 5: Ethernet Networking >If 6: Ethernet Networking > >Without this change, the 2 network interfaces will be named to usb0 >and usb1, our QA think the names are confusing and filed a bug on it. > >After applying this change, the name will be wwan0 and wwan1, and >they could work well with modem manager. > >Signed-off-by: Hui Wang <hui.wang@canonical.com> Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Hello: This patch was applied to netdev/net.git (master) by Jakub Kicinski <kuba@kernel.org>: On Thu, 5 Jan 2023 11:42:49 +0800 you wrote: > This modem has 7 interfaces, 5 of them are serial interfaces and are > driven by cdc_acm, while 2 of them are wwan interfaces and are driven > by cdc_ether: > If 0: Abstract (modem) > If 1: Abstract (modem) > If 2: Abstract (modem) > If 3: Abstract (modem) > If 4: Abstract (modem) > If 5: Ethernet Networking > If 6: Ethernet Networking > > [...] Here is the summary with links: - net: usb: cdc_ether: add support for Thales Cinterion PLS62-W modem https://git.kernel.org/netdev/net/c/eea8ce81fbb5 You are awesome, thank you!
diff --git a/drivers/net/usb/cdc_ether.c b/drivers/net/usb/cdc_ether.c index 8911cd2ed534..c140edb4b648 100644 --- a/drivers/net/usb/cdc_ether.c +++ b/drivers/net/usb/cdc_ether.c @@ -1007,6 +1007,12 @@ static const struct usb_device_id products[] = { USB_CDC_SUBCLASS_ETHERNET, USB_CDC_PROTO_NONE), .driver_info = (unsigned long)&wwan_info, +}, { + /* Cinterion PLS62-W modem by GEMALTO/THALES */ + USB_DEVICE_AND_INTERFACE_INFO(0x1e2d, 0x005b, USB_CLASS_COMM, + USB_CDC_SUBCLASS_ETHERNET, + USB_CDC_PROTO_NONE), + .driver_info = (unsigned long)&wwan_info, }, { /* Cinterion PLS83/PLS63 modem by GEMALTO/THALES */ USB_DEVICE_AND_INTERFACE_INFO(0x1e2d, 0x0069, USB_CLASS_COMM,
This modem has 7 interfaces, 5 of them are serial interfaces and are driven by cdc_acm, while 2 of them are wwan interfaces and are driven by cdc_ether: If 0: Abstract (modem) If 1: Abstract (modem) If 2: Abstract (modem) If 3: Abstract (modem) If 4: Abstract (modem) If 5: Ethernet Networking If 6: Ethernet Networking Without this change, the 2 network interfaces will be named to usb0 and usb1, our QA think the names are confusing and filed a bug on it. After applying this change, the name will be wwan0 and wwan1, and they could work well with modem manager. Signed-off-by: Hui Wang <hui.wang@canonical.com> --- drivers/net/usb/cdc_ether.c | 6 ++++++ 1 file changed, 6 insertions(+)