| Message ID | 20221205174459.60195-1-conor@kernel.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | riscv,isa fixups | expand |
On Mon, 05 Dec 2022 09:44:58 PST (-0800), Conor Dooley wrote: > From: Conor Dooley <conor.dooley@microchip.com> > > I noticed ~today~ while looking at the isa manual that I had not > accounted for another couple of edge cases with my regex. As before, I > think attempting to validate the canonical order for multiletter stuff > makes no sense - but we should totally try to avoid false-positives for > combinations that are known to be valid. > > All I've changed for v2 was collecting tags & adding in the missing > commit reference that Heiko pointed out. > > v3 fixes an issue Jess spotted - it's *any* multi-letter extension that > can come immediately after the single-letter ones, not just ones > starting with Z. > > @Palmer, either you can take this once the DT folks have ACKed it if you > like, or I will take onto some v6.2-rcN fixes branch. I don't think that > there is any urgency :) Sorry I missed these. Reviewed-by: Palmer Dabbelt <palmer@rivosinc.com> Acked-by: Palmer Dabbelt <palmer@rivosinc.com> We can just do a shared tag if you have stuff that depends on them? That'll let me keep fixes clean, as I'm running the DT stuff too now. Though maybe it doesn't matter so much because I'm not really taking any DT stuff. > Thanks, > Conor. > > CC: Jessica Clarke <jrtc27@jrtc27.com> > CC: Conor Dooley <conor@kernel.org> > CC: Rob Herring <robh+dt@kernel.org> > CC: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> > CC: Paul Walmsley <paul.walmsley@sifive.com> > CC: Palmer Dabbelt <palmer@dabbelt.com> > CC: Albert Ou <aou@eecs.berkeley.edu> > CC: Heiko Stuebner <heiko@sntech.de> > CC: Andrew Jones <ajones@ventanamicro.com> > CC: Guo Ren <guoren@kernel.org> > CC: linux-riscv@lists.infradead.org > CC: devicetree@vger.kernel.org > CC: linux-kernel@vger.kernel.org > > Conor Dooley (2): > dt-bindings: riscv: fix underscore requirement for multi-letter > extensions > dt-bindings: riscv: fix single letter canonical order > > Documentation/devicetree/bindings/riscv/cpus.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)
On Fri, Jan 06, 2023 at 10:27:48AM -0800, Palmer Dabbelt wrote: > On Mon, 05 Dec 2022 09:44:58 PST (-0800), Conor Dooley wrote: > > From: Conor Dooley <conor.dooley@microchip.com> > > > > I noticed ~today~ while looking at the isa manual that I had not > > accounted for another couple of edge cases with my regex. As before, I > > think attempting to validate the canonical order for multiletter stuff > > makes no sense - but we should totally try to avoid false-positives for > > combinations that are known to be valid. > > > > All I've changed for v2 was collecting tags & adding in the missing > > commit reference that Heiko pointed out. > > > > v3 fixes an issue Jess spotted - it's *any* multi-letter extension that > > can come immediately after the single-letter ones, not just ones > > starting with Z. > > > > @Palmer, either you can take this once the DT folks have ACKed it if you > > like, or I will take onto some v6.2-rcN fixes branch. I don't think that > > there is any urgency :) > > Sorry I missed these. > > Reviewed-by: Palmer Dabbelt <palmer@rivosinc.com> > Acked-by: Palmer Dabbelt <palmer@rivosinc.com> > > We can just do a shared tag if you have stuff that depends on them? That'll > let me keep fixes clean, as I'm running the DT stuff too now. Though maybe > it doesn't matter so much because I'm not really taking any DT stuff. Nah, shared tag is not needed. Noone's got a DT with multiletter stuff that needs to be merged yet. Feel free to take on on fixes or for-next. Thanks, Conor.
Hello: This series was applied to riscv/linux.git (fixes) by Palmer Dabbelt <palmer@rivosinc.com>: On Mon, 5 Dec 2022 17:44:58 +0000 you wrote: > From: Conor Dooley <conor.dooley@microchip.com> > > I noticed ~today~ while looking at the isa manual that I had not > accounted for another couple of edge cases with my regex. As before, I > think attempting to validate the canonical order for multiletter stuff > makes no sense - but we should totally try to avoid false-positives for > combinations that are known to be valid. > > [...] Here is the summary with links: - [v3,1/2] dt-bindings: riscv: fix underscore requirement for multi-letter extensions https://git.kernel.org/riscv/c/ec64efc4966e - [v3,2/2] dt-bindings: riscv: fix single letter canonical order https://git.kernel.org/riscv/c/a943385aa801 You are awesome, thank you!
From: Conor Dooley <conor.dooley@microchip.com> I noticed ~today~ while looking at the isa manual that I had not accounted for another couple of edge cases with my regex. As before, I think attempting to validate the canonical order for multiletter stuff makes no sense - but we should totally try to avoid false-positives for combinations that are known to be valid. All I've changed for v2 was collecting tags & adding in the missing commit reference that Heiko pointed out. v3 fixes an issue Jess spotted - it's *any* multi-letter extension that can come immediately after the single-letter ones, not just ones starting with Z. @Palmer, either you can take this once the DT folks have ACKed it if you like, or I will take onto some v6.2-rcN fixes branch. I don't think that there is any urgency :) Thanks, Conor. CC: Jessica Clarke <jrtc27@jrtc27.com> CC: Conor Dooley <conor@kernel.org> CC: Rob Herring <robh+dt@kernel.org> CC: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> CC: Paul Walmsley <paul.walmsley@sifive.com> CC: Palmer Dabbelt <palmer@dabbelt.com> CC: Albert Ou <aou@eecs.berkeley.edu> CC: Heiko Stuebner <heiko@sntech.de> CC: Andrew Jones <ajones@ventanamicro.com> CC: Guo Ren <guoren@kernel.org> CC: linux-riscv@lists.infradead.org CC: devicetree@vger.kernel.org CC: linux-kernel@vger.kernel.org Conor Dooley (2): dt-bindings: riscv: fix underscore requirement for multi-letter extensions dt-bindings: riscv: fix single letter canonical order Documentation/devicetree/bindings/riscv/cpus.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)