mbox series

[RFC,liburing,v1,0/2] Always enable CONFIG_NOLIBC if supported and deprecate --nolibc option

Message ID 20230106155202.558533-1-ammar.faizi@intel.com (mailing list archive)
Headers show
Series Always enable CONFIG_NOLIBC if supported and deprecate --nolibc option | expand

Message

Ammar Faizi Jan. 6, 2023, 3:52 p.m. UTC 
From: Ammar Faizi <ammarfaizi2@gnuweeb.org>

Hi Jens,

This is an RFC patchset. It's already build-tested.

Currently, the default liburing compilation uses libc as its dependency.
liburing doesn't depend on libc when it's compiled on x86-64, x86
(32-bit), and aarch64. There is no benefit to having libc.so linked to
liburing.so on those architectures.

Always enable CONFIG_NOLBIC if the arch is supported. If the
architecture is not supported, fallback to libc.

There are 2 patches in this series:

   - A preparation patch, remove --nolibc from the GitHub CI.

   - Always enable CONFIG_NOLIBC if supported and deprecate --nolibc.

After this series, --nolibc option is deprecated and has no effect.
I plan to remove this option in a future liburing release.

Comments welcome...

Signed-off-by: Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>
Signed-off-by: Ammar Faizi <ammarfaizi2@gnuweeb.org>
---

Alviro Iskandar Setiawan (1):
  configure: Always enable `CONFIG_NOLIBC` if the arch is supported

Ammar Faizi (1):
  github: Remove nolibc build on the GitHub CI bot

 .github/workflows/build.yml | 10 ----------
 configure                   | 40 ++++++++++++++++++++++++++++++++-----
 2 files changed, 35 insertions(+), 15 deletions(-)


base-commit: c76d392035fd271980faa297334268f2cd77d774

Comments

Jens Axboe Jan. 6, 2023, 10:39 p.m. UTC | #1 
On Fri, 06 Jan 2023 22:52:00 +0700, Ammar Faizi wrote:
> This is an RFC patchset. It's already build-tested.
> 
> Currently, the default liburing compilation uses libc as its dependency.
> liburing doesn't depend on libc when it's compiled on x86-64, x86
> (32-bit), and aarch64. There is no benefit to having libc.so linked to
> liburing.so on those architectures.
> 
> [...]

Applied, thanks!

[1/2] github: Remove nolibc build on the GitHub CI bot
      commit: 439cff00aa9a3b8bc6b88787ffca90d32655ce2f
[2/2] configure: Always enable `CONFIG_NOLIBC` if the arch is supported
      commit: bfb432f4cce52cb3e3bd9c1823e94ff29bd4fb80

Best regards,