diff mbox series

[1/6] dt-bindings: display/msm: document the SM8550 DSI PHY

Message ID 20230103-topic-sm8550-upstream-mdss-dsi-v1-1-9ccd7e652fcd@linaro.org (mailing list archive)
State New, archived
Headers show
Series drm/msm: add support for SM8450 | expand

Commit Message

Neil Armstrong Jan. 4, 2023, 9:08 a.m. UTC
Document the SM8550 DSI PHY which is very close from the 7nm
and 5nm DSI PHYs found in earlier platforms.

Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
 Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml | 1 +
 1 file changed, 1 insertion(+)

Comments

Krzysztof Kozlowski Jan. 6, 2023, 3:41 p.m. UTC | #1
On 04/01/2023 10:08, Neil Armstrong wrote:
> Document the SM8550 DSI PHY which is very close from the 7nm
> and 5nm DSI PHYs found in earlier platforms.
> 
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
>  Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml b/Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml
> index bffd161fedfd..f72727f81076 100644
> --- a/Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml
> @@ -15,6 +15,7 @@ allOf:
>  properties:
>    compatible:
>      enum:
> +      - qcom,dsi-phy-4nm-8550
>        - qcom,dsi-phy-5nm-8350
>        - qcom,dsi-phy-5nm-8450

Poor patterns once allowed like to keep growing... I commented here:
https://lore.kernel.org/all/ccbb47e4-d780-0b1d-814e-27e86b6c369c@linaro.org/

so let's wait for response about other compatibles.

>        - qcom,dsi-phy-7nm
> 

Best regards,
Krzysztof
Dmitry Baryshkov Jan. 8, 2023, 11:09 p.m. UTC | #2
On 06/01/2023 17:41, Krzysztof Kozlowski wrote:
> On 04/01/2023 10:08, Neil Armstrong wrote:
>> Document the SM8550 DSI PHY which is very close from the 7nm
>> and 5nm DSI PHYs found in earlier platforms.
>>
>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
>> ---
>>   Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml b/Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml
>> index bffd161fedfd..f72727f81076 100644
>> --- a/Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml
>> +++ b/Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml
>> @@ -15,6 +15,7 @@ allOf:
>>   properties:
>>     compatible:
>>       enum:
>> +      - qcom,dsi-phy-4nm-8550
>>         - qcom,dsi-phy-5nm-8350
>>         - qcom,dsi-phy-5nm-8450
> 
> Poor patterns once allowed like to keep growing... I commented here:
> https://lore.kernel.org/all/ccbb47e4-d780-0b1d-814e-27e86b6c369c@linaro.org/
> 
> so let's wait for response about other compatibles.

I have fixed 8350 & 8450 while applying. Please rebase on top of 
msm-next-lumag-next with fixed compatibles.

Note: the DPU changes are not yet part of the msm-lumag-next.

> 
>>         - qcom,dsi-phy-7nm
>>
> 
> Best regards,
> Krzysztof
>
Neil Armstrong Jan. 9, 2023, 8:20 a.m. UTC | #3
On 09/01/2023 00:09, Dmitry Baryshkov wrote:
> On 06/01/2023 17:41, Krzysztof Kozlowski wrote:
>> On 04/01/2023 10:08, Neil Armstrong wrote:
>>> Document the SM8550 DSI PHY which is very close from the 7nm
>>> and 5nm DSI PHYs found in earlier platforms.
>>>
>>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
>>> ---
>>>   Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml | 1 +
>>>   1 file changed, 1 insertion(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml b/Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml
>>> index bffd161fedfd..f72727f81076 100644
>>> --- a/Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml
>>> +++ b/Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml
>>> @@ -15,6 +15,7 @@ allOf:
>>>   properties:
>>>     compatible:
>>>       enum:
>>> +      - qcom,dsi-phy-4nm-8550
>>>         - qcom,dsi-phy-5nm-8350
>>>         - qcom,dsi-phy-5nm-8450
>>
>> Poor patterns once allowed like to keep growing... I commented here:
>> https://lore.kernel.org/all/ccbb47e4-d780-0b1d-814e-27e86b6c369c@linaro.org/
>>
>> so let's wait for response about other compatibles.
> 
> I have fixed 8350 & 8450 while applying. Please rebase on top of msm-next-lumag-next with fixed compatibles.

Ack

Thanks,
Neil

> 
> Note: the DPU changes are not yet part of the msm-lumag-next.
> 
>>
>>>         - qcom,dsi-phy-7nm
>>>
>>
>> Best regards,
>> Krzysztof
>>
>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml b/Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml
index bffd161fedfd..f72727f81076 100644
--- a/Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml
+++ b/Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml
@@ -15,6 +15,7 @@  allOf:
 properties:
   compatible:
     enum:
+      - qcom,dsi-phy-4nm-8550
       - qcom,dsi-phy-5nm-8350
       - qcom,dsi-phy-5nm-8450
       - qcom,dsi-phy-7nm