| Message ID | 20221223073559.109760-1-b-kapoor@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v3] arm64: dts: ti: k3-j721s2: Add support for ADC nodes | expand |
On 23/12/22 13:05, Bhavya Kapoor wrote: > J721s2 has two instances of 8 channel ADCs in MCU domain. Add DT nodes > for 8 channel ADCs for J721s2 SoC. > > Signed-off-by: Bhavya Kapoor <b-kapoor@ti.com> > --- > > Changelog v2->v3: > - Added Newline at the end of files. > > .../dts/ti/k3-j721s2-common-proc-board.dts | 14 +++++++ > .../boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi | 42 ++++++++++++++++++- > 2 files changed, 55 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts > index a7aa6cf08acd..3bc4f28c809f 100644 > --- a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts > +++ b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts > @@ -309,3 +309,17 @@ &mcu_mcan1 { > pinctrl-0 = <&mcu_mcan1_pins_default>; > phys = <&transceiver2>; > }; > + > +&tscadc0 { > + status = "okay"; > + adc { > + ti,adc-channels = <0 1 2 3 4 5 6 7>; > + }; > +}; > + > +&tscadc1 { > + status = "okay"; > + adc { > + ti,adc-channels = <0 1 2 3 4 5 6 7>; > + }; > +}; > diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi > index 0af242aa9816..b99021927d2a 100644 > --- a/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi > @@ -306,4 +306,44 @@ cpts@3d000 { > ti,cpts-periodic-outputs = <2>; > }; > }; > -}; > + > + tscadc0: tscadc@40200000 { > + compatible = "ti,am3359-tscadc"; > + reg = <0x0 0x40200000 0x0 0x1000>; Following convention of the file, please use: reg = <0x00 0x40200000 0x00 0x1000>; > + interrupts = <GIC_SPI 860 IRQ_TYPE_LEVEL_HIGH>; > + power-domains = <&k3_pds 0 TI_SCI_PD_EXCLUSIVE>; > + clocks = <&k3_clks 0 0>; > + assigned-clocks = <&k3_clks 0 2>; > + assigned-clock-rates = <60000000>; > + clock-names = "adc_tsc_fck"; Documentation/devicetree/bindings/mfd/ti,am3359-tscadc.yaml -> clock-names = "fck" +/workdir/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dtb: tscadc@40200000: clock-names:0: 'fck' was expected make dtbs_check will warn you > + dmas = <&main_udmap 0x7400>, > + <&main_udmap 0x7401>; > + dma-names = "fifo0", "fifo1"; > + status = "disabled"; > + > + adc { > + #io-channel-cells = <1>; > + compatible = "ti,am3359-adc"; > + }; > + }; > + > + tscadc1: tscadc@40210000 { > + compatible = "ti,am3359-tscadc"; > + reg = <0x0 0x40210000 0x0 0x1000>; Same here > + interrupts = <GIC_SPI 861 IRQ_TYPE_LEVEL_HIGH>; > + power-domains = <&k3_pds 1 TI_SCI_PD_EXCLUSIVE>; > + clocks = <&k3_clks 1 0>; > + assigned-clocks = <&k3_clks 1 2>; > + assigned-clock-rates = <60000000>; > + clock-names = "adc_tsc_fck"; +/workdir/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dtb: tscadc@40210000: clock-names:0: 'fck' was expected > + dmas = <&main_udmap 0x7402>, > + <&main_udmap 0x7403>; > + dma-names = "fifo0", "fifo1"; > + status = "disabled"; > + > + adc { > + #io-channel-cells = <1>; > + compatible = "ti,am3359-adc"; > + }; > + }; > + }; WARNING: please, no spaces at the start of a line #87: FILE: arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi:349: + };$ Please run ./scripts/checkpatch.pl --strict and fix all the issues before sending out the patches
diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts index a7aa6cf08acd..3bc4f28c809f 100644 --- a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts +++ b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts @@ -309,3 +309,17 @@ &mcu_mcan1 { pinctrl-0 = <&mcu_mcan1_pins_default>; phys = <&transceiver2>; }; + +&tscadc0 { + status = "okay"; + adc { + ti,adc-channels = <0 1 2 3 4 5 6 7>; + }; +}; + +&tscadc1 { + status = "okay"; + adc { + ti,adc-channels = <0 1 2 3 4 5 6 7>; + }; +}; diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi index 0af242aa9816..b99021927d2a 100644 --- a/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi +++ b/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi @@ -306,4 +306,44 @@ cpts@3d000 { ti,cpts-periodic-outputs = <2>; }; }; -}; + + tscadc0: tscadc@40200000 { + compatible = "ti,am3359-tscadc"; + reg = <0x0 0x40200000 0x0 0x1000>; + interrupts = <GIC_SPI 860 IRQ_TYPE_LEVEL_HIGH>; + power-domains = <&k3_pds 0 TI_SCI_PD_EXCLUSIVE>; + clocks = <&k3_clks 0 0>; + assigned-clocks = <&k3_clks 0 2>; + assigned-clock-rates = <60000000>; + clock-names = "adc_tsc_fck"; + dmas = <&main_udmap 0x7400>, + <&main_udmap 0x7401>; + dma-names = "fifo0", "fifo1"; + status = "disabled"; + + adc { + #io-channel-cells = <1>; + compatible = "ti,am3359-adc"; + }; + }; + + tscadc1: tscadc@40210000 { + compatible = "ti,am3359-tscadc"; + reg = <0x0 0x40210000 0x0 0x1000>; + interrupts = <GIC_SPI 861 IRQ_TYPE_LEVEL_HIGH>; + power-domains = <&k3_pds 1 TI_SCI_PD_EXCLUSIVE>; + clocks = <&k3_clks 1 0>; + assigned-clocks = <&k3_clks 1 2>; + assigned-clock-rates = <60000000>; + clock-names = "adc_tsc_fck"; + dmas = <&main_udmap 0x7402>, + <&main_udmap 0x7403>; + dma-names = "fifo0", "fifo1"; + status = "disabled"; + + adc { + #io-channel-cells = <1>; + compatible = "ti,am3359-adc"; + }; + }; + };
J721s2 has two instances of 8 channel ADCs in MCU domain. Add DT nodes for 8 channel ADCs for J721s2 SoC. Signed-off-by: Bhavya Kapoor <b-kapoor@ti.com> --- Changelog v2->v3: - Added Newline at the end of files. .../dts/ti/k3-j721s2-common-proc-board.dts | 14 +++++++ .../boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi | 42 ++++++++++++++++++- 2 files changed, 55 insertions(+), 1 deletion(-)