| Message ID | 20230106160739.100708-1-bjorn@mork.no (mailing list archive) |
|---|---|
| Headers | show |
| Series | r8152: allow firmwares with NCM support | expand |
Hello: This series was applied to netdev/net-next.git (master) by David S. Miller <davem@davemloft.net>: On Fri, 6 Jan 2023 17:07:37 +0100 you wrote: > Some device and firmware combinations with NCM support will > end up using the cdc_ncm driver by default. This is sub- > optimal for the same reasons we've previously accepted the > blacklist hack in cdc_ether. > > The recent support for subclassing the generic USB device > driver allows us to create a very slim driver with the same > functionality. This patch set uses that to implement a > device specific configuration default which is independent > of any USB interface drivers. This means that it works > equally whether the device initially ends up in NCM or ECM > mode, without depending on any code in the respective class > drivers. > > [...] Here is the summary with links: - [1/2] r8152: add USB device driver for config selection https://git.kernel.org/netdev/net-next/c/ec51fbd1b8a2 - [2/2] cdc_ether: no need to blacklist any r8152 devices https://git.kernel.org/netdev/net-next/c/69649ef84053 You are awesome, thank you!
Hi everyone,
Can we have this series backported to all applicable stable kernels?
+and future fixes:
commit 0d4cda805a18 ("r8152: avoid to change cfg for all devices")
commit 95a4c1d617b9 ("r8152: remove rtl_vendor_mode function")
RTL8156 (2.5Gbe) is supported by r8152, but wasn't blacklisted in
cdc_ether.c due to having a different product ID (0x8156).
Some RTL8156 users are stuck with using the cdc_ncm driver prior to this
patch series, which results in a far less ideal experience [1].
As we (finally) have a proper fix implemented thanks to Bjørn, it seems
to make more than enough sense to backport this to stable kernels.
I'm personally running v6.1 with this applied.
Thanks, regards
[1]
https://lore.kernel.org/netdev/CAO3ALPzKEStzf5-mgSLJ_jsCSbRq_2JzZ6de2rXuETV5RC-V8w@mail.gmail.com/
On 1/7/23 01:07, Bjørn Mork wrote:
> Some device and firmware combinations with NCM support will
> end up using the cdc_ncm driver by default. This is sub-
> optimal for the same reasons we've previously accepted the
> blacklist hack in cdc_ether.
>
> The recent support for subclassing the generic USB device
> driver allows us to create a very slim driver with the same
> functionality. This patch set uses that to implement a
> device specific configuration default which is independent
> of any USB interface drivers. This means that it works
> equally whether the device initially ends up in NCM or ECM
> mode, without depending on any code in the respective class
> drivers.
>
> Bjørn Mork (2):
> r8152: add USB device driver for config selection
> cdc_ether: no need to blacklist any r8152 devices
>
> drivers/net/usb/cdc_ether.c | 114 ------------------------------------
> drivers/net/usb/r8152.c | 113 +++++++++++++++++++++++++----------
> 2 files changed, 81 insertions(+), 146 deletions(-)
>
On Sat, Mar 04, 2023 at 07:00:05PM +0900, Juhyung Park wrote: > Hi everyone, > > Can we have this series backported to all applicable stable kernels? > +and future fixes: > commit 0d4cda805a18 ("r8152: avoid to change cfg for all devices") > commit 95a4c1d617b9 ("r8152: remove rtl_vendor_mode function") These do not apply to 6.2.y at all, please submit a tested and working series for us to apply if you wish to see them in any stable kernel tree. thanks, greg k-h