| Message ID | 20230109082514.50747-1-arend.vanspriel@broadcom.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | scripts: rpm: make clear that mkspec script contains 4.13 feature | expand |
Hi. Thanks for catching this. On Mon, Jan 9, 2023 at 5:25 PM Arend van Spriel <arend.vanspriel@broadcom.com> wrote: > > A fix was made in the mkspec script [1] that uses a feature, ie. the > OR expression, which requires RPM 4.13. However, the script indicates > another minimum version. Lower versions may have success by using > the --no-deps option as suggested, As far as I tested, CentOS 7 did not work with --no-deps solution. It just ended up with a syntax error. > but feels like bumping the version > to 4.13 is reasonable as it put me on the wrong track at first with > RPM 4.11 on my Centos7 machine. > > [1] https://lore.kernel.org/linux-kbuild/20221228191014.659746-1-masahiroy@kernel.org/ This is already merged. Please use Commit 02a893bc9975 ("kbuild: rpm-pkg: add libelf-devel as alternative for BuildRequires") instead of the URL. > > Signed-off-by: Arend van Spriel <arend.vanspriel@broadcom.com> > --- > scripts/package/mkspec | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/package/mkspec b/scripts/package/mkspec > index adab28fa7f89..094e52c979a8 100755 > --- a/scripts/package/mkspec > +++ b/scripts/package/mkspec > @@ -1,7 +1,7 @@ > #!/bin/sh > # > # Output a simple RPM spec file. > -# This version assumes a minimum of RPM 4.0.3. > +# This version assumes a minimum of RPM 4.13 > # > # The only gothic bit here is redefining install_post to avoid > # stripping the symbols from files in the kernel which we want > -- > 2.32.0 >
n 1/9/2023 11:21 AM, Masahiro Yamada wrote: > Hi. > Thanks for catching this. > > > On Mon, Jan 9, 2023 at 5:25 PM Arend van Spriel > <arend.vanspriel@broadcom.com> wrote: >> >> A fix was made in the mkspec script [1] that uses a feature, ie. the >> OR expression, which requires RPM 4.13. However, the script indicates >> another minimum version. Lower versions may have success by using >> the --no-deps option as suggested, > > > As far as I tested, CentOS 7 did not work with --no-deps solution. > It just ended up with a syntax error. > > > > > >> but feels like bumping the version >> to 4.13 is reasonable as it put me on the wrong track at first with >> RPM 4.11 on my Centos7 machine. >> >> [1] https://lore.kernel.org/linux-kbuild/20221228191014.659746-1-masahiroy@kernel.org/ > > > This is already merged. > > Please use > > Commit 02a893bc9975 ("kbuild: rpm-pkg: add libelf-devel as alternative > for BuildRequires") > > instead of the URL. So do you want me to resend the patch? Regards, Arend
On Mon, Jan 9, 2023 at 9:42 PM Arend van Spriel <arend.vanspriel@broadcom.com> wrote: > > n 1/9/2023 11:21 AM, Masahiro Yamada wrote: > > Hi. > > Thanks for catching this. > > > > > > On Mon, Jan 9, 2023 at 5:25 PM Arend van Spriel > > <arend.vanspriel@broadcom.com> wrote: > >> > >> A fix was made in the mkspec script [1] that uses a feature, ie. the > >> OR expression, which requires RPM 4.13. However, the script indicates > >> another minimum version. Lower versions may have success by using > >> the --no-deps option as suggested, > > > > > > As far as I tested, CentOS 7 did not work with --no-deps solution. > > It just ended up with a syntax error. > > > > > > > > > > > >> but feels like bumping the version > >> to 4.13 is reasonable as it put me on the wrong track at first with > >> RPM 4.11 on my Centos7 machine. > >> > >> [1] https://lore.kernel.org/linux-kbuild/20221228191014.659746-1-masahiroy@kernel.org/ > > > > > > This is already merged. > > > > Please use > > > > Commit 02a893bc9975 ("kbuild: rpm-pkg: add libelf-devel as alternative > > for BuildRequires") > > > > instead of the URL. > > So do you want me to resend the patch? > > Regards, > Arend Yes, please resend the patch with updated description.
diff --git a/scripts/package/mkspec b/scripts/package/mkspec index adab28fa7f89..094e52c979a8 100755 --- a/scripts/package/mkspec +++ b/scripts/package/mkspec @@ -1,7 +1,7 @@ #!/bin/sh # # Output a simple RPM spec file. -# This version assumes a minimum of RPM 4.0.3. +# This version assumes a minimum of RPM 4.13 # # The only gothic bit here is redefining install_post to avoid # stripping the symbols from files in the kernel which we want
A fix was made in the mkspec script [1] that uses a feature, ie. the OR expression, which requires RPM 4.13. However, the script indicates another minimum version. Lower versions may have success by using the --no-deps option as suggested, but feels like bumping the version to 4.13 is reasonable as it put me on the wrong track at first with RPM 4.11 on my Centos7 machine. [1] https://lore.kernel.org/linux-kbuild/20221228191014.659746-1-masahiroy@kernel.org/ Signed-off-by: Arend van Spriel <arend.vanspriel@broadcom.com> --- scripts/package/mkspec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)