mbox series

[0/2] ASoC: fsl: Fix fsl-asoc-card AC'97 support

Message ID 20230106-asoc-udoo-probe-v1-0-a5d7469d4f67@kernel.org (mailing list archive)
Headers show
Series ASoC: fsl: Fix fsl-asoc-card AC'97 support | expand

Message

Mark Brown Jan. 6, 2023, 11:15 p.m. UTC
The generic driver for Freescale cards with ASRC does not so far as I
can tell work for AC'97 cards, it's certainly not working for the two
Udoo boards I have that use it and I'm not clear how it ever worked.
These patches fix the card well enough to probe and make it through
pcm-test for playback at standard rates, though there are still issues
with capture and some playback configurations getting confused about
constraints.

To: Shengjiu Wang <shengjiu.wang@gmail.com>
To: Xiubo Li <Xiubo.Lee@gmail.com>
To: Fabio Estevam <festevam@gmail.com>
To: Nicolin Chen <nicoleotsuka@gmail.com>
To: Liam Girdwood <lgirdwood@gmail.com>
Cc: alsa-devel@alsa-project.org
Cc: linux-arm-kernel@lists.infradead.org
Signed-off-by: Mark Brown <broonie@kernel.org>

---
Mark Brown (2):
      ASoC: fsl_ssi: Rename AC'97 streams to avoid collisions with AC'97 CODEC
      ASoC: fsl-asoc-card: Fix naming of AC'97 CODEC widgets

 sound/soc/fsl/fsl-asoc-card.c | 8 ++++----
 sound/soc/fsl/fsl_ssi.c       | 4 ++--
 2 files changed, 6 insertions(+), 6 deletions(-)
---
base-commit: 1b929c02afd37871d5afb9d498426f83432e71c2
change-id: 20230106-asoc-udoo-probe-54daa107cbcb

Best regards,

Comments

Shengjiu Wang Jan. 10, 2023, 5:24 a.m. UTC | #1
On Sat, Jan 7, 2023 at 7:16 AM Mark Brown <broonie@kernel.org> wrote:

> The generic driver for Freescale cards with ASRC does not so far as I
> can tell work for AC'97 cards, it's certainly not working for the two
> Udoo boards I have that use it and I'm not clear how it ever worked.
> These patches fix the card well enough to probe and make it through
> pcm-test for playback at standard rates, though there are still issues
> with capture and some playback configurations getting confused about
> constraints.
>
> To: Shengjiu Wang <shengjiu.wang@gmail.com>
> To: Xiubo Li <Xiubo.Lee@gmail.com>
> To: Fabio Estevam <festevam@gmail.com>
> To: Nicolin Chen <nicoleotsuka@gmail.com>
> To: Liam Girdwood <lgirdwood@gmail.com>
> Cc: alsa-devel@alsa-project.org
> Cc: linux-arm-kernel@lists.infradead.org
> Signed-off-by: Mark Brown <broonie@kernel.org>
>

Acked-by: Shengjiu Wang <shengjiu.wang@gmail.com>

Best regards
Wang shengjiu

>
> ---
> Mark Brown (2):
>       ASoC: fsl_ssi: Rename AC'97 streams to avoid collisions with AC'97
> CODEC
>       ASoC: fsl-asoc-card: Fix naming of AC'97 CODEC widgets
>
>  sound/soc/fsl/fsl-asoc-card.c | 8 ++++----
>  sound/soc/fsl/fsl_ssi.c       | 4 ++--
>  2 files changed, 6 insertions(+), 6 deletions(-)
> ---
> base-commit: 1b929c02afd37871d5afb9d498426f83432e71c2
> change-id: 20230106-asoc-udoo-probe-54daa107cbcb
>
> Best regards,
> --
> Mark Brown <broonie@kernel.org>
>
Mark Brown Jan. 10, 2023, 2:17 p.m. UTC | #2
On Fri, 06 Jan 2023 23:15:06 +0000, Mark Brown wrote:
> The generic driver for Freescale cards with ASRC does not so far as I
> can tell work for AC'97 cards, it's certainly not working for the two
> Udoo boards I have that use it and I'm not clear how it ever worked.
> These patches fix the card well enough to probe and make it through
> pcm-test for playback at standard rates, though there are still issues
> with capture and some playback configurations getting confused about
> constraints.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/2] ASoC: fsl_ssi: Rename AC'97 streams to avoid collisions with AC'97 CODEC
      commit: 8c6a42b5b0ed6f96624f56954e93eeae107440a6
[2/2] ASoC: fsl-asoc-card: Fix naming of AC'97 CODEC widgets
      commit: 242fc66ae6e1e2b8519daacc7590a73cd0e8a6e4

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark