| Message ID | 20221227080443.6273-2-nancy.lin@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add MediaTek SoC(vdosys1) support for mt8195 | expand |
On 27/12/2022 09:04, Nancy.Lin wrote: > Add vdosys1 mmsys compatible for MT8195 platform. > > For MT8195, VDOSYS0 and VDOSYS1 are 2 display HW pipelines binding to > 2 different power domains, different clock drivers and different > mediatek-drm drivers. > > Signed-off-by: Nancy.Lin <nancy.lin@mediatek.com> > Reviewed-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> > --- > .../devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml > index 0711f1834fbd..242ce5a69432 100644 > --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml > +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml > @@ -52,6 +52,10 @@ properties: > - const: mediatek,mt8195-mmsys > - const: syscon > > + - items: > + - const: mediatek,mt8195-vdosys1 This should be part of first enum. Don't create redundant entries. Best regards, Krzysztof
Dear Krzysztof, Thanks for the review. On Tue, 2023-01-10 at 11:50 +0100, Krzysztof Kozlowski wrote: > On 27/12/2022 09:04, Nancy.Lin wrote: > > Add vdosys1 mmsys compatible for MT8195 platform. > > > > For MT8195, VDOSYS0 and VDOSYS1 are 2 display HW pipelines binding > > to > > 2 different power domains, different clock drivers and different > > mediatek-drm drivers. > > > > Signed-off-by: Nancy.Lin <nancy.lin@mediatek.com> > > Reviewed-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> > > --- > > .../devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml | 4 > > ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git > > a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yam > > l > > b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yam > > l > > index 0711f1834fbd..242ce5a69432 100644 > > --- > > a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yam > > l > > +++ > > b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yam > > l > > @@ -52,6 +52,10 @@ properties: > > - const: mediatek,mt8195-mmsys > > - const: syscon > > > > + - items: > > + - const: mediatek,mt8195-vdosys1 > > This should be part of first enum. Don't create redundant entries. > > Best regards, > Krzysztof OK, I will modify as following: @@ -33,6 +33,7 @@ properties: - mediatek,mt8186-mmsys - mediatek,mt8188-vdosys0 - mediatek,mt8192-mmsys + - mediatek,mt8195-vdosys1 - mediatek,mt8365-mmsys - const: syscon Best, Nancy >
diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml index 0711f1834fbd..242ce5a69432 100644 --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml @@ -52,6 +52,10 @@ properties: - const: mediatek,mt8195-mmsys - const: syscon + - items: + - const: mediatek,mt8195-vdosys1 + - const: syscon + reg: maxItems: 1