| Message ID | 20230110151854.50746-1-anthony.perard@citrix.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [XEN] tools: Fix build with recent QEMU, use "--enable-trace-backends" | expand |
On Tue, Jan 10, 2023 at 10:25 AM Anthony PERARD <anthony.perard@citrix.com> wrote: > > The configure option "--enable-trace-backend" isn't accepted anymore > and we should use "--enable-trace-backends" instead which was > introduce in 2014 and allow multiple backends. > > "--enable-trace-backends" was introduced by: > 5b808275f3bb ("trace: Multi-backend tracing") > The backward compatible option "--enable-trace-backend" is removed by > 10229ec3b0ff ("configure: remove backwards-compatibility and obsolete options") > > As we already use ./configure options that wouldn't be accepted by > older version of QEMU's configure, we will simply use the new spelling > for the option and avoid trying to detect which spelling to use. > > We already make use if "--firmwarepath=" which was introduced by > 3d5eecab4a5a ("Add --firmwarepath to configure") > which already include the new spelling for "--enable-trace-backends". > > Signed-off-by: Anthony PERARD <anthony.perard@citrix.com> Reviewed-by: Jason Andryuk <jandryuk@gmail.com> Thanks, Jason
On 10.01.2023 16:18, Anthony PERARD wrote: > The configure option "--enable-trace-backend" isn't accepted anymore > and we should use "--enable-trace-backends" instead which was > introduce in 2014 and allow multiple backends. > > "--enable-trace-backends" was introduced by: > 5b808275f3bb ("trace: Multi-backend tracing") > The backward compatible option "--enable-trace-backend" is removed by > 10229ec3b0ff ("configure: remove backwards-compatibility and obsolete options") > > As we already use ./configure options that wouldn't be accepted by > older version of QEMU's configure, we will simply use the new spelling > for the option and avoid trying to detect which spelling to use. > > We already make use if "--firmwarepath=" which was introduced by > 3d5eecab4a5a ("Add --firmwarepath to configure") > which already include the new spelling for "--enable-trace-backends". > > Signed-off-by: Anthony PERARD <anthony.perard@citrix.com> I've committed this, and I'll queue this for backporting unless you (or anyone else) tell(s) me otherwise. Jan
diff --git a/tools/Makefile b/tools/Makefile index 9e28027835..4906fdbc23 100644 --- a/tools/Makefile +++ b/tools/Makefile @@ -218,9 +218,9 @@ subdir-all-qemu-xen-dir: qemu-xen-dir-find mkdir -p qemu-xen-build; \ cd qemu-xen-build; \ if $$source/scripts/tracetool.py --check-backend --backend log ; then \ - enable_trace_backend='--enable-trace-backend=log'; \ + enable_trace_backend="--enable-trace-backends=log"; \ elif $$source/scripts/tracetool.py --check-backend --backend stderr ; then \ - enable_trace_backend='--enable-trace-backend=stderr'; \ + enable_trace_backend='--enable-trace-backends=stderr'; \ else \ enable_trace_backend='' ; \ fi ; \
The configure option "--enable-trace-backend" isn't accepted anymore and we should use "--enable-trace-backends" instead which was introduce in 2014 and allow multiple backends. "--enable-trace-backends" was introduced by: 5b808275f3bb ("trace: Multi-backend tracing") The backward compatible option "--enable-trace-backend" is removed by 10229ec3b0ff ("configure: remove backwards-compatibility and obsolete options") As we already use ./configure options that wouldn't be accepted by older version of QEMU's configure, we will simply use the new spelling for the option and avoid trying to detect which spelling to use. We already make use if "--firmwarepath=" which was introduced by 3d5eecab4a5a ("Add --firmwarepath to configure") which already include the new spelling for "--enable-trace-backends". Signed-off-by: Anthony PERARD <anthony.perard@citrix.com> --- tools/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)