| Message ID | 20230111020546.3384569-3-pmalani@chromium.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 85af23df903ee14bfcba60c53e4f3b640f2310f8 |
| Headers | show |
| Series | [1/3] usb: typec: altmodes/displayport: Add pin assignment helper | expand |
On Wed, Jan 11, 2023 at 02:05:43AM +0000, Prashant Malani wrote: > While looking at the DP configuration VDO to determine the peripheral > configuration, the spec (Table 8-5: DisplayPort Configurations, VESA > DisplayPort Alt Mode Standard v2.0) lists the options as "UFP_U as a DP > Source/Sink Device". > > So, use the correct macro while performing this check. Effectively it's > the same as the existing code, but the proposed macro describes the > state a little better. > > No functional changes introduced. > > Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com> > Signed-off-by: Prashant Malani <pmalani@chromium.org> Reviewed-by: Benson Leung <bleung@chromium.org> > --- > drivers/usb/typec/altmodes/displayport.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/typec/altmodes/displayport.c b/drivers/usb/typec/altmodes/displayport.c > index c0d65c93cefe..746bfbf3d557 100644 > --- a/drivers/usb/typec/altmodes/displayport.c > +++ b/drivers/usb/typec/altmodes/displayport.c > @@ -426,7 +426,7 @@ static const char * const pin_assignments[] = { > */ > static u8 get_current_pin_assignments(struct dp_altmode *dp) > { > - if (DP_CONF_CURRENTLY(dp->data.conf) == DP_CONF_DFP_D) > + if (DP_CONF_CURRENTLY(dp->data.conf) == DP_CONF_UFP_U_AS_DFP_D) > return DP_CAP_PIN_ASSIGN_DFP_D(dp->alt->vdo); > else > return DP_CAP_PIN_ASSIGN_UFP_D(dp->alt->vdo); > -- > 2.39.0.314.g84b9a713c41-goog >
On Wed, Jan 11, 2023 at 02:05:43AM +0000, Prashant Malani wrote: > While looking at the DP configuration VDO to determine the peripheral > configuration, the spec (Table 8-5: DisplayPort Configurations, VESA > DisplayPort Alt Mode Standard v2.0) lists the options as "UFP_U as a DP > Source/Sink Device". > > So, use the correct macro while performing this check. Effectively it's > the same as the existing code, but the proposed macro describes the > state a little better. > > No functional changes introduced. > > Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com> > Signed-off-by: Prashant Malani <pmalani@chromium.org> Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> > --- > drivers/usb/typec/altmodes/displayport.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/typec/altmodes/displayport.c b/drivers/usb/typec/altmodes/displayport.c > index c0d65c93cefe..746bfbf3d557 100644 > --- a/drivers/usb/typec/altmodes/displayport.c > +++ b/drivers/usb/typec/altmodes/displayport.c > @@ -426,7 +426,7 @@ static const char * const pin_assignments[] = { > */ > static u8 get_current_pin_assignments(struct dp_altmode *dp) > { > - if (DP_CONF_CURRENTLY(dp->data.conf) == DP_CONF_DFP_D) > + if (DP_CONF_CURRENTLY(dp->data.conf) == DP_CONF_UFP_U_AS_DFP_D) > return DP_CAP_PIN_ASSIGN_DFP_D(dp->alt->vdo); > else > return DP_CAP_PIN_ASSIGN_UFP_D(dp->alt->vdo); > -- > 2.39.0.314.g84b9a713c41-goog
diff --git a/drivers/usb/typec/altmodes/displayport.c b/drivers/usb/typec/altmodes/displayport.c index c0d65c93cefe..746bfbf3d557 100644 --- a/drivers/usb/typec/altmodes/displayport.c +++ b/drivers/usb/typec/altmodes/displayport.c @@ -426,7 +426,7 @@ static const char * const pin_assignments[] = { */ static u8 get_current_pin_assignments(struct dp_altmode *dp) { - if (DP_CONF_CURRENTLY(dp->data.conf) == DP_CONF_DFP_D) + if (DP_CONF_CURRENTLY(dp->data.conf) == DP_CONF_UFP_U_AS_DFP_D) return DP_CAP_PIN_ASSIGN_DFP_D(dp->alt->vdo); else return DP_CAP_PIN_ASSIGN_UFP_D(dp->alt->vdo);
While looking at the DP configuration VDO to determine the peripheral configuration, the spec (Table 8-5: DisplayPort Configurations, VESA DisplayPort Alt Mode Standard v2.0) lists the options as "UFP_U as a DP Source/Sink Device". So, use the correct macro while performing this check. Effectively it's the same as the existing code, but the proposed macro describes the state a little better. No functional changes introduced. Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com> Signed-off-by: Prashant Malani <pmalani@chromium.org> --- drivers/usb/typec/altmodes/displayport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)