diff mbox series

[v2] dt-bindings: sound: tlv320aic3x: Add optional clock and port properties

Message ID 20221230132644.6398-1-j-luthra@ti.com (mailing list archive)
State Accepted
Commit b6e98cf4ed3baff0c2f7a1c1babf96fde8e129f3
Headers show
Series [v2] dt-bindings: sound: tlv320aic3x: Add optional clock and port properties | expand

Commit Message

Jai Luthra Dec. 30, 2022, 1:26 p.m. UTC
Describe optional properties for clocks and ports that were missing in
the original txt binding, to fix warnings like:

aic33@18: 'assigned-clock-parents', 'assigned-clock-rates',
	'assigned-clocks' do not match any of the regexes:
	'pinctrl-[0-9]+'
	arch/arm/boot/dts/omap2420-n810.dtb

tlv320aic3106@1b: 'port' does not match any of the regexes:
	'pinctrl-[0-9]+'
	arch/arm/boot/dts/am335x-sl50.dtb

codec@18: 'clocks' does not match any of the regexes: 'pinctrl-[0-9]+'
	arch/arm/boot/dts/imx6dl-gw5903.dtb
	arch/arm/boot/dts/imx6q-gw5903.dtb

Some uses of "port" still lead to warnings because they pass clocks in
the endpoint, but that is discouraged:
https://lore.kernel.org/all/20210205152644.GA3083322@robh.at.kernel.org/

Signed-off-by: Jai Luthra <j-luthra@ti.com>
---

Splitting this patch from v5 of the old series, as the base bindings in 
[1/2] were picked in broonie's tree

v2:
- Add maxItems to clocks
- Use audio-graph-port bindings

v1:
https://lore.kernel.org/all/20221227082717.29561-3-j-luthra@ti.com/

 .../devicetree/bindings/sound/ti,tlv320aic3x.yaml          | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Krzysztof Kozlowski Jan. 11, 2023, 10:41 a.m. UTC | #1
On 30/12/2022 14:26, Jai Luthra wrote:
> Describe optional properties for clocks and ports that were missing in
> the original txt binding, to fix warnings like:
> 
> aic33@18: 'assigned-clock-parents', 'assigned-clock-rates',
> 	'assigned-clocks' do not match any of the regexes:
> 	'pinctrl-[0-9]+'
> 	arch/arm/boot/dts/omap2420-n810.dtb
> 
> tlv320aic3106@1b: 'port' does not match any of the regexes:
> 	'pinctrl-[0-9]+'
> 	arch/arm/boot/dts/am335x-sl50.dtb
> 
> codec@18: 'clocks' does not match any of the regexes: 'pinctrl-[0-9]+'
> 	arch/arm/boot/dts/imx6dl-gw5903.dtb
> 	arch/arm/boot/dts/imx6q-gw5903.dtb
> 
> Some uses of "port" still lead to warnings because they pass clocks in
> the endpoint, but that is discouraged:
> https://lore.kernel.org/all/20210205152644.GA3083322@robh.at.kernel.org/
> 
> Signed-off-by: Jai Luthra <j-luthra@ti.com>
> ---
> 

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
Mark Brown Jan. 12, 2023, 3:12 p.m. UTC | #2
On Fri, 30 Dec 2022 18:56:44 +0530, Jai Luthra wrote:
> Describe optional properties for clocks and ports that were missing in
> the original txt binding, to fix warnings like:
> 
> aic33@18: 'assigned-clock-parents', 'assigned-clock-rates',
> 	'assigned-clocks' do not match any of the regexes:
> 	'pinctrl-[0-9]+'
> 	arch/arm/boot/dts/omap2420-n810.dtb
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] dt-bindings: sound: tlv320aic3x: Add optional clock and port properties
      commit: b6e98cf4ed3baff0c2f7a1c1babf96fde8e129f3

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark
Mark Brown Jan. 16, 2023, 1:15 p.m. UTC | #3
On Fri, 30 Dec 2022 18:56:44 +0530, Jai Luthra wrote:
> Describe optional properties for clocks and ports that were missing in
> the original txt binding, to fix warnings like:
> 
> aic33@18: 'assigned-clock-parents', 'assigned-clock-rates',
> 	'assigned-clocks' do not match any of the regexes:
> 	'pinctrl-[0-9]+'
> 	arch/arm/boot/dts/omap2420-n810.dtb
> 
> [...]

Applied to

   broonie/sound.git for-next

Thanks!

[1/1] dt-bindings: sound: tlv320aic3x: Add optional clock and port properties
      commit: b6e98cf4ed3baff0c2f7a1c1babf96fde8e129f3

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/sound/ti,tlv320aic3x.yaml b/Documentation/devicetree/bindings/sound/ti,tlv320aic3x.yaml
index f0375bbf4c40..e8ca9f3369f8 100644
--- a/Documentation/devicetree/bindings/sound/ti,tlv320aic3x.yaml
+++ b/Documentation/devicetree/bindings/sound/ti,tlv320aic3x.yaml
@@ -110,6 +110,13 @@  properties:
   '#sound-dai-cells':
     const: 0
 
+  clocks:
+    maxItems: 1
+
+  port:
+    $ref: audio-graph-port.yaml#
+    unevaluatedProperties: false
+
 required:
   - compatible
   - reg