| Message ID | 20230105214631.3939268-16-willy@infradead.org (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | Split netmem from struct page | expand |
On 05/01/2023 22.46, Matthew Wilcox (Oracle) wrote: > This wrapper is no longer used. > > Signed-off-by: Matthew Wilcox (Oracle)<willy@infradead.org> > --- > net/core/page_pool.c | 8 -------- > 1 file changed, 8 deletions(-) Acked-by: Jesper Dangaard Brouer <brouer@redhat.com>
On Thu, Jan 05, 2023 at 09:46:22PM +0000, Matthew Wilcox (Oracle) wrote: > This wrapper is no longer used. > > Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org> > --- > net/core/page_pool.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/net/core/page_pool.c b/net/core/page_pool.c > index b925a4dcb09b..c495e3a16e83 100644 > --- a/net/core/page_pool.c > +++ b/net/core/page_pool.c > @@ -607,14 +607,6 @@ __page_pool_put_netmem(struct page_pool *pool, struct netmem *nmem, > return NULL; > } > > -static __always_inline struct page * > -__page_pool_put_page(struct page_pool *pool, struct page *page, > - unsigned int dma_sync_size, bool allow_direct) > -{ > - return netmem_page(__page_pool_put_netmem(pool, page_netmem(page), > - dma_sync_size, allow_direct)); > -} > - > void page_pool_put_defragged_netmem(struct page_pool *pool, struct netmem *nmem, > unsigned int dma_sync_size, bool allow_direct) > { > -- > 2.35.1 > Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
On Tue, Jan 10, 2023 at 11:47:18AM +0200, Ilias Apalodimas wrote: > On Thu, Jan 05, 2023 at 09:46:22PM +0000, Matthew Wilcox (Oracle) wrote: > > -__page_pool_put_page(struct page_pool *pool, struct page *page, > > - unsigned int dma_sync_size, bool allow_direct) Wow, neither of you noticed that the subject line mentioned the wrong function ;-) I'm taking your R-b and A-b tags anyway ;-)
On Wed, 11 Jan 2023 at 00:00, Matthew Wilcox <willy@infradead.org> wrote: > > On Tue, Jan 10, 2023 at 11:47:18AM +0200, Ilias Apalodimas wrote: > > On Thu, Jan 05, 2023 at 09:46:22PM +0000, Matthew Wilcox (Oracle) wrote: > > > -__page_pool_put_page(struct page_pool *pool, struct page *page, > > > - unsigned int dma_sync_size, bool allow_direct) > > Wow, neither of you noticed that the subject line mentioned the wrong > function ;-) I'm taking your R-b and A-b tags anyway ;-) Well, the patches add temporary placeholders of functions to ensure that none of the patches break the build. So when I was reviewing, I was immediately jumping to the equivalent patch that was removing the function later on and missed the commit log ...:) Cheers /Ilias
diff --git a/net/core/page_pool.c b/net/core/page_pool.c index b925a4dcb09b..c495e3a16e83 100644 --- a/net/core/page_pool.c +++ b/net/core/page_pool.c @@ -607,14 +607,6 @@ __page_pool_put_netmem(struct page_pool *pool, struct netmem *nmem, return NULL; } -static __always_inline struct page * -__page_pool_put_page(struct page_pool *pool, struct page *page, - unsigned int dma_sync_size, bool allow_direct) -{ - return netmem_page(__page_pool_put_netmem(pool, page_netmem(page), - dma_sync_size, allow_direct)); -} - void page_pool_put_defragged_netmem(struct page_pool *pool, struct netmem *nmem, unsigned int dma_sync_size, bool allow_direct) {
This wrapper is no longer used. Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org> --- net/core/page_pool.c | 8 -------- 1 file changed, 8 deletions(-)