diff mbox series

[08/27] ata: remove palmld pata driver

Message ID 20230105134622.254560-9-arnd@kernel.org (mailing list archive)
State New, archived
Headers show
Series [01/27] ARM: pxa: remove unused board files | expand

Commit Message

Arnd Bergmann Jan. 5, 2023, 1:46 p.m. UTC
From: Arnd Bergmann <arnd@arndb.de>

The PXA palmld machine was removed, so the pata driver is no
longer used and can be removed. There is a chance that some of
this code might be useful for turning some of the other PXA
PCMCIA host drivers into PATA drivers, but it's clear that
it would not work unmodified, and it seems unlikely that
someone would do this work.

Cc: Alessandro Zummo <a.zummo@towertech.it>
Cc: Marek Vasut <marek.vasut@gmail.com>
Cc: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Cc: Sergey Shtylyov <s.shtylyov@omp.ru>
Cc: linux-kernel@vger.kernel.org
Cc: linux-ide@vger.kernel.org
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/ata/Kconfig       |   9 ---
 drivers/ata/Makefile      |   1 -
 drivers/ata/pata_palmld.c | 137 --------------------------------------
 3 files changed, 147 deletions(-)
 delete mode 100644 drivers/ata/pata_palmld.c

Comments

Damien Le Moal Jan. 6, 2023, 6:25 a.m. UTC | #1
On 1/5/23 22:46, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> The PXA palmld machine was removed, so the pata driver is no
> longer used and can be removed. There is a chance that some of
> this code might be useful for turning some of the other PXA
> PCMCIA host drivers into PATA drivers, but it's clear that
> it would not work unmodified, and it seems unlikely that
> someone would do this work.
> 
> Cc: Alessandro Zummo <a.zummo@towertech.it>
> Cc: Marek Vasut <marek.vasut@gmail.com>
> Cc: Damien Le Moal <damien.lemoal@opensource.wdc.com>
> Cc: Sergey Shtylyov <s.shtylyov@omp.ru>
> Cc: linux-kernel@vger.kernel.org
> Cc: linux-ide@vger.kernel.org
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Acked-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>

Feel free to queue this through your tree. Thanks !

> ---
>  drivers/ata/Kconfig       |   9 ---
>  drivers/ata/Makefile      |   1 -
>  drivers/ata/pata_palmld.c | 137 --------------------------------------
>  3 files changed, 147 deletions(-)
>  delete mode 100644 drivers/ata/pata_palmld.c
> 
> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
> index e4d9e39b08dd..4aafb75bf0c3 100644
> --- a/drivers/ata/Kconfig
> +++ b/drivers/ata/Kconfig
> @@ -1082,15 +1082,6 @@ config PATA_OPTI
>  
>  	  If unsure, say N.
>  
> -config PATA_PALMLD
> -	tristate "Palm LifeDrive PATA support"
> -	depends on MACH_PALMLD
> -	help
> -	  This option enables support for Palm LifeDrive's internal ATA
> -	  port via the new ATA layer.
> -
> -	  If unsure, say N.
> -
>  config PATA_PCMCIA
>  	tristate "PCMCIA PATA support"
>  	depends on PCMCIA
> diff --git a/drivers/ata/Makefile b/drivers/ata/Makefile
> index 0a863e7f3c60..4ee5c0761d90 100644
> --- a/drivers/ata/Makefile
> +++ b/drivers/ata/Makefile
> @@ -105,7 +105,6 @@ obj-$(CONFIG_PATA_MPIIX)	+= pata_mpiix.o
>  obj-$(CONFIG_PATA_NS87410)	+= pata_ns87410.o
>  obj-$(CONFIG_PATA_OPTI)		+= pata_opti.o
>  obj-$(CONFIG_PATA_PCMCIA)	+= pata_pcmcia.o
> -obj-$(CONFIG_PATA_PALMLD)	+= pata_palmld.o
>  obj-$(CONFIG_PATA_PLATFORM)	+= pata_platform.o
>  obj-$(CONFIG_PATA_OF_PLATFORM)	+= pata_of_platform.o
>  obj-$(CONFIG_PATA_RB532)	+= pata_rb532_cf.o
> diff --git a/drivers/ata/pata_palmld.c b/drivers/ata/pata_palmld.c
> deleted file mode 100644
> index 51caa2a427dd..000000000000
Sergey Shtylyov Jan. 11, 2023, 5:37 p.m. UTC | #2
Hello!

On 1/5/23 4:46 PM, Arnd Bergmann wrote:

> From: Arnd Bergmann <arnd@arndb.de>
> 
> The PXA palmld machine was removed, so the pata driver is no
> longer used and can be removed. There is a chance that some of
> this code might be useful for turning some of the other PXA
> PCMCIA host drivers into PATA drivers, but it's clear that
> it would not work unmodified, and it seems unlikely that
> someone would do this work.
> 
> Cc: Alessandro Zummo <a.zummo@towertech.it>
> Cc: Marek Vasut <marek.vasut@gmail.com>
> Cc: Damien Le Moal <damien.lemoal@opensource.wdc.com>
> Cc: Sergey Shtylyov <s.shtylyov@omp.ru>
> Cc: linux-kernel@vger.kernel.org
> Cc: linux-ide@vger.kernel.org
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>

   Better late than never? :-)

[...]

MBR, Sergey
diff mbox series

Patch

diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index e4d9e39b08dd..4aafb75bf0c3 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -1082,15 +1082,6 @@  config PATA_OPTI
 
 	  If unsure, say N.
 
-config PATA_PALMLD
-	tristate "Palm LifeDrive PATA support"
-	depends on MACH_PALMLD
-	help
-	  This option enables support for Palm LifeDrive's internal ATA
-	  port via the new ATA layer.
-
-	  If unsure, say N.
-
 config PATA_PCMCIA
 	tristate "PCMCIA PATA support"
 	depends on PCMCIA
diff --git a/drivers/ata/Makefile b/drivers/ata/Makefile
index 0a863e7f3c60..4ee5c0761d90 100644
--- a/drivers/ata/Makefile
+++ b/drivers/ata/Makefile
@@ -105,7 +105,6 @@  obj-$(CONFIG_PATA_MPIIX)	+= pata_mpiix.o
 obj-$(CONFIG_PATA_NS87410)	+= pata_ns87410.o
 obj-$(CONFIG_PATA_OPTI)		+= pata_opti.o
 obj-$(CONFIG_PATA_PCMCIA)	+= pata_pcmcia.o
-obj-$(CONFIG_PATA_PALMLD)	+= pata_palmld.o
 obj-$(CONFIG_PATA_PLATFORM)	+= pata_platform.o
 obj-$(CONFIG_PATA_OF_PLATFORM)	+= pata_of_platform.o
 obj-$(CONFIG_PATA_RB532)	+= pata_rb532_cf.o
diff --git a/drivers/ata/pata_palmld.c b/drivers/ata/pata_palmld.c
deleted file mode 100644
index 51caa2a427dd..000000000000