mbox series

[v2,0/3] block zoned cleanups

Message ID 20230110143635.77300-1-p.raghav@samsung.com (mailing list archive)
Headers show
Series block zoned cleanups | expand

Message

Pankaj Raghav Jan. 10, 2023, 2:36 p.m. UTC
Hi Jens,
  It is still unclear whether the support for non-po2 zone size devices
  will be added anytime soon [1]. I have extracted out the cleanup
  patches that doesn't do any functional change but improves the
  readability by adding helpers. This also helps a bit to
  maintain off-tree support as there is an interest to have this feature
  in some companies.

[1] https://lore.kernel.org/lkml/20220923173618.6899-1-p.raghav@samsung.com/

Changes since v1:
- Remove blk_is_zoned() check in bdev_{is_zone_start, offset_from_zone_start} (Damien)
- Minor spelling and variable name changes (Bart and Johannes)
- Remove zonefs patch for now (Damien)
- Send dm patches separately(Christoph)

Pankaj Raghav (3):
  block: remove superfluous check for request queue in bdev_is_zoned()
  block: add a new helper bdev_{is_zone_start, offset_from_zone_start}
  block: introduce bdev_zone_no helper

 block/blk-core.c          |  2 +-
 block/blk-zoned.c         |  4 ++--
 drivers/nvme/target/zns.c |  3 +--
 include/linux/blkdev.h    | 22 +++++++++++++++++-----
 4 files changed, 21 insertions(+), 10 deletions(-)

Comments

Pankaj Raghav Jan. 12, 2023, 3:36 p.m. UTC | #1
ping....

On 2023-01-10 15:36, Pankaj Raghav wrote:
> Hi Jens,
>   It is still unclear whether the support for non-po2 zone size devices
>   will be added anytime soon [1]. I have extracted out the cleanup
>   patches that doesn't do any functional change but improves the
>   readability by adding helpers. This also helps a bit to
>   maintain off-tree support as there is an interest to have this feature
>   in some companies.
> 
> [1] https://lore.kernel.org/lkml/20220923173618.6899-1-p.raghav@samsung.com/
> 
> Changes since v1:
> - Remove blk_is_zoned() check in bdev_{is_zone_start, offset_from_zone_start} (Damien)
> - Minor spelling and variable name changes (Bart and Johannes)
> - Remove zonefs patch for now (Damien)
> - Send dm patches separately(Christoph)
> 
> Pankaj Raghav (3):
>   block: remove superfluous check for request queue in bdev_is_zoned()
>   block: add a new helper bdev_{is_zone_start, offset_from_zone_start}
>   block: introduce bdev_zone_no helper
> 
>  block/blk-core.c          |  2 +-
>  block/blk-zoned.c         |  4 ++--
>  drivers/nvme/target/zns.c |  3 +--
>  include/linux/blkdev.h    | 22 +++++++++++++++++-----
>  4 files changed, 21 insertions(+), 10 deletions(-)
>
Pankaj Raghav Jan. 17, 2023, 5:28 p.m. UTC | #2
Hi Jens,
  There is a Reviewed-by tag by different reviewers in all the patches.
Could we queue this up for the next release?

Regards,
Pankaj

On 2023-01-10 15:36, Pankaj Raghav wrote:
> Hi Jens,
>   It is still unclear whether the support for non-po2 zone size devices
>   will be added anytime soon [1]. I have extracted out the cleanup
>   patches that doesn't do any functional change but improves the
>   readability by adding helpers. This also helps a bit to
>   maintain off-tree support as there is an interest to have this feature
>   in some companies.
> 
> [1] https://lore.kernel.org/lkml/20220923173618.6899-1-p.raghav@samsung.com/
> 
> Changes since v1:
> - Remove blk_is_zoned() check in bdev_{is_zone_start, offset_from_zone_start} (Damien)
> - Minor spelling and variable name changes (Bart and Johannes)
> - Remove zonefs patch for now (Damien)
> - Send dm patches separately(Christoph)
> 
> Pankaj Raghav (3):
>   block: remove superfluous check for request queue in bdev_is_zoned()
>   block: add a new helper bdev_{is_zone_start, offset_from_zone_start}
>   block: introduce bdev_zone_no helper
> 
>  block/blk-core.c          |  2 +-
>  block/blk-zoned.c         |  4 ++--
>  drivers/nvme/target/zns.c |  3 +--
>  include/linux/blkdev.h    | 22 +++++++++++++++++-----
>  4 files changed, 21 insertions(+), 10 deletions(-)
>
Jens Axboe Jan. 17, 2023, 5:42 p.m. UTC | #3
On Tue, 10 Jan 2023 15:36:32 +0100, Pankaj Raghav wrote:
>   It is still unclear whether the support for non-po2 zone size devices
>   will be added anytime soon [1]. I have extracted out the cleanup
>   patches that doesn't do any functional change but improves the
>   readability by adding helpers. This also helps a bit to
>   maintain off-tree support as there is an interest to have this feature
>   in some companies.
> 
> [...]

Applied, thanks!

[1/3] block: remove superfluous check for request queue in bdev_is_zoned()
      commit: ef0e0afd782eff20d4bd0c145c647fa01aa16bb1
[2/3] block: add a new helper bdev_{is_zone_start, offset_from_zone_start}
      commit: 3b1c494c4317777da0c5a96b002f954583611345
[3/3] block: introduce bdev_zone_no helper
      commit: 803e2ec47623e5625dd3f5808c175b49f92da9d0

Best regards,