| Message ID | 20221017114705.8277-1-johan+linaro@kernel.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | PCI: qcom: Add support for modular builds | expand |
On Mon, Oct 17, 2022 at 01:47:03PM +0200, Johan Hovold wrote: > Allow the Qualcomm PCIe controller driver to be built as a module, which > is useful for multi-platform kernels as well as during development. > > There's no rush with this, but I figured I'd send an updated version > that has been rebased on 6.1-rc1 (where post_deinit() has been removed). > > I also broke out the qcom_pcie_host_deinit() handler in a separate patch > as the host_deinit() callback has now been added to dwc core and can be > used to fixes some late-probe error handling. Waiting for the dust to settle on patch 2, does it make sense to merge patch 1 on its own ? Thanks, Lorenzo > Johan > > > Changes in v3 > - rebase on 6.1-rc1 where post_deinit() has been removed > - split out host-init error handling > - add Stan's ack > > Changes in v2 > - rebase on next-20220720 (adjust context) > - add Rob and Mani's reviewed-by tags > > > Johan Hovold (2): > PCI: qcom: Fix host-init error handling > PCI: qcom: Add support for modular builds > > drivers/pci/controller/dwc/Kconfig | 2 +- > drivers/pci/controller/dwc/pcie-qcom.c | 39 +++++++++++++++++++++++--- > 2 files changed, 36 insertions(+), 5 deletions(-) > > -- > 2.37.3 >
On Fri, Jan 13, 2023 at 04:51:13PM +0100, Lorenzo Pieralisi wrote: > On Mon, Oct 17, 2022 at 01:47:03PM +0200, Johan Hovold wrote: > > Allow the Qualcomm PCIe controller driver to be built as a module, which > > is useful for multi-platform kernels as well as during development. > > > > There's no rush with this, but I figured I'd send an updated version > > that has been rebased on 6.1-rc1 (where post_deinit() has been removed). > > > > I also broke out the qcom_pcie_host_deinit() handler in a separate patch > > as the host_deinit() callback has now been added to dwc core and can be > > used to fixes some late-probe error handling. > > Waiting for the dust to settle on patch 2, does it make sense to > merge patch 1 on its own ? > Yeah, that makes sense. Thanks, Mani > Thanks, > Lorenzo > > > Johan > > > > > > Changes in v3 > > - rebase on 6.1-rc1 where post_deinit() has been removed > > - split out host-init error handling > > - add Stan's ack > > > > Changes in v2 > > - rebase on next-20220720 (adjust context) > > - add Rob and Mani's reviewed-by tags > > > > > > Johan Hovold (2): > > PCI: qcom: Fix host-init error handling > > PCI: qcom: Add support for modular builds > > > > drivers/pci/controller/dwc/Kconfig | 2 +- > > drivers/pci/controller/dwc/pcie-qcom.c | 39 +++++++++++++++++++++++--- > > 2 files changed, 36 insertions(+), 5 deletions(-) > > > > -- > > 2.37.3 > >
On Fri, Jan 13, 2023 at 04:51:13PM +0100, Lorenzo Pieralisi wrote: > On Mon, Oct 17, 2022 at 01:47:03PM +0200, Johan Hovold wrote: > > Allow the Qualcomm PCIe controller driver to be built as a module, which > > is useful for multi-platform kernels as well as during development. > > > > There's no rush with this, but I figured I'd send an updated version > > that has been rebased on 6.1-rc1 (where post_deinit() has been removed). > > > > I also broke out the qcom_pcie_host_deinit() handler in a separate patch > > as the host_deinit() callback has now been added to dwc core and can be > > used to fixes some late-probe error handling. > > Waiting for the dust to settle on patch 2, does it make sense to > merge patch 1 on its own ? Sure, please do. I haven't found the time and motivation to reiterate the arguments for why I think blocking patch 2 is misguided, but I'm still confident that anyone reviewing the arguments will reach the same conclusion (e.g. if you want to dig through the archives). I'll get to it eventually. Johan > > Changes in v3 > > - rebase on 6.1-rc1 where post_deinit() has been removed > > - split out host-init error handling > > - add Stan's ack > > > > Changes in v2 > > - rebase on next-20220720 (adjust context) > > - add Rob and Mani's reviewed-by tags > > > > > > Johan Hovold (2): > > PCI: qcom: Fix host-init error handling > > PCI: qcom: Add support for modular builds > > > > drivers/pci/controller/dwc/Kconfig | 2 +- > > drivers/pci/controller/dwc/pcie-qcom.c | 39 +++++++++++++++++++++++--- > > 2 files changed, 36 insertions(+), 5 deletions(-) > > > > -- > > 2.37.3 > >
On Mon, 17 Oct 2022 13:47:03 +0200, Johan Hovold wrote: > Allow the Qualcomm PCIe controller driver to be built as a module, which > is useful for multi-platform kernels as well as during development. > > There's no rush with this, but I figured I'd send an updated version > that has been rebased on 6.1-rc1 (where post_deinit() has been removed). > > I also broke out the qcom_pcie_host_deinit() handler in a separate patch > as the host_deinit() callback has now been added to dwc core and can be > used to fixes some late-probe error handling. > > [...] Applied to pci/qcom, thanks! [1/2] PCI: qcom: Fix host-init error handling https://git.kernel.org/lpieralisi/pci/c/6996d631fa33 Thanks, Lorenzo